Open
Conversation
filipslezaklab
requested changes
Mar 2, 2026
|
|
||
| span { | ||
| font: var(--t-body-xxs-600); | ||
| font-size: var(--body-micro-11, 11px); |
Contributor
There was a problem hiding this comment.
In design it's clearly xss-500, so use it.
| <p className="title">{title}</p> | ||
| <div className="title"> | ||
| {icon && <Icon icon={icon} size={16} staticColor={ThemeVariable.FgAttention} />} | ||
| {title} |
Contributor
There was a problem hiding this comment.
render text it in p or span tag.
| font: var(--t-body-sm-500); | ||
| color: var(--color); | ||
| text-align: center; | ||
| display: flex; |
Contributor
There was a problem hiding this comment.
restrict row flow to no-wrap
| text-align: center; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; |
| <div className="line"></div> | ||
| <p className="title">{title}</p> | ||
| <div className="title"> | ||
| {icon && <Icon icon={icon} size={16} staticColor={ThemeVariable.FgAttention} />} |
Contributor
There was a problem hiding this comment.
should be explicit bool check, use isPresent
Contributor
There was a problem hiding this comment.
Bcs Tab is shared component nad not rly for one occasion it would make more sense to pass IconProps instead of only iconKindValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to implement DefGuard/defguard#2014