[lint apply] Add PR-only pre-commit workflow & lint all#166
Open
C-Achard wants to merge 7 commits intocy/linter-cifrom
Open
[lint apply] Add PR-only pre-commit workflow & lint all#166C-Achard wants to merge 7 commits intocy/linter-cifrom
C-Achard wants to merge 7 commits intocy/linter-cifrom
Conversation
Add default_stages and explicitly set stages for hooks so checks that don't modify files can run in both pre-commit and manual/CI, while modifiers run only locally. Reorganize and document ruff hooks into local autofix/write entries (runs with --fix/unsafe-fixes and format write) and CI check-only entries (output-format=github, --check/--diff). Also set stages for pyproject-fmt and validate-pyproject, add check-* hooks to pre-commit/manual, and clarify behavior with inline comments.
Add .github/workflows/format.yml: a GitHub Actions workflow that runs pre-commit only for changed files in PRs. It triggers on pull_request (opened, synchronize, reopened), uses a detect_changes job to checkout full history and compute the list of files changed against the base branch, and exposes that list as an output. A precommit job (guarded by a condition that changed files exist) checks out the PR branch, sets up Python 3.12, installs pre-commit, and runs pre-commit only on the changed files.
Manual fixes: - Reordered some __init__ calls and added some __all__ - Added tensorrt import best-effort in one file - __init__.py ignores E402 due to requiring registry update
C-Achard
force-pushed
the
cy/linter-ci-apply
branch
from
f406b41 to
95761db
Compare
Replace the single-line echo that wrote CHANGED_FILES to $GITHUB_OUTPUT with a here-document (key<<EOF ... EOF) to correctly export multi-line file lists. This preserves newlines and spaces in the changed-files output so downstream workflow steps receive the full list.
1 task
C-Achard
changed the title
| fix = true | ||
| [tool.ruff.lint] | ||
| select = [ "E", "F", "B", "I", "UP" ] | ||
| ignore = [ "E741", "E501", "F403", "F401" ] |
Collaborator
There was a problem hiding this comment.
no F401 or E501? those are some of the main guys!
Collaborator
|
It's beautiful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .github/workflows/format.yml
GitHub Actions workflow that runs pre-commit only for changed files in PRs.
It triggers on pull_request (opened, synchronize, reopened), uses a detect_changes job to checkout full history and compute the list of files changed against the base branch, and exposes that list as an output.
A precommit job (guarded by a condition that changed files exist) checks out the PR branch, sets up Python 3.12, installs pre-commit, and runs pre-commit only on the changed files.