Fix modelzoo configs: add to package-data#163
Merged
deruyter92 merged 3 commits intomainfrom Feb 19, 2026
Merged
Conversation
C-Achard
approved these changes
Feb 19, 2026
Collaborator
C-Achard
left a comment
C-Achard
left a comment
There was a problem hiding this comment.
Looks good, just one minor simplification I think we can make. Thanks !
Comment on lines
+1
to
+3
| include dlclive/check_install/* | ||
| include dlclive/modelzoo/model_configs/*.yaml | ||
| include dlclive/modelzoo/project_configs/*.yaml No newline at end of file |
Collaborator
There was a problem hiding this comment.
I think this is technically redundant with [tool.setuptools.package-data], perhaps we can favor the toml as the single source of package data ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modelzoo configs were not added to package-data making the yaml files unavailable when building the repository. Fixed by adding the config paths to MANIFEST.in and pyproject.toml
also refactored: