Skip to content

Conversation

@yunatamos
Copy link

Description

Brief description of what this PR does.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring (no functional changes)
  • Dependency update

Changes Made

  • Change 1
  • Change 2
  • Change 3

Testing

  • I have tested this change locally
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested the desktop application on my platform

Test Configuration:

  • OS: (e.g., Windows 11, macOS 14, Ubuntu 22.04)
  • Node version: (e.g., 18.17.0)
  • pnpm version: (e.g., 8.6.0)

Screenshots (if applicable)

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

Copy link
Owner

@DavidAmunga DavidAmunga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @yunatamos ! I appreciate the effort, but I need to request changes due to security and privacy concerns ie:

  1. Password Caching: Cannot store passwords (even with hashing) security concern
  2. Base64 PDF Storage - Same as 1 , localStorage is also limited.

If the goal is file history, let's store , would recommend likely using a FileHistory approach.

ie:

interface FileHistory {
  id: string;
  fileName: string;
  processedAt: Date;
  transactionCount: number;
}

Ideally keeping the initial promise of no raw PDF's/passwords being maintained. and later on provide a flow where the data can be re-exported in different formats too

@yunatamos
Copy link
Author

Thanks for the contribution @yunatamos ! I appreciate the effort, but I need to request changes due to security and privacy concerns ie:

  1. Password Caching: Cannot store passwords (even with hashing) security concern
  2. Base64 PDF Storage - Same as 1 , localStorage is also limited.

If the goal is file history, let's store , would recommend likely using a FileHistory approach.

ie:

interface FileHistory {
  id: string;
  fileName: string;
  processedAt: Date;
  transactionCount: number;
}

Ideally keeping the initial promise of no raw PDF's/passwords being maintained. and later on provide a flow where the data can be re-exported in different formats too

1.so reason kuwa na password caching is because user anaeza sahau their password ama alishadelete.
2. Can i have it not store any pdf just some iforation like file name, total transaction and ranging date?

@DavidAmunga
Copy link
Owner

Thanks for the contribution @yunatamos ! I appreciate the effort, but I need to request changes due to security and privacy concerns ie:

  1. Password Caching: Cannot store passwords (even with hashing) security concern
  2. Base64 PDF Storage - Same as 1 , localStorage is also limited.

If the goal is file history, let's store , would recommend likely using a FileHistory approach.
ie:

interface FileHistory {
  id: string;
  fileName: string;
  processedAt: Date;
  transactionCount: number;
}

Ideally keeping the initial promise of no raw PDF's/passwords being maintained. and later on provide a flow where the data can be re-exported in different formats too

1.so reason kuwa na password caching is because user anaeza sahau their password ama alishadelete. 2. Can i have it not store any pdf just some iforation like file name, total transaction and ranging date?

Yep for No.1 is good , just don't store it in localstorage.
For No 2 is actually fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants