-
Notifications
You must be signed in to change notification settings - Fork 5
Add saving recent files #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
DavidAmunga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @yunatamos ! I appreciate the effort, but I need to request changes due to security and privacy concerns ie:
- Password Caching: Cannot store passwords (even with hashing) security concern
- Base64 PDF Storage - Same as 1 , localStorage is also limited.
If the goal is file history, let's store , would recommend likely using a FileHistory approach.
ie:
interface FileHistory {
id: string;
fileName: string;
processedAt: Date;
transactionCount: number;
}Ideally keeping the initial promise of no raw PDF's/passwords being maintained. and later on provide a flow where the data can be re-exported in different formats too
1.so reason kuwa na password caching is because user anaeza sahau their password ama alishadelete. |
Yep for No.1 is good , just don't store it in localstorage. |
Description
Brief description of what this PR does.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Changes Made
Testing
Test Configuration:
Screenshots (if applicable)
Checklist
Additional Notes