fix: raise CMake version to 3.5#948
Closed
6carbon12 wants to merge 1 commit intoDaveGamble:masterfrom
6carbon12:fix-cmake-version
Closed
fix: raise CMake version to 3.5#9486carbon12 wants to merge 1 commit intoDaveGamble:masterfrom 6carbon12:fix-cmake-version
6carbon12 wants to merge 1 commit intoDaveGamble:masterfrom
6carbon12:fix-cmake-version
Conversation
The previous minimum version was set to 3.0, which was deprecated in CMake 4.0. This caused build failures for users with newer versions of CMake. Raising the minimum required version to 3.5 fixes the issue while maintaining compatibility with existing setups. Fixes #946
Author
|
I noticed there's an earlier PR (#935) that also addresses this CMake version bump, but it seems to have stalled and is failing a CIFuzz check. Happy to revise if needed — just putting this up in case it helps move things forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous minimum version was set to 3.0, which was deprecated in CMake 4.0. This caused build failures for users with newer versions of CMake.
Previously, building the project with CMake 4.0 would fail due to the line:
cmake_minimum_required(VERSION 3.0)This is now bumped to 3.5 to match the new compatibility requirements.
Fixes #946