Fix prefix/postfix buttons disappearing when colReorder is also used#190
Open
demetris-manikas wants to merge 1 commit intoDataTables:masterfrom
Open
Fix prefix/postfix buttons disappearing when colReorder is also used#190demetris-manikas wants to merge 1 commit intoDataTables:masterfrom
demetris-manikas wants to merge 1 commit intoDataTables:masterfrom
Conversation
Contributor
|
Many thanks for this! I'll review it properly before the next Buttons release. Are you happy for this to be included under the MIT license? |
Author
|
Yes of course I am. |
Author
|
I have also created an almost identical to colVis extension (renames mostly) for manipulating the searchable property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I use both the colVis and colReorder plugins and I noticed that if a column has been moved then
all prefix/postfix buttons that I have defined along with the colvis button vanish.
Here is the definition I use
This PR addresses this issue.
Please let me know whether I should setup a showcase for this.
Thanks a lot for your time.