Open
Conversation
Collaborator
|
That's awesome - thank you for this. I'm not going to pull it in immediately as I'd like to sync this up with the same ability in pdf export, and I'd like to think about the implementation a little, but I think others will find this really useful. |
Author
|
Absolutely. I still need to copy this logic into buttons.flash.js, write some tests, and as I woke up this morning I remembered that the "t" attribute needs to be set to "str". Definitely some polishing to do yet, but I wanted to get the core up for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://stackoverflow.com/questions/40243616/jquery-datatables-export-to-excelhtml5-hyperlink-issue/49146977
This patch extends the special formatting capability of the Excel exporter to detect the "=FUNCTION(...)" signature customary in Excel, specifically for hyperlinks.
This PR does not attempt to solve the broader hyperlink rendering issue, though along the lines of the fourth example at https://datatables.net/reference/option/columns.render#Examples, a user could add a renderer for a custom 'excel' orthogonal:
then configure the export button to use it: