Skip to content

widen acceptable range in tag list size comparison#6588

Merged
emmettbutler merged 4 commits intomainfrom
emmett.butler/atleast-tags
Mar 25, 2026
Merged

widen acceptable range in tag list size comparison#6588
emmettbutler merged 4 commits intomainfrom
emmett.butler/atleast-tags

Conversation

@emmettbutler
Copy link
Copy Markdown
Contributor

@emmettbutler emmettbutler commented Mar 25, 2026

Motivation

This test failure https://github.com/DataDog/dd-trace-py/actions/runs/23545612388/job/68545970077?pr=17006 on a pull request that adds a new tag to all dd-trace-py spans

This one too https://github.com/DataDog/dd-trace-py/actions/runs/23545612388/job/68545887642?pr=17006

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

CODEOWNERS have been resolved as:

tests/integration_frameworks/llm/utils.py                               @DataDog/ml-observability
tests/parametric/test_telemetry.py                                      @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@emmettbutler emmettbutler requested review from a team as code owners March 25, 2026 14:45
@emmettbutler emmettbutler requested review from mhlidd and removed request for a team March 25, 2026 14:45
@emmettbutler emmettbutler added the python Pull requests that update Python code label Mar 25, 2026
@emmettbutler emmettbutler enabled auto-merge (squash) March 25, 2026 21:38
@emmettbutler emmettbutler merged commit 0cda6ba into main Mar 25, 2026
454 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/atleast-tags branch March 25, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants