Conversation
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 0174f35 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0174f356cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ref_owner = [*sorted(test_data_item.nodeid_to_owners.get(node, set())), ""][0] | ||
| if code_owner is not None and code_owner != ref_owner: | ||
| continue |
There was a problem hiding this comment.
Activate multi-owner tests for each owner branch
When --split-co is enabled, owner filtering keeps only the first sorted owner for each test (ref_owner) and skips all other owners. If a test report contains multiple owners in metadata.owners, only one owner branch gets the activation and the other owner-specific PRs silently miss that test. This breaks the per-code-owner split for shared ownership cases.
Useful? React with 👍 / 👎.
| base_branch = subprocess.run( | ||
| ["git", "rev-parse", "--abbrev-ref", "HEAD"], check=True, capture_output=True, text=True | ||
| ).stdout.strip() |
There was a problem hiding this comment.
Restore split-co loop to a stable base commit
Using git rev-parse --abbrev-ref HEAD can return HEAD in detached-head runs; in that case, git checkout back to base_branch after the first owner commit does not return to the original baseline and subsequent owner branches are generated from already-modified history. This can mix activations across owners whenever the script is executed from a detached checkout (a common CI execution mode).
Useful? React with 👍 / 👎.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present