Skip to content

Easy win per code owner#6549

Merged
nccatoni merged 10 commits intomainfrom
nccatoni/ew-co
Mar 26, 2026
Merged

Easy win per code owner#6549
nccatoni merged 10 commits intomainfrom
nccatoni/ew-co

Conversation

@nccatoni
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/scripts/activate_easy_wins/_internal/logger.py                    @DataDog/system-tests-core
.github/workflows/nightly.yml                                           @DataDog/system-tests-core
tests/test_the_test/test_easy_win.py                                    @DataDog/system-tests-core
utils/const/_const.py                                                   @DataDog/system-tests-core
utils/scripts/activate_easy_wins/__main__.py                            @DataDog/system-tests-core
utils/scripts/activate_easy_wins/_internal/const.py                     @DataDog/system-tests-core
utils/scripts/activate_easy_wins/_internal/core.py                      @DataDog/system-tests-core
utils/scripts/activate_easy_wins/_internal/manifest_editor.py           @DataDog/system-tests-core
utils/scripts/activate_easy_wins/_internal/test_artifact.py             @DataDog/system-tests-core
utils/scripts/activate_easy_wins/_internal/types.py                     @DataDog/system-tests-core

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 bot commented Mar 20, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0174f35 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@nccatoni nccatoni marked this pull request as ready for review March 26, 2026 16:03
@nccatoni nccatoni requested a review from a team as a code owner March 26, 2026 16:03
@nccatoni nccatoni merged commit ae60956 into main Mar 26, 2026
1965 of 1967 checks passed
@nccatoni nccatoni deleted the nccatoni/ew-co branch March 26, 2026 16:03
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0174f356cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +57 to +59
ref_owner = [*sorted(test_data_item.nodeid_to_owners.get(node, set())), ""][0]
if code_owner is not None and code_owner != ref_owner:
continue
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Activate multi-owner tests for each owner branch

When --split-co is enabled, owner filtering keeps only the first sorted owner for each test (ref_owner) and skips all other owners. If a test report contains multiple owners in metadata.owners, only one owner branch gets the activation and the other owner-specific PRs silently miss that test. This breaks the per-code-owner split for shared ownership cases.

Useful? React with 👍 / 👎.

Comment on lines +90 to +92
base_branch = subprocess.run(
["git", "rev-parse", "--abbrev-ref", "HEAD"], check=True, capture_output=True, text=True
).stdout.strip()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore split-co loop to a stable base commit

Using git rev-parse --abbrev-ref HEAD can return HEAD in detached-head runs; in that case, git checkout back to base_branch after the first owner commit does not return to the original baseline and subsequent owner branches are generated from already-modified history. This can mix activations across owners whenever the script is executed from a detached checkout (a common CI execution mode).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant