Update SSI auto-injection tests to validate workload selection policies#6501
Conversation
|
|
1fe69a4 to
8b93400
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9628e250f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "CONTAINER_AUTO_INJECTION_INSTALL_SCRIPT_APPSEC" | ||
| ], | ||
| "tests/auto_inject/test_blocklist_auto_inject.py::TestAutoInjectBlockListInstallManualHost::test_builtin_block_commands": [ | ||
| "tests/auto_inject/test_auto_inject_workload_selection.py::TestAutoInjectWorkloadSelectionInstallManualHost::test_commands_excluded_by_workload_policy": [ |
There was a problem hiding this comment.
Align scenario map nodeids with renamed test methods
The scenario map now references nodeids such as test_commands_excluded_by_workload_policy/test_args_*, but the renamed test file defines test_no_language_found_commands, test_commands_denied_by_workload_selection, and test_commands_allowed_by_workload_selection instead (tests/auto_inject/test_auto_inject_workload_selection.py, lines 77/93/112). Because compute_libraries_and_scenarios.py matches manifest changes by nodeid prefix, manifest updates targeting the real method names will no longer resolve to INSTALLER_AUTO_INJECTION, causing CI scenario selection to miss these tests.
Useful? React with 👍 / 👎.
366538d to
bbcd9c0
Compare
…ection instead of deny lists
bbcd9c0 to
72042ae
Compare
e922a18 to
72042ae
Compare
fe4c8b8
into
main
Motivation
These tests used to rely on commands listed in the SDK’s requirements.json (e.g. java -version, dotnet restore) being denied for auto-injection, and asserted on logs within the Go process such as “not injecting; on deny list”. With evaluation moving to requirements.bin, those commands are denied earlier by workload selection, before the Go process runs, so those Go log lines no longer appear and the old assertions fail.
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is presentINPLAT-1018