Skip to content

Auto-activate nodejs manifest tests#6490

Closed
dd-octo-sts[bot] wants to merge 3 commits intomainfrom
auto-nodejs-manifest
Closed

Auto-activate nodejs manifest tests#6490
dd-octo-sts[bot] wants to merge 3 commits intomainfrom
auto-nodejs-manifest

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts bot commented Mar 13, 2026

Automated activation of easy-win tests for nodejs
View nightly workflow run

  • If you approve this PR please also merge it.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

@dd-octo-sts
Update nodejs manifest activation
d54ee7f 
This commit was created from the local commit with hash d04984657f2402a3224bf462010ec58f43f496ec.
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner March 13, 2026 14:48
@dd-octo-sts dd-octo-sts bot enabled auto-merge (squash) March 13, 2026 14:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Mar 20, 2026 •
edited by datadog-official bot
Loading

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 12 Tests failed

tests.stats.test_stats.Test_Client_Stats.test_grpc_status_code[express4] from system_tests_suite   View in Datadog   (Fix with Cursor) 
AssertionError: Expected at least one gRPC stats entry in the v0.6/stats payload
assert []

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7f6f90f68860>

    def test_grpc_status_code(self):
        grpc_stats = []
    
        for data in interfaces.library.get_data("/v0.6/stats"):
            payload = data["request"]["content"]
...
tests.stats.test_stats.Test_Client_Stats.test_grpc_status_code[express4] from system_tests_suite   View in Datadog   (Fix with Cursor) 
AssertionError: Expected at least one gRPC stats entry in the v0.6/stats payload
assert []

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7fb892e7a540>

    def test_grpc_status_code(self):
        grpc_stats = []
    
        for data in interfaces.library.get_data("/v0.6/stats"):
            payload = data["request"]["content"]
...
tests.stats.test_stats.Test_Client_Stats.test_grpc_status_code[express4-typescript] from system_tests_suite   View in Datadog   (Fix with Cursor) 
AssertionError: Expected at least one gRPC stats entry in the v0.6/stats payload
assert []

self = <tests.stats.test_stats.Test_Client_Stats object at 0x7f90d9574cb0>

    def test_grpc_status_code(self):
        grpc_stats = []
    
        for data in interfaces.library.get_data("/v0.6/stats"):
            payload = data["request"]["content"]
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0e9d76a | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

watson
watson reviewed Mar 23, 2026
View reviewed changes
Comment thread manifests/nodejs.yml
tests/appsec/test_only_python.py::Test_ImportError: irrelevant (specific tests for python tracer)
tests/appsec/test_rate_limiter.py::Test_Main: v2.0.0
tests/appsec/test_rate_limiter.py::Test_Main::test_main:
tests/appsec/test_rate_limiter.py::Test_Main::test_main: # TODO: a lower version might be supported
Copy link
Copy Markdown
Contributor

@watson watson Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a mistake by the script

Copy link
Copy Markdown
Collaborator

@nccatoni nccatoni Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an easy win (the test is passing for the current version) but the message is indeed unclear. I changed it by mistake when I changed the other messages. I will change it back

Comment thread manifests/nodejs.yml
tests/appsec/waf/test_blocking.py::Test_Blocking::test_accept_full_html: missing_feature (Support for quality not implemented)
tests/appsec/waf/test_blocking.py::Test_Blocking::test_accept_partial_html: missing_feature (Support for partial html not implemented)
tests/appsec/waf/test_blocking.py::Test_Blocking::test_html_template_v2:
tests/appsec/waf/test_blocking.py::Test_Blocking::test_html_template_v2: # TODO: a lower version might be supported
Copy link
Copy Markdown
Contributor

@watson watson Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a mistake by the script

Comment thread manifests/nodejs.yml
fastify: *ref_5_62_0
tests/integrations/test_dsm.py::Test_Dsm_Manual_Checkpoint_Intra_Process::test_dsm_manual_checkpoint_intra_process: irrelevant (Node.js doesn't sort the DSM edge tags and has different hashes.)
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation:
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation: # TODO: a lower version might be supported
Copy link
Copy Markdown
Contributor

@watson watson Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a mistake by the script

Comment thread manifests/nodejs.yml
express5: ">=5.37.0 <5.88.0"
fastify: ">=5.37.0 <5.88.0"
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation_With_Distributed_Context:
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation_With_Distributed_Context: # TODO: a lower version might be supported
Copy link
Copy Markdown
Contributor

@watson watson Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a mistake by the script

Comment thread manifests/nodejs.yml
express5: ">=5.37.0 <5.88.0"
fastify: ">=5.37.0 <5.88.0"
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation_With_Error:
tests/integrations/test_inferred_proxy.py::Test_AWS_API_Gateway_Inferred_Span_Creation_With_Error: # TODO: a lower version might be supported
Copy link
Copy Markdown
Contributor

@watson watson Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a mistake by the script

@nccatoni
Copy link
Copy Markdown
Collaborator

nccatoni commented Mar 26, 2026

I fixed the comment issue and the failing tests are due to a test that was added after the last script run. I'm closing this PR so a new one can be generated

@nccatoni nccatoni closed this Mar 26, 2026
auto-merge was automatically disabled March 26, 2026 09:31

Pull request was closed

@nccatoni nccatoni deleted the auto-nodejs-manifest branch March 26, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@watson watson watson left review comments

@nccatoni nccatoni nccatoni left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nccatoni @watson @simon-id