Skip to content

Enable OF.7 empty targeting key test for Java and Go#6118

Draft
leoromanovsky wants to merge 2 commits intomainfrom
leo/enable-of7-empty-targeting-key
Draft

Enable OF.7 empty targeting key test for Java and Go#6118
leoromanovsky wants to merge 2 commits intomainfrom
leo/enable-of7-empty-targeting-key

Conversation

@leoromanovsky
Copy link
Copy Markdown
Contributor

The OpenFeature Java SDK 1.20.1 fixed the empty targeting key issue (open-feature/java-sdk#1807), and dd-trace-go main also has the fix (DataDog/dd-trace-go#4361).

Only Node.js (FFL-1730) still needs the skip.

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

The OpenFeature Java SDK 1.20.1 fixed the empty targeting key issue
(open-feature/java-sdk#1807), and dd-trace-go main also has the fix
(DataDog/dd-trace-go#4361).

Only Node.js (FFL-1730) still needs the skip.
@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/test_ffe/test_dynamic_evaluation.py                    @DataDog/feature-flagging-and-experimentation-sdk @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Jan 26, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.parametric.test_parametric_endpoints.Test_Parametric_DDTrace_Crash.test_crash[library_env0, parametric-ruby] from system_tests_suite (Datadog) (Fix with Cursor)
assert not True
 +  where True = <bound method ParametricTestClientApi.is_alive of <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7facf7c6abd0>>()
 +    where <bound method ParametricTestClientApi.is_alive of <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7facf7c6abd0>> = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7facf7c6abd0>.is_alive

self = <tests.parametric.test_parametric_endpoints.Test_Parametric_DDTrace_Crash object at 0x7fad2c7f84d0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7facf7c6abd0>

    def test_crash(self, test_library: APMLibrary):
        """Validates that /trace/crash crashes the current process.
    
...

🧪 1 Test failed

tests.parametric.test_ffe.test_dynamic_evaluation.Test_Feature_Flag_Dynamic_Evaluation.test_ffe_flag_evaluation[test-case-of-7-empty-targeting-key.json-library_env0, parametric-java] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Test case 0 in test-case-of-7-empty-targeting-key.json failed: flag='empty-targeting-key-flag', targetingKey='', expected=on-value, actual=default
assert 'default' == 'on-value'
  - on-value
  + default

self = <tests.parametric.test_ffe.test_dynamic_evaluation.Test_Feature_Flag_Dynamic_Evaluation object at 0x7f28727776b0>
test_case_file = 'test-case-of-7-empty-targeting-key.json'
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f2870437d10>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f2870134c80>

...
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 14eba04 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant