wip: datadog-container-id header when running system tests locally #6098
+188
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
cbeauchesne
requested changes
Jan 23, 2026
Collaborator
cbeauchesne
left a comment
cbeauchesne
left a comment
There was a problem hiding this comment.
Some minor cosmetic requests changes
| volumes: dict | None = None, | ||
| working_dir: str | None = None, | ||
| pid_mode: str | None = None, | ||
| cgroupns_mode: str | None = None, |
Collaborator
There was a problem hiding this comment.
Can you keep this identical to docker run method :
Suggested change
| cgroupns_mode: str | None = None, | |
| cgroupns: Literal['private', 'host'] | None = None, |
| name=self.container_name, | ||
| hostname=self.name, | ||
| environment=self.environment, | ||
| # Build run arguments |
Collaborator
There was a problem hiding this comment.
By keeping the cgroupns identical to the one used by run method, you can keep the current code design.
| # Set cgroupns to host mode to ensure container ID is visible in /proc/self/cgroup | ||
| # This is particularly important for Docker Desktop on macOS where the default | ||
| # private cgroup namespace shows "/" as the cgroup path | ||
| self.weblog_container.cgroupns_mode = "host" |
Collaborator
There was a problem hiding this comment.
This line should be in DefaultScenario.__init__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am using the following test:
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present