Add two new decorators to replace the force skip option

[nccatoni]

Motivation

Changes

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[github-actions]

CODEOWNERS have been resolved as:

tests/test_the_test/test_slow_and_crash_decorators.py                   @DataDog/system-tests-core
conftest.py                                                             @DataDog/system-tests-core
utils/__init__.py                                                       @DataDog/system-tests-core
utils/_decorators.py                                                    @DataDog/system-tests-core

[datadog-official]

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.appsec.api_security.test_schemas.Test_Scanners.test_request_method[spring-boot-payara] from system_tests_suite (Datadog) (Fix with Cursor)

assert None

self = <tests.appsec.api_security.test_schemas.Test_Scanners object at 0x7f437ad58440>

    def test_request_method(self):
        """Can provide request header schema"""
        schema_cookies = get_schema(self.request, "req.cookies")
        schema_headers = get_schema(self.request, "req.headers")
        assert self.request.status_code == 200
>       assert schema_cookies
...

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ee4be43 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

[cbeauchesne]

Could you write some test?

By reading your code, I think it does not do what we expect (skip if it's annotated with flaky/bug/missing_feature), but inconditionally skip the test.

[cbeauchesne]

Using _decorator adds a lot of needless complexity, you can simply use this :

slow = pytest.mark.skip_if_xfail
"""Decorator, allow to mark a test function/class as slow to run.
Such tests are only executed if they were not deactivated
"""

scenario_crash = pytest.mark.skip_if_xfail
"""Decorator, allow to mark a test function/class as making its scenario crash when failing.
Such tests are only executed if they were not deactivated
"""

[nccatoni]

If this works why don't we do something similar for all the decorators?

[cbeauchesne]

the usage should be simply

@slow

without the parenthesis