Use ffe-system-test-data submodule for FFE test data #6089
+8
−5,987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace duplicated FFE test JSON files with a git submodule from the canonical ffe-system-test-data repository. This ensures test data stays in sync across all tracer libraries. Changes: - Add ffe-data submodule pointing to ffe-system-test-data repo - Remove duplicated flags-v1.json and test-*.json files - Update test_dynamic_evaluation.py to load from submodule paths
Contributor
|
|
Collaborator
|
Side request, could we use for repo name |
Contributor
Author
The feedback being to make the word "test" plural? Yea that sounds fine but overall the expectation isn't that it is 1:1 connected with this system test repo, the files will be linked to individual trace libraries too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ffe-system-test-datarepositorytest_dynamic_evaluation.pyto load test data from submodule pathsMotivation
FFE test data files were duplicated across multiple repos (system-tests, dd-trace-py, dd-trace-dotnet, dd-trace-java). This creates maintenance burden when updating test cases.
The
ffe-system-test-datarepo serves as the canonical source of truth, consumed via git submodule.Dependencies
Test plan
./run.sh PARAMETRIC --scenario TEST_FEATURE_FLAG_DYNAMIC_EVALUATION