-
Notifications
You must be signed in to change notification settings - Fork 14
[FFE] Add test for ISO 8601 dates with microsecond precision #6087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
leoromanovsky
wants to merge
1
commit into
main
Choose a base branch
from
leo/add-microsecond-date-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add microsecond-date-test flag with 6-digit fractional seconds to verify that SDKs correctly parse ISO 8601 dates with variable precision. The backend may send dates with microsecond precision (e.g., from PostgreSQL) which is valid ISO 8601 but was not being handled by all SDKs.
Contributor
|
|
|
This was referenced Jan 22, 2026
[Feature Flags] Fix ISO 8601 date parsing to support variable precision
DataDog/dd-trace-dotnet#8089
Closed
Member
|
Shall we add a bug annotation for java and dotnet and merge this? I'm generally in favor of merging new system tests before fixes to tracers:
The only downside is that we need a follow up PR to system tests to (re)enable tests after the fix. |
leoromanovsky
added a commit
to DataDog/dd-trace-dotnet
that referenced
this pull request
Jan 23, 2026
…on (#8094) The date parser was using TryParseExact with a fixed 3-digit millisecond format, causing PARSE_ERROR for dates with 6-digit microsecond precision (e.g., "2025-09-23T15:48:37.235982Z") sent by the backend. Changed to use DateTime.TryParse with DateTimeStyles.RoundtripKind which correctly handles all valid ISO 8601 date formats including: - No fractional seconds: 2020-01-01T00:00:00Z - 1-7 digit fractional seconds (beyond 7 digits truncated by .NET) Added comprehensive unit tests for various date precisions and invalid date handling. Also added microsecond-date-test flag and test cases to the bundled test data. ## Summary of changes ## Reason for change ## Implementation details ## Test coverage Associating a new system test (also discovered this condition in java): DataDog/system-tests#6087 ## Other details <!-- Fixes #{issue} --> <!--⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add microsecond-date-test flag with 6-digit fractional seconds to verify that SDKs correctly parse ISO 8601 dates with variable precision.
The backend may send dates with microsecond precision (e.g., from PostgreSQL) which is valid ISO 8601 but was not being handled by all SDKs.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present