refactor(flusher): use &self instead of &mut self for flush methods#69
Merged
duncanista merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
The Flusher methods (get_dd_api, flush, flush_metrics) previously required &mut self, forcing callers to wrap the flusher in a Mutex. Since tokio::sync::OnceCell::get_or_init() only requires &self, we can change all methods to use &self, enabling lock-free usage. Also fixes test assertions: 404 is a permanent error (4xx) that should not be retried, so flush_metrics correctly returns None.
Lewis-E
approved these changes
Feb 5, 2026
duncanista
deleted the
jordan.gonzalez/dogstatsd/refactor-using-mutable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors code to improve how
&selfis usedMotivation
The Flusher methods (get_dd_api, flush, flush_metrics) previously required &mut self, forcing callers to wrap the flusher in a Mutex.
Since tokio::sync::OnceCell::get_or_init() only requires &self, we can change all methods to use &self, enabling lock-free usage.