Skip to content

[fix]: Improve error logging for metric insertion failures in dogstatsd#68

Merged
litianningdatadog merged 2 commits intomainfrom
tianning.li/SVLS-8464
Feb 3, 2026
Merged

[fix]: Improve error logging for metric insertion failures in dogstatsd#68
litianningdatadog merged 2 commits intomainfrom
tianning.li/SVLS-8464

Conversation

@litianningdatadog
Copy link
Contributor

@litianningdatadog litianningdatadog commented Feb 3, 2026

Improve error logging for metric insertion failures in dogstatsd

https://datadoghq.atlassian.net/browse/SVLS-8464

Motivation

While warning message is logged when batch insertion of metrics fails, it is unclear which metric/metrics are impacted. Hence we introduced this change to improve observability

  • Fix use-after-move error by capturing metric name before insert
  • Log both metric name and error details when insertion fails
  • Add test case to verify overflow error handling

Testing

  • Unit test
  • Tested with bottlecap
  1. Test function
  2. Logs
image

@litianningdatadog litianningdatadog requested review from a team as code owners February 3, 2026 15:21
@litianningdatadog litianningdatadog requested review from duncanpharvey and removed request for a team February 3, 2026 15:21
@litianningdatadog litianningdatadog changed the title [fix]: improve error logging for metric insertion failures in dogstatsd [fix]: Tmprove error logging for metric insertion failures in dogstatsd Feb 3, 2026
@litianningdatadog litianningdatadog changed the title [fix]: Tmprove error logging for metric insertion failures in dogstatsd [fix]: Improve error logging for metric insertion failures in dogstatsd Feb 3, 2026
@litianningdatadog litianningdatadog merged commit 9e63555 into main Feb 3, 2026
26 checks passed
@litianningdatadog litianningdatadog deleted the tianning.li/SVLS-8464 branch February 3, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants