Add Windows Named Pipes to the Trace Agent#58
Conversation
dd1034e to
1d378cf
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jcstorms1
left a comment
There was a problem hiding this comment.
General logic looks good to me and similar to the windows extension. I'll defer more technical comments to others with more expertise.
duncanpharvey
left a comment
There was a problem hiding this comment.
Following the addition of profiling support, do we need named pipes there as well? Maybe that's something we can handle in a separate PR.
48b71a1 to
8773d05
Compare
8773d05 to
a460f25
Compare
3aacad0 to
27fdcc1
Compare
27fdcc1 to
1fc9d37
Compare
duncanpharvey
left a comment
There was a problem hiding this comment.
LGTM! Can you address the merge conflicts that fix the clippy warnings? Then this is good to merge!
b332122 to
340b205
Compare
What does this PR do?
Motivation
Additional Notes
Describe how to test/QA your changes