fix(libdd-telemetry): serialize Method::Other as "*" per OpenAPI spec#1998
Open
cataphract wants to merge 1 commit into
Open
fix(libdd-telemetry): serialize Method::Other as "*" per OpenAPI spec#1998cataphract wants to merge 1 commit into
cataphract wants to merge 1 commit into
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Contributor
🔒 Cargo Deny Results📦
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: cbd925c | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
==========================================
- Coverage 72.69% 72.66% -0.04%
==========================================
Files 452 452
Lines 74886 74886
==========================================
- Hits 54438 54413 -25
- Misses 20448 20473 +25
🚀 New features to boost your workflow:
|
cataphract
changed the title
The serde rename_all = "UPPERCASE" attribute was causing Other to serialize as "OTHER" on the wire, but the OpenAPI spec defines "*" as the valid value for this variant.
cataphract
force-pushed
the
glopes/fix-method-other-serialization
branch
from
f5807e0 to
cbd925c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Methodenum'sOthervariant was serializing as"OTHER"on the wire dueto the
#[serde(rename_all = "UPPERCASE")]attribute. However, theOpenAPI spec
defines
"*"as the value for this variant —"OTHER"does not appear in theschema at all. The existing code comment acknowledged this discrepancy but did not
fix it.
This PR adds
#[serde(rename = "*")]onOtherto override the enum-levelrename_allfor that one variant, making the wire value match the spec.Impact
Method::Othernow serializes/deserializes as"*"instead of"OTHER"DDOG_METHOD_OTHER = 9is unchanged — ABI-stable for FFI consumerscbindgenreads Rust identifiers, not serde attributes, so the generated header is unaffected🤖 Generated with Claude Code