fix(crashtracking): fix SIGCHLD signal guarding while in CT signal handler#1807
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1807 +/- ##
==========================================
- Coverage 71.10% 71.05% -0.05%
==========================================
Files 411 411
Lines 64989 65037 +48
==========================================
+ Hits 46209 46212 +3
- Misses 18780 18825 +45
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d8a06b8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
BenchmarksComparisonBenchmark execution time: 2026-03-26 15:58:08 Comparing candidate commit d8a06b8 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 5.000µs | 5.079µs ± 0.041µs | 5.067µs ± 0.022µs | 5.096µs | 5.150µs | 5.152µs | 5.154µs | 1.70% | 0.556 | -0.743 | 0.81% | 0.003µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.073µs; 5.085µs] or [-0.112%; +0.112%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 161.378µs | 162.254µs ± 0.289µs | 162.238µs ± 0.144µs | 162.381µs | 162.719µs | 163.038µs | 163.897µs | 1.02% | 1.217 | 5.690 | 0.18% | 0.020µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [162.214µs; 162.294µs] or [-0.025%; +0.025%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_serialize_compressed_pprof_timestamped_x1000 | execution_time | 918.648µs | 921.274µs ± 1.276µs | 921.157µs ± 0.744µs | 921.982µs | 923.213µs | 924.623µs | 928.199µs | 0.76% | 1.238 | 4.677 | 0.14% | 0.090µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_serialize_compressed_pprof_timestamped_x1000 | execution_time | [921.097µs; 921.451µs] or [-0.019%; +0.019%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 14.717ms | 14.748ms ± 0.017ms | 14.745ms ± 0.008ms | 14.755ms | 14.776ms | 14.809ms | 14.838ms | 0.63% | 1.793 | 6.065 | 0.12% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [14.746ms; 14.750ms] or [-0.016%; +0.016%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.139ms | 4.143ms ± 0.002ms | 4.143ms ± 0.001ms | 4.144ms | 4.146ms | 4.148ms | 4.153ms | 0.26% | 0.858 | 2.385 | 0.05% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.142ms; 4.143ms] or [-0.007%; +0.007%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 747.452µs | 749.049µs ± 0.676µs | 749.068µs ± 0.488µs | 749.513µs | 750.138µs | 750.689µs | 750.943µs | 0.25% | 0.120 | -0.433 | 0.09% | 0.048µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [748.956µs; 749.143µs] or [-0.013%; +0.013%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.323µs | 2.367µs ± 0.019µs | 2.360µs ± 0.007µs | 2.378µs | 2.410µs | 2.420µs | 2.426µs | 2.77% | 1.133 | 1.139 | 0.78% | 0.001µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.365µs; 2.370µs] or [-0.108%; +0.108%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | 4.146ms | 4.151ms ± 0.007ms | 4.150ms ± 0.001ms | 4.152ms | 4.155ms | 4.160ms | 4.249ms | 2.37% | 11.469 | 147.154 | 0.18% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | [4.150ms; 4.152ms] or [-0.025%; +0.025%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.417ms | 3.451ms ± 0.028ms | 3.445ms ± 0.011ms | 3.458ms | 3.503ms | 3.528ms | 3.694ms | 7.23% | 3.870 | 26.440 | 0.82% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.447ms; 3.455ms] or [-0.113%; +0.113%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 185.589µs | 186.092µs ± 0.380µs | 186.018µs ± 0.133µs | 186.175µs | 186.493µs | 187.949µs | 188.101µs | 1.12% | 3.344 | 13.441 | 0.20% | 0.027µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 5316280.831op/s | 5373706.676op/s ± 10911.664op/s | 5375812.647op/s ± 3854.324op/s | 5379489.533op/s | 5383049.058op/s | 5384591.232op/s | 5388250.381op/s | 0.23% | -3.318 | 13.273 | 0.20% | 771.571op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 17.821µs | 17.880µs ± 0.029µs | 17.877µs ± 0.022µs | 17.902µs | 17.928µs | 17.945µs | 17.972µs | 0.53% | 0.270 | -0.438 | 0.16% | 0.002µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 55641199.362op/s | 55929305.224op/s ± 90902.659op/s | 55936245.893op/s ± 69618.251op/s | 55998293.710op/s | 56069284.485op/s | 56090862.710op/s | 56113282.816op/s | 0.32% | -0.263 | -0.447 | 0.16% | 6427.789op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.541µs | 10.588µs ± 0.028µs | 10.586µs ± 0.016µs | 10.603µs | 10.625µs | 10.652µs | 10.827µs | 2.28% | 3.113 | 23.423 | 0.27% | 0.002µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 92360841.823op/s | 94444382.266op/s ± 251651.928op/s | 94462684.074op/s ± 146087.016op/s | 94596329.155op/s | 94776463.987op/s | 94829829.920op/s | 94865942.113op/s | 0.43% | -2.990 | 22.102 | 0.27% | 17794.478op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [186.039µs; 186.145µs] or [-0.028%; +0.028%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [5372194.424op/s; 5375218.928op/s] or [-0.028%; +0.028%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [17.876µs; 17.884µs] or [-0.023%; +0.023%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [55916706.990op/s; 55941903.458op/s] or [-0.023%; +0.023%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.584µs; 10.592µs] or [-0.037%; +0.037%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [94409505.729op/s; 94479258.803op/s] or [-0.037%; +0.037%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 286.097µs | 286.685µs ± 0.502µs | 286.574µs ± 0.191µs | 286.817µs | 287.264µs | 288.542µs | 290.472µs | 1.36% | 4.073 | 24.563 | 0.17% | 0.035µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [286.616µs; 286.755µs] or [-0.024%; +0.024%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 13.962ms | 14.005ms ± 0.028ms | 14.002ms ± 0.013ms | 14.014ms | 14.037ms | 14.110ms | 14.211ms | 1.49% | 3.149 | 16.830 | 0.20% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [14.001ms; 14.009ms] or [-0.028%; +0.028%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 34.463µs | 35.087µs ± 1.057µs | 34.606µs ± 0.080µs | 34.752µs | 37.329µs | 37.364µs | 38.837µs | 12.22% | 1.736 | 1.220 | 3.00% | 0.075µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [34.941µs; 35.234µs] or [-0.417%; +0.417%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.897µs | 3.915µs ± 0.006µs | 3.914µs ± 0.002µs | 3.916µs | 3.920µs | 3.924µs | 3.963µs | 1.25% | 5.484 | 44.534 | 0.14% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 252332444.933op/s | 255435871.473op/s ± 357750.761op/s | 255484680.398op/s ± 116601.408op/s | 255591802.524op/s | 255718849.450op/s | 255773095.559op/s | 256633895.771op/s | 0.45% | -5.415 | 43.852 | 0.14% | 25296.799op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 79.181µs | 79.842µs ± 0.139µs | 79.854µs ± 0.052µs | 79.899µs | 79.984µs | 80.056µs | 80.892µs | 1.30% | 0.664 | 20.055 | 0.17% | 0.010µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12362215.262op/s | 12524723.002op/s ± 21779.794op/s | 12522922.664op/s ± 8130.569op/s | 12531325.208op/s | 12549835.469op/s | 12608456.756op/s | 12629299.976op/s | 0.85% | -0.553 | 19.504 | 0.17% | 1540.064op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 67.840µs | 67.971µs ± 0.074µs | 67.966µs ± 0.035µs | 68.002µs | 68.069µs | 68.115µs | 68.618µs | 0.96% | 3.447 | 27.479 | 0.11% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 14573459.937op/s | 14712074.203op/s ± 15969.171op/s | 14713211.913op/s ± 7623.553op/s | 14720751.936op/s | 14732147.559op/s | 14740411.371op/s | 14740618.891op/s | 0.19% | -3.391 | 26.841 | 0.11% | 1129.191op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.893µs | 3.914µs ± 0.003µs | 3.914µs ± 0.001µs | 3.916µs | 3.918µs | 3.920µs | 3.922µs | 0.20% | -2.135 | 18.012 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254982920.136op/s | 255481206.815op/s ± 173840.838op/s | 255486101.556op/s ± 93579.462op/s | 255578174.977op/s | 255728137.649op/s | 255773960.521op/s | 256853747.677op/s | 0.54% | 2.166 | 18.295 | 0.07% | 12292.404op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 64.791µs | 64.925µs ± 0.048µs | 64.918µs ± 0.032µs | 64.955µs | 65.005µs | 65.056µs | 65.087µs | 0.26% | 0.481 | 0.462 | 0.07% | 0.003µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 15364121.248op/s | 15402304.996op/s ± 11489.986op/s | 15403979.295op/s ± 7657.357op/s | 15410595.814op/s | 15417186.354op/s | 15426085.987op/s | 15434323.865op/s | 0.20% | -0.476 | 0.456 | 0.07% | 812.465op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 45.439µs | 45.660µs ± 0.068µs | 45.666µs ± 0.046µs | 45.709µs | 45.763µs | 45.811µs | 45.821µs | 0.34% | -0.331 | 0.359 | 0.15% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 21823837.980op/s | 21901039.719op/s ± 32532.031op/s | 21898295.559op/s ± 21910.397op/s | 21922117.842op/s | 21951649.518op/s | 21987772.274op/s | 22007667.471op/s | 0.50% | 0.341 | 0.374 | 0.15% | 2300.362op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 6.814µs | 6.837µs ± 0.004µs | 6.837µs ± 0.002µs | 6.839µs | 6.843µs | 6.847µs | 6.849µs | 0.17% | -0.715 | 5.485 | 0.06% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 146007998.604op/s | 146264437.146op/s ± 84328.104op/s | 146261518.595op/s ± 48310.754op/s | 146312341.446op/s | 146384887.132op/s | 146425869.059op/s | 146762978.492op/s | 0.34% | 0.727 | 5.547 | 0.06% | 5962.897op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.893µs | 3.914µs ± 0.003µs | 3.914µs ± 0.001µs | 3.915µs | 3.917µs | 3.920µs | 3.922µs | 0.23% | -2.030 | 19.416 | 0.06% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 254945340.916op/s | 255510793.632op/s ± 166287.406op/s | 255521080.490op/s ± 88144.406op/s | 255592083.439op/s | 255706663.410op/s | 255753380.406op/s | 256839985.573op/s | 0.52% | 2.064 | 19.705 | 0.06% | 11758.295op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 65.469µs | 65.687µs ± 0.048µs | 65.686µs ± 0.027µs | 65.714µs | 65.763µs | 65.801µs | 65.860µs | 0.26% | -0.424 | 2.626 | 0.07% | 0.003µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15183834.555op/s | 15223767.171op/s ± 11201.000op/s | 15223934.373op/s ± 6241.546op/s | 15229374.160op/s | 15241268.762op/s | 15258616.815op/s | 15274299.464op/s | 0.33% | 0.434 | 2.644 | 0.07% | 792.030op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 53.343µs | 53.435µs ± 0.032µs | 53.434µs ± 0.023µs | 53.458µs | 53.488µs | 53.513µs | 53.544µs | 0.21% | 0.114 | 0.114 | 0.06% | 0.002µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 18676126.853op/s | 18714471.929op/s ± 11327.063op/s | 18714626.680op/s ± 8159.949op/s | 18722148.160op/s | 18732571.547op/s | 18737993.357op/s | 18746508.712op/s | 0.17% | -0.110 | 0.111 | 0.06% | 800.944op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.894µs | 3.915µs ± 0.003µs | 3.915µs ± 0.002µs | 3.916µs | 3.919µs | 3.921µs | 3.922µs | 0.18% | -1.803 | 14.869 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 254989224.311op/s | 255451382.398op/s ± 175103.270op/s | 255457914.310op/s ± 106218.276op/s | 255567709.021op/s | 255652500.798op/s | 255769122.037op/s | 256776240.603op/s | 0.52% | 1.831 | 15.109 | 0.07% | 12381.671op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 50.144µs | 50.207µs ± 0.037µs | 50.202µs ± 0.021µs | 50.222µs | 50.279µs | 50.309µs | 50.350µs | 0.30% | 1.062 | 1.342 | 0.07% | 0.003µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 19860799.628op/s | 19917382.641op/s ± 14476.160op/s | 19919494.368op/s ± 8296.287op/s | 19927741.511op/s | 19935560.494op/s | 19941374.155op/s | 19942613.136op/s | 0.12% | -1.057 | 1.327 | 0.07% | 1023.619op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 45.458µs | 45.661µs ± 0.070µs | 45.662µs ± 0.044µs | 45.708µs | 45.771µs | 45.806µs | 45.818µs | 0.34% | -0.231 | -0.152 | 0.15% | 0.005µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 21825697.795op/s | 21900585.477op/s ± 33547.143op/s | 21900202.972op/s ± 21208.751op/s | 21919525.204op/s | 21959825.827op/s | 21979761.745op/s | 21998519.500op/s | 0.45% | 0.239 | -0.146 | 0.15% | 2372.141op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 6.816µs | 6.836µs ± 0.005µs | 6.836µs ± 0.002µs | 6.839µs | 6.844µs | 6.847µs | 6.851µs | 0.22% | -0.352 | 2.542 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 145958398.963op/s | 146279446.449op/s ± 96800.997op/s | 146278643.318op/s ± 52586.652op/s | 146330627.001op/s | 146434823.274op/s | 146467649.521op/s | 146704596.607op/s | 0.29% | 0.360 | 2.563 | 0.07% | 6844.864op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.914µs; 3.916µs] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255386290.658op/s; 255485452.288op/s] or [-0.019%; +0.019%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [79.823µs; 79.862µs] or [-0.024%; +0.024%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12521704.532op/s; 12527741.472op/s] or [-0.024%; +0.024%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [67.961µs; 67.982µs] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [14709861.030op/s; 14714287.377op/s] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.914µs; 3.915µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255457114.147op/s; 255505299.484op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [64.919µs; 64.932µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [15400712.594op/s; 15403897.397op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [45.651µs; 45.669µs] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [21896531.093op/s; 21905548.346op/s] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [6.836µs; 6.837µs] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [146252750.081op/s; 146276124.210op/s] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.913µs; 3.914µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255487747.797op/s; 255533839.467op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [65.680µs; 65.693µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15222214.820op/s; 15225319.522op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [53.430µs; 53.439µs] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [18712902.107op/s; 18716041.751op/s] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.914µs; 3.915µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255427114.768op/s; 255475650.027op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [50.202µs; 50.212µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [19915376.384op/s; 19919388.898op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [45.651µs; 45.671µs] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [21895936.165op/s; 21905234.788op/s] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [6.836µs; 6.837µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [146266030.761op/s; 146292862.136op/s] or [-0.009%; +0.009%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 190.032ns | 192.316ns ± 1.995ns | 192.134ns ± 1.311ns | 193.252ns | 195.968ns | 198.607ns | 200.173ns | 4.18% | 1.167 | 1.504 | 1.03% | 0.141ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [192.039ns; 192.592ns] or [-0.144%; +0.144%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 13.914µs | 14.093µs ± 0.093µs | 14.085µs ± 0.065µs | 14.155µs | 14.256µs | 14.342µs | 14.472µs | 2.75% | 0.697 | 0.748 | 0.66% | 0.007µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [14.080µs; 14.106µs] or [-0.092%; +0.092%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 243.139ns | 255.415ns ± 12.693ns | 250.554ns ± 4.643ns | 261.629ns | 284.155ns | 289.663ns | 290.581ns | 15.98% | 1.338 | 0.594 | 4.96% | 0.898ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [253.656ns; 257.175ns] or [-0.689%; +0.689%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 49.389ms | 49.643ms ± 1.084ms | 49.489ms ± 0.027ms | 49.517ms | 49.636ms | 57.578ms | 59.391ms | 20.01% | 7.866 | 61.453 | 2.18% | 0.077ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [49.493ms; 49.794ms] or [-0.303%; +0.303%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 495.281µs | 496.152µs ± 0.409µs | 496.098µs ± 0.275µs | 496.409µs | 496.788µs | 497.247µs | 497.906µs | 0.36% | 0.885 | 1.758 | 0.08% | 0.029µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 2008411.899op/s | 2015513.997op/s ± 1660.597op/s | 2015728.957op/s ± 1115.562op/s | 2016712.609op/s | 2017686.208op/s | 2018547.435op/s | 2019057.434op/s | 0.17% | -0.878 | 1.732 | 0.08% | 117.422op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 370.913µs | 371.708µs ± 0.380µs | 371.691µs ± 0.205µs | 371.888µs | 372.209µs | 372.657µs | 374.655µs | 0.80% | 2.462 | 16.962 | 0.10% | 0.027µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2669120.401op/s | 2690286.259op/s ± 2741.491op/s | 2690405.872op/s ± 1484.288op/s | 2691929.528op/s | 2694217.059op/s | 2695245.715op/s | 2696050.333op/s | 0.21% | -2.423 | 16.591 | 0.10% | 193.853op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 168.463µs | 169.247µs ± 0.260µs | 169.252µs ± 0.168µs | 169.406µs | 169.693µs | 169.871µs | 169.888µs | 0.38% | 0.047 | -0.093 | 0.15% | 0.018µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5886231.734op/s | 5908527.960op/s ± 9066.484op/s | 5908335.883op/s ± 5849.593op/s | 5914322.850op/s | 5922620.972op/s | 5928458.150op/s | 5936030.574op/s | 0.47% | -0.038 | -0.091 | 0.15% | 641.097op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 36.835µs | 37.023µs ± 0.109µs | 37.039µs ± 0.094µs | 37.105µs | 37.191µs | 37.229µs | 37.292µs | 0.68% | 0.069 | -1.141 | 0.29% | 0.008µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26815213.314op/s | 27010491.106op/s ± 79607.675op/s | 26998684.751op/s ± 68684.689op/s | 27084993.091op/s | 27123724.741op/s | 27140314.319op/s | 27148344.406op/s | 0.55% | -0.062 | -1.146 | 0.29% | 5629.113op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 46.278µs | 46.411µs ± 0.058µs | 46.403µs ± 0.034µs | 46.444µs | 46.509µs | 46.580µs | 46.692µs | 0.62% | 1.019 | 2.553 | 0.12% | 0.004µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 21417048.662op/s | 21546806.851op/s ± 26694.711op/s | 21550528.056op/s ± 15947.069op/s | 21564141.060op/s | 21585320.396op/s | 21592838.553op/s | 21608750.568op/s | 0.27% | -1.006 | 2.497 | 0.12% | 1887.601op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [496.095µs; 496.208µs] or [-0.011%; +0.011%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2015283.854op/s; 2015744.140op/s] or [-0.011%; +0.011%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [371.655µs; 371.761µs] or [-0.014%; +0.014%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2689906.314op/s; 2690666.203op/s] or [-0.014%; +0.014%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [169.211µs; 169.283µs] or [-0.021%; +0.021%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5907271.432op/s; 5909784.487op/s] or [-0.021%; +0.021%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [37.008µs; 37.038µs] or [-0.041%; +0.041%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [26999458.248op/s; 27021523.965op/s] or [-0.041%; +0.041%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [46.403µs; 46.419µs] or [-0.017%; +0.017%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21543107.221op/s; 21550506.481op/s] or [-0.017%; +0.017%] | None | None | None |
Group 20
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 144.628µs | 146.265µs ± 1.627µs | 145.987µs ± 0.489µs | 146.560µs | 147.942µs | 152.396µs | 162.674µs | 11.43% | 6.093 | 53.105 | 1.11% | 0.115µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [146.040µs; 146.491µs] or [-0.154%; +0.154%] | None | None | None |
Group 21
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d8a06b8 | 1774539647 | gyuheon0h/fix-sigchld-deadlock |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 5.375µs | 5.503µs ± 0.025µs | 5.501µs ± 0.016µs | 5.518µs | 5.543µs | 5.562µs | 5.604µs | 1.86% | -0.041 | 3.495 | 0.46% | 0.002µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [5.499µs; 5.507µs] or [-0.064%; +0.064%] | None | None | None |
Baseline
Omitted due to size.
c06f2a2 to
88ec5ce
Compare
88ec5ce to
59f6100
Compare
ff0497b to
d8a06b8
Compare
r1viollet
left a comment
There was a problem hiding this comment.
LGTM
Thanks for looking into this

What does this PR do?
This PR fixes a regression where SaGuard suppressed
SIGCHLDwithSIG_IGN, which can alter child reaping behavior (waitpid/ECHILD) and breaksigchld_execcrash-test flowsChanges
SaGuardProcessHandle::finishMotivation
Context: We were originally not blocking any signals. In fix(crashtracking): guard sigchld and sigpipe during crashtracker signal handler execution, we started blocking sigchld and sigpipe. However, blocking sigchld causes deadlocks for the following test
test(crashtracking): skip sigchld_exec test on CentOS 7 deadlock
This change works because it prevents interference with the application's expected signal handling while still protecting the crash handler from re-entrant signals
Additional Notes
How to test the change?
cargo nextest run -p libdd-crashtracker --lib -- collector::saguard::single_threaded_testscargo nextest run -p bin_tests test_crash_tracking_bin_sigchld_exec