[WIP] chore(crashtracker): write bin_test for crashtracker sa_guard suppression of sigchld and sigpipe#1773
[WIP] chore(crashtracker): write bin_test for crashtracker sa_guard suppression of sigchld and sigpipe#1773
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
689af5e to
9b22092
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## gyuheon0h/PROF-14080-saguard-ct #1773 +/- ##
===================================================================
- Coverage 70.49% 70.42% -0.08%
===================================================================
Files 411 412 +1
Lines 62220 62314 +94
===================================================================
+ Hits 43861 43883 +22
- Misses 18359 18431 +72
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 177874b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-03-24 18:05:16 Comparing candidate commit 177874b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.419µs | 2.434µs ± 0.012µs | 2.430µs ± 0.005µs | 2.440µs | 2.460µs | 2.470µs | 2.474µs | 1.84% | 1.265 | 0.959 | 0.49% | 0.001µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.432µs; 2.436µs] or [-0.068%; +0.068%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.226ms | 4.230ms ± 0.003ms | 4.229ms ± 0.001ms | 4.231ms | 4.233ms | 4.237ms | 4.260ms | 0.74% | 5.892 | 56.225 | 0.07% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.229ms; 4.230ms] or [-0.010%; +0.010%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 13.045ms | 13.086ms ± 0.016ms | 13.085ms ± 0.010ms | 13.096ms | 13.113ms | 13.131ms | 13.135ms | 0.38% | 0.339 | 0.168 | 0.12% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [13.084ms; 13.089ms] or [-0.017%; +0.017%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 731.316µs | 732.874µs ± 0.569µs | 732.874µs ± 0.375µs | 733.237µs | 733.841µs | 734.437µs | 734.803µs | 0.26% | 0.411 | 0.445 | 0.08% | 0.040µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [732.795µs; 732.953µs] or [-0.011%; +0.011%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 4.939µs | 5.017µs ± 0.043µs | 5.007µs ± 0.027µs | 5.057µs | 5.095µs | 5.097µs | 5.099µs | 1.85% | 0.422 | -0.977 | 0.86% | 0.003µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.011µs; 5.023µs] or [-0.120%; +0.120%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 5.358µs | 5.452µs ± 0.023µs | 5.449µs ± 0.013µs | 5.464µs | 5.499µs | 5.511µs | 5.514µs | 1.20% | 0.396 | 1.096 | 0.43% | 0.002µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [5.449µs; 5.456µs] or [-0.059%; +0.059%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | 4.240ms | 4.244ms ± 0.008ms | 4.243ms ± 0.001ms | 4.245ms | 4.248ms | 4.254ms | 4.356ms | 2.67% | 11.866 | 152.866 | 0.20% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | [4.243ms; 4.246ms] or [-0.028%; +0.028%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 160.868µs | 161.602µs ± 0.313µs | 161.559µs ± 0.164µs | 161.752µs | 162.006µs | 162.321µs | 163.666µs | 1.30% | 2.873 | 16.568 | 0.19% | 0.022µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [161.559µs; 161.646µs] or [-0.027%; +0.027%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 33.272µs | 33.838µs ± 0.992µs | 33.386µs ± 0.038µs | 33.446µs | 35.948µs | 35.990µs | 37.420µs | 12.08% | 1.752 | 1.273 | 2.93% | 0.070µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [33.700µs; 33.975µs] or [-0.406%; +0.406%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 495.409µs | 496.245µs ± 0.576µs | 496.175µs ± 0.245µs | 496.428µs | 496.918µs | 498.069µs | 501.133µs | 1.00% | 4.025 | 27.772 | 0.12% | 0.041µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 1995477.361op/s | 2015135.874op/s ± 2326.524op/s | 2015419.866op/s ± 996.980op/s | 2016345.110op/s | 2017535.986op/s | 2018052.882op/s | 2018534.634op/s | 0.15% | -3.978 | 27.250 | 0.12% | 164.510op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 370.632µs | 371.573µs ± 0.349µs | 371.587µs ± 0.249µs | 371.803µs | 372.142µs | 372.366µs | 372.500µs | 0.25% | 0.050 | -0.298 | 0.09% | 0.025µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2684560.938op/s | 2691266.618op/s ± 2528.581op/s | 2691160.911op/s ± 1802.504op/s | 2693025.138op/s | 2695352.278op/s | 2696659.704op/s | 2698097.548op/s | 0.26% | -0.045 | -0.298 | 0.09% | 178.798op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 167.956µs | 168.295µs ± 0.161µs | 168.269µs ± 0.101µs | 168.386µs | 168.605µs | 168.743µs | 168.746µs | 0.28% | 0.609 | 0.150 | 0.10% | 0.011µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5926067.212op/s | 5941948.185op/s ± 5677.915op/s | 5942858.312op/s ± 3579.291op/s | 5946059.355op/s | 5949742.360op/s | 5953129.742op/s | 5953946.913op/s | 0.19% | -0.604 | 0.142 | 0.10% | 401.489op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 36.857µs | 37.046µs ± 0.113µs | 37.071µs ± 0.089µs | 37.136µs | 37.203µs | 37.257µs | 37.264µs | 0.52% | -0.132 | -1.226 | 0.30% | 0.008µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26835603.486op/s | 26994067.866op/s ± 82049.515op/s | 26975215.754op/s ± 64288.103op/s | 27074728.802op/s | 27120182.594op/s | 27126701.699op/s | 27131896.924op/s | 0.58% | 0.139 | -1.228 | 0.30% | 5801.777op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 46.296µs | 46.428µs ± 0.103µs | 46.419µs ± 0.037µs | 46.455µs | 46.532µs | 46.612µs | 47.645µs | 2.64% | 8.396 | 95.808 | 0.22% | 0.007µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 20988409.501op/s | 21538869.810op/s ± 46932.704op/s | 21542706.742op/s ± 17326.021op/s | 21561399.921op/s | 21574480.418op/s | 21585220.206op/s | 21600288.580op/s | 0.27% | -8.216 | 92.927 | 0.22% | 3318.643op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [496.165µs; 496.325µs] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2014813.440op/s; 2015458.308op/s] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [371.524µs; 371.621µs] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2690916.181op/s; 2691617.055op/s] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [168.273µs; 168.317µs] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5941161.281op/s; 5942735.089op/s] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [37.030µs; 37.061µs] or [-0.042%; +0.042%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [26982696.592op/s; 27005439.140op/s] or [-0.042%; +0.042%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [46.414µs; 46.442µs] or [-0.031%; +0.031%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21532365.389op/s; 21545374.231op/s] or [-0.030%; +0.030%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 13.968ms | 14.010ms ± 0.031ms | 14.006ms ± 0.013ms | 14.020ms | 14.044ms | 14.152ms | 14.199ms | 1.38% | 2.841 | 12.305 | 0.22% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [14.006ms; 14.014ms] or [-0.030%; +0.030%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 144.262µs | 146.051µs ± 1.621µs | 145.782µs ± 0.532µs | 146.395µs | 147.682µs | 151.536µs | 161.453µs | 10.75% | 5.482 | 43.436 | 1.11% | 0.115µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [145.826µs; 146.276µs] or [-0.154%; +0.154%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 13.605µs | 13.809µs ± 0.052µs | 13.817µs ± 0.032µs | 13.842µs | 13.878µs | 13.902µs | 13.909µs | 0.66% | -0.766 | 0.619 | 0.38% | 0.004µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [13.801µs; 13.816µs] or [-0.053%; +0.053%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 185.564µs | 186.024µs ± 0.218µs | 186.025µs ± 0.164µs | 186.184µs | 186.368µs | 186.513µs | 186.797µs | 0.41% | 0.321 | -0.243 | 0.12% | 0.015µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 5353412.914op/s | 5375649.886op/s ± 6298.963op/s | 5375622.280op/s ± 4740.395op/s | 5380688.233op/s | 5384863.787op/s | 5386651.431op/s | 5388974.858op/s | 0.25% | -0.316 | -0.254 | 0.12% | 445.404op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 17.798µs | 17.870µs ± 0.028µs | 17.871µs ± 0.020µs | 17.890µs | 17.915µs | 17.927µs | 17.954µs | 0.46% | -0.169 | -0.076 | 0.16% | 0.002µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 55699224.189op/s | 55959903.111op/s ± 88628.995op/s | 55958064.369op/s ± 62630.334op/s | 56020681.517op/s | 56118362.211op/s | 56166247.923op/s | 56187335.186op/s | 0.41% | 0.178 | -0.074 | 0.16% | 6267.016op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.533µs | 10.588µs ± 0.027µs | 10.585µs ± 0.016µs | 10.604µs | 10.630µs | 10.641µs | 10.768µs | 1.73% | 1.436 | 8.278 | 0.26% | 0.002µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 92865517.970op/s | 94447460.439op/s ± 242085.774op/s | 94468951.132op/s ± 144646.170op/s | 94591428.212op/s | 94846088.894op/s | 94910187.628op/s | 94935860.318op/s | 0.49% | -1.374 | 7.814 | 0.26% | 17118.049op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [185.994µs; 186.054µs] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [5374776.910op/s; 5376522.862op/s] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [17.866µs; 17.874µs] or [-0.022%; +0.022%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [55947619.985op/s; 55972186.238op/s] or [-0.022%; +0.022%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.584µs; 10.592µs] or [-0.036%; +0.036%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [94413909.679op/s; 94481011.199op/s] or [-0.036%; +0.036%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.430ms | 3.465ms ± 0.026ms | 3.458ms ± 0.009ms | 3.471ms | 3.525ms | 3.573ms | 3.582ms | 3.60% | 2.122 | 5.057 | 0.75% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.462ms; 3.469ms] or [-0.104%; +0.104%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 190.840ns | 193.053ns ± 1.756ns | 192.739ns ± 1.021ns | 193.793ns | 196.292ns | 198.960ns | 200.322ns | 3.93% | 1.260 | 2.250 | 0.91% | 0.124ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [192.809ns; 193.296ns] or [-0.126%; +0.126%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 244.270ns | 256.220ns ± 13.584ns | 250.449ns ± 3.864ns | 256.728ns | 284.729ns | 290.407ns | 290.749ns | 16.09% | 1.425 | 0.548 | 5.29% | 0.961ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [254.337ns; 258.102ns] or [-0.735%; +0.735%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.895µs | 3.913µs ± 0.003µs | 3.913µs ± 0.001µs | 3.914µs | 3.918µs | 3.919µs | 3.924µs | 0.29% | -0.743 | 11.480 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254836814.707op/s | 255567417.033op/s ± 174246.823op/s | 255586824.500op/s ± 78525.090op/s | 255664702.345op/s | 255756365.612op/s | 255823923.724op/s | 256769611.256op/s | 0.46% | 0.769 | 11.636 | 0.07% | 12321.111op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 80.234µs | 80.792µs ± 0.270µs | 80.753µs ± 0.184µs | 80.960µs | 81.289µs | 81.478µs | 81.574µs | 1.02% | 0.539 | -0.265 | 0.33% | 0.019µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12258740.086op/s | 12377649.811op/s ± 41340.721op/s | 12383468.690op/s ± 28255.719op/s | 12409038.137op/s | 12434799.346op/s | 12447395.178op/s | 12463570.441op/s | 0.65% | -0.524 | -0.286 | 0.33% | 2923.230op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 73.070µs | 73.629µs ± 0.312µs | 73.601µs ± 0.206µs | 73.805µs | 74.211µs | 74.368µs | 74.497µs | 1.22% | 0.524 | -0.237 | 0.42% | 0.022µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 13423400.402op/s | 13581843.187op/s ± 57442.956op/s | 13586825.604op/s ± 37992.178op/s | 13624866.475op/s | 13664670.584op/s | 13681981.686op/s | 13685490.522op/s | 0.73% | -0.505 | -0.263 | 0.42% | 4061.830op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.893µs | 3.914µs ± 0.003µs | 3.913µs ± 0.002µs | 3.916µs | 3.918µs | 3.919µs | 3.922µs | 0.21% | -1.504 | 11.749 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254987494.539op/s | 255517006.055op/s ± 186838.562op/s | 255534672.589op/s ± 119988.712op/s | 255634210.249op/s | 255737435.897op/s | 255859692.471op/s | 256857419.813op/s | 0.52% | 1.530 | 11.952 | 0.07% | 13211.481op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 70.077µs | 70.668µs ± 0.283µs | 70.636µs ± 0.163µs | 70.817µs | 71.195µs | 71.493µs | 71.837µs | 1.70% | 0.697 | 1.291 | 0.40% | 0.020µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 13920367.655op/s | 14150917.984op/s ± 56430.853op/s | 14157114.561op/s ± 32610.778op/s | 14184436.484op/s | 14233292.026op/s | 14265393.710op/s | 14270099.007op/s | 0.80% | -0.664 | 1.205 | 0.40% | 3990.264op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 53.071µs | 53.136µs ± 0.033µs | 53.136µs ± 0.024µs | 53.158µs | 53.193µs | 53.211µs | 53.218µs | 0.15% | 0.267 | -0.537 | 0.06% | 0.002µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 18790498.371op/s | 18819469.167op/s ± 11558.201op/s | 18819455.553op/s ± 8400.792op/s | 18828121.763op/s | 18836986.982op/s | 18840444.228op/s | 18842669.294op/s | 0.12% | -0.265 | -0.538 | 0.06% | 817.288op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 6.430µs | 6.439µs ± 0.005µs | 6.438µs ± 0.003µs | 6.441µs | 6.447µs | 6.452µs | 6.471µs | 0.51% | 1.935 | 8.677 | 0.08% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 154538926.694op/s | 155312062.724op/s ± 117487.596op/s | 155327966.802op/s ± 60791.257op/s | 155386729.104op/s | 155457524.332op/s | 155478502.546op/s | 155518378.908op/s | 0.12% | -1.920 | 8.550 | 0.08% | 8307.628op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.893µs | 3.912µs ± 0.003µs | 3.912µs ± 0.001µs | 3.914µs | 3.917µs | 3.918µs | 3.919µs | 0.17% | -1.573 | 12.637 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 255177753.210op/s | 255599448.472op/s ± 173674.059op/s | 255609578.127op/s ± 96060.202op/s | 255695052.304op/s | 255820312.310op/s | 255863901.910op/s | 256865320.901op/s | 0.49% | 1.598 | 12.840 | 0.07% | 12280.610op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 64.908µs | 65.184µs ± 0.130µs | 65.173µs ± 0.075µs | 65.247µs | 65.394µs | 65.561µs | 65.780µs | 0.93% | 1.269 | 3.495 | 0.20% | 0.009µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15202180.111op/s | 15341255.818op/s ± 30440.148op/s | 15343804.849op/s ± 17752.326op/s | 15361997.136op/s | 15381562.449op/s | 15393029.323op/s | 15406316.590op/s | 0.41% | -1.246 | 3.395 | 0.20% | 2152.444op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 58.185µs | 58.407µs ± 0.153µs | 58.384µs ± 0.088µs | 58.481µs | 58.657µs | 58.831µs | 59.497µs | 1.91% | 2.346 | 12.128 | 0.26% | 0.011µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 16807601.335op/s | 17121239.860op/s ± 44506.743op/s | 17128074.933op/s ± 25905.193op/s | 17152341.792op/s | 17172274.268op/s | 17180266.351op/s | 17186630.520op/s | 0.34% | -2.280 | 11.523 | 0.26% | 3147.102op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.895µs | 3.913µs ± 0.002µs | 3.913µs ± 0.001µs | 3.915µs | 3.917µs | 3.918µs | 3.919µs | 0.15% | -2.007 | 15.673 | 0.06% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 255168535.523op/s | 255543833.463op/s ± 159828.315op/s | 255540203.592op/s ± 92300.081op/s | 255640838.624op/s | 255751413.789op/s | 255816022.569op/s | 256770978.370op/s | 0.48% | 2.032 | 15.904 | 0.06% | 11301.569op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 55.237µs | 55.575µs ± 0.167µs | 55.571µs ± 0.087µs | 55.653µs | 55.880µs | 56.005µs | 56.405µs | 1.50% | 0.880 | 2.711 | 0.30% | 0.012µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 17729002.886op/s | 17993834.230op/s ± 54039.842op/s | 17995077.030op/s ± 28212.393op/s | 18027610.133op/s | 18074597.655op/s | 18098760.742op/s | 18103828.960op/s | 0.60% | -0.845 | 2.570 | 0.30% | 3821.194op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 52.585µs | 52.828µs ± 0.077µs | 52.828µs ± 0.055µs | 52.881µs | 52.958µs | 52.997µs | 53.017µs | 0.36% | -0.020 | -0.338 | 0.15% | 0.005µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 18861953.553op/s | 18929544.247op/s ± 27538.173op/s | 18929457.078op/s ± 19818.618op/s | 18949289.946op/s | 18974476.815op/s | 18978970.517op/s | 19016764.838op/s | 0.46% | 0.027 | -0.335 | 0.15% | 1947.243op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 6.429µs | 6.441µs ± 0.006µs | 6.441µs ± 0.004µs | 6.444µs | 6.451µs | 6.456µs | 6.471µs | 0.47% | 0.961 | 1.977 | 0.09% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 154539603.336op/s | 155251858.854op/s ± 147631.430op/s | 155261774.557op/s ± 98015.660op/s | 155360524.577op/s | 155442267.764op/s | 155490178.677op/s | 155539593.189op/s | 0.18% | -0.953 | 1.937 | 0.09% | 10439.119op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.912µs; 3.913µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255543268.099op/s; 255591565.967op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [80.754µs; 80.829µs] or [-0.046%; +0.046%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12371920.385op/s; 12383379.238op/s] or [-0.046%; +0.046%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [73.586µs; 73.672µs] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [13573882.146op/s; 13589804.228op/s] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.913µs; 3.914µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255491112.027op/s; 255542900.083op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [70.629µs; 70.707µs] or [-0.055%; +0.055%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [14143097.211op/s; 14158738.757op/s] or [-0.055%; +0.055%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [53.132µs; 53.141µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [18817867.311op/s; 18821071.022op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [6.438µs; 6.439µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [155295780.073op/s; 155328345.375op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.912µs; 3.913µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255575378.918op/s; 255623518.026op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [65.166µs; 65.202µs] or [-0.028%; +0.028%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15337037.106op/s; 15345474.530op/s] or [-0.027%; +0.027%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [58.386µs; 58.429µs] or [-0.036%; +0.036%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [17115071.653op/s; 17127408.066op/s] or [-0.036%; +0.036%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.913µs; 3.914µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255521682.796op/s; 255565984.131op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [55.552µs; 55.598µs] or [-0.042%; +0.042%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [17986344.828op/s; 18001323.632op/s] or [-0.042%; +0.042%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [52.817µs; 52.838µs] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [18925727.721op/s; 18933360.773op/s] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [6.440µs; 6.442µs] or [-0.013%; +0.013%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [155231398.558op/s; 155272319.150op/s] or [-0.013%; +0.013%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 89.063µs | 89.323µs ± 0.262µs | 89.297µs ± 0.056µs | 89.359µs | 89.480µs | 89.650µs | 92.721µs | 3.84% | 11.057 | 140.757 | 0.29% | 0.019µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [89.287µs; 89.359µs] or [-0.041%; +0.041%] | None | None | None |
Group 20
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 177874b | 1774374409 | gyuheon0h/PROF-14080-saguard-bin-test |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 49.878ms | 50.159ms ± 0.782ms | 50.041ms ± 0.080ms | 50.117ms | 50.271ms | 53.218ms | 58.703ms | 17.31% | 8.412 | 79.495 | 1.55% | 0.055ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [50.051ms; 50.267ms] or [-0.216%; +0.216%] | None | None | None |
Baseline
Omitted due to size.
9b22092 to
713f398
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
fcdf081 to
7e7908c
Compare
713f398 to
177874b
Compare

What does this PR do?
Adds a bin_test to check that crashtracker
saguardcorrectly suppresses SIGCHLD and SIGPIPEThe test comment is pretty explanatory:
We cannot add determinism by explictly sending sigcld or sigpipe to the crashtracker process. Have no way of knowing if we are too early (when the crash handler has already started), or if we are too late (crash handler has already exited). This test at least will raise for sure if the crash handler ever fails to suppress SigChld or SigPipe.
Motivation
Good to have end to end tests
Additional Notes
Anything else we should know when reviewing?
How to test the change?
run the bin tests