Conversation
BenchmarksComparisonBenchmark execution time: 2025-12-19 00:23:17 Comparing candidate commit 8e585fe in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:single_flag_killswitch/rules-based
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 71.51% 71.47% -0.05%
==========================================
Files 411 412 +1
Lines 66083 66093 +10
==========================================
- Hits 47260 47239 -21
- Misses 18823 18854 +31
🚀 New features to boost your workflow:
|
danielsn
force-pushed
the
dsn/reqwest
branch
2 times, most recently
from
cda0942 to
a57bc38
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
from
a57bc38 to
1c7d697
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
2 times, most recently
from
40c9600 to
96f8a4e
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
from
96f8a4e to
0de659d
Compare
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 8e585fe | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
danielsn
force-pushed
the
dsn/reqwest
branch
from
0de659d to
7212159
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
2 times, most recently
from
69928f9 to
8d5d510
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
from
8d5d510 to
671cbf9
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
2 times, most recently
from
d7b6fd3 to
ce0b11d
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
from
ce0b11d to
a21802f
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
from
a21802f to
0506672
Compare
danielsn
force-pushed
the
dsn/reqwest
branch
from
0506672 to
2ed49d7
Compare
| parking_lot = { version = "0.12", default-features = false } | ||
| prost = "0.13.5" | ||
| rand = "0.8" | ||
| reqwest = { git = "https://github.com/seanmonstar/reqwest", branch = "windows-named-pipes" , features = ["multipart", "rustls-tls"], default-features = false } |
Member
There was a problem hiding this comment.
Should def wait before merging until this branch got merged and released by upstream
Comment on lines
+82
to
+88
| // File dump endpoint (debugging) - uses platform-specific local transport | ||
| Some("file") => { | ||
| let output_path = libdd_common::decode_uri_path_in_authority(&endpoint.url) | ||
| .context("Failed to decode file path from URI")?; | ||
| builder = spawn_dump_server_with_builder(builder, output_path)?; | ||
| "http://localhost/v1/input".to_string() | ||
| } |
Member
There was a problem hiding this comment.
Should we maybe "guard" this behind a feature flag? I like the idea of being able to dump HTTP request header and body to a file, but I am not sure we should have this in release builds. On the other hand, I have no hard feelings against and it seems cool to be able to debug this...
I am unsure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked draft because we want Reqwest to merge named pipe support before we merge this
What does this PR do?
Motivation
The hyper code has to handle a lot of lower level issues and is therefore more complex.
This also simplifies the API: Instead of creating and then uploading a reqwest, there is a single
sendfunctionAdditional Notes
The API changes are as follows:
buildandsendsteps, avoiding creating unnecessary objectsOtherwise, the API should not substantially change