Skip to content

[crashtracker] Make sure bin_tests contribute to code coverage #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gleocadie wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[crashtracker] Make sure bin_tests contribute to code coverage #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bin_tests/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ pub struct ArtifactsBuild {
fn inner_build_artifact(c: &ArtifactsBuild) -> anyhow::Result<PathBuf> {
let mut build_cmd = process::Command::new(env!("CARGO"));
build_cmd.arg("build");
if let Ok(_path) = std::env::var("LLVM_PROFILE_FILE") {
// LLVM_PROFILE_FILE is set, running llvm-cov
// Add the instrument-coverage flag to the RUSTFLAGS environment variable
build_cmd.env("RUSTFLAGS", "-C instrument-coverage --cfg=coverage");
}
if let BuildProfile::Release = c.build_profile {
build_cmd.arg("--release");
}
Expand Down
3 changes: 3 additions & 0 deletions bin_tests/src/test_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ where
let fixtures = TestFixtures::new()?;

let mut cmd = process::Command::new(&artifacts_map[&artifacts.crashtracker_bin]);
if let Ok(path) = std::env::var("LLVM_PROFILE_FILE") {
cmd.env("LLVM_PROFILE_FILE", path);
}
cmd.arg(format!("file://{}", fixtures.crash_profile_path.display()))
.arg(&artifacts_map[&artifacts.crashtracker_receiver])
.arg(&fixtures.output_dir)
Expand Down
Loading