Increase message buffer size as a default and make it customizable#23029
Increase message buffer size as a default and make it customizable#23029
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cda4112aa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| no_msg_error = pymqi.MQMIError(pymqi.CMQC.MQCC_FAILED, pymqi.CMQC.MQRC_NO_MSG_AVAILABLE) | ||
|
|
||
| mock_sub = MagicMock() | ||
| mock_sub.get.side_effect = [truncation_error, no_msg_error] |
There was a problem hiding this comment.
Prevent mock side_effect exhaustion in truncated-message test
This test configures mock_sub.get.side_effect with only two exceptions, but get_latest_messages() loops until 20 seconds elapse. Because the mocked calls return immediately, the loop performs a third get() call, exhausts the iterable side effect, and raises StopIteration, making the unit test fail nondeterministically instead of validating truncated-message handling.
Useful? React with 👍 / 👎.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: c88849a | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
Review from OliviaShoup is dismissed. Related teams and files:
- documentation
- ibm_ace/assets/configuration/spec.yaml
What does this PR do?
The default buffer size for messages in IBM MQ is 4Kb. This PR increases it to 64Kb and make it configurable.