Added metric mapping for Traefik v3 metric change#23025
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86bd7786d6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 'traefik_tls_certs_not_after': 'tls.certs.not_after', | ||
| # https://doc.traefik.io/traefik/v3.3/observability/metrics/overview/ | ||
| # In Traefik v3, open_connections is a single metric with entrypoint/router/service labels | ||
| 'traefik_open_connections': 'open_connections', |
There was a problem hiding this comment.
On a Traefik v3 deployment this maps the renamed source metric to a brand-new traefik_mesh.open_connections series, but the shipped overview dashboard still queries only traefik_mesh.entrypoint.open_connections and traefik_mesh.router.open_connections (traefik_mesh/assets/dashboards/traefik_mesh_overview.json:430 and :797). That leaves the bundled open-connections widgets blank for every v3 user even though this change advertises support for the renamed metric. Either continue emitting the legacy metric names based on the label that is present, or update the dashboard/assets in the same change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I'll address this in a seperate PR that just handles the dashboard
steveny91
changed the title
3 participants
What does this PR do?
Update a metric that was changed in Traefik v3