Expose --recreate flag to ddev env test#22521
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 029e8408aa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| test, | ||
| target_spec=f'{intg_name}:{env_name}', | ||
| pytest_args=pytest_args, | ||
| recreate=recreate, |
There was a problem hiding this comment.
The new --recreate flag here only flows into ddev test, which (per ddev/src/ddev/cli/test/__init__.py) just removes Hatch test environments; it never recreates the E2E environment that ddev env test is managing. Because start is still invoked with ignore_state=env_active, a running env is left untouched and stop is skipped afterward, so --recreate is effectively a no-op for the E2E environment when it’s already active. Users expecting a fresh E2E env (per the flag help text) will still test against stale containers.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
* Expose --recreate flag to `ddev env test` * Add changelog and ingore-state handling * Add AGENTS.md instructions for recreating testing environments * Prefer `--recreate` in AGENT.md docs fbfc31d
* Expose --recreate flag to `ddev env test` * Add changelog and ingore-state handling * Add AGENTS.md instructions for recreating testing environments * Prefer `--recreate` in AGENT.md docs Signed-off-by: lukepatrick <lukephilips@gmail.com>
3 participants
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged