Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24e749a53f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: password | ||
| description: | | ||
| The password of `username`. | ||
| fleet_configurable: true |
There was a problem hiding this comment.
Adding fleet_configurable: true to the password option without also setting secret: true exposes credentials as regular config data for any integration that consumes this template (including newly onboarded Windows checks like exchange_server in this commit). The same pattern also appears in instances/pdh_legacy.yaml, so passwords can be rendered/stored as plain text instead of handled as secrets.
Useful? React with 👍 / 👎.
| fleet_configurable: true | ||
| value: | ||
| type: string | ||
| - name: password |
There was a problem hiding this comment.
The password is missing here too - will fix in a separate PR.
coignetp
added
changelog/no-changelog
qa/skip-qa
* Add esxi * Add argo_workflows * Add kube_dns * Add proxysql * Add pulsar * Add nfsstat * Add yarn * Add infiniband * Add hdfs_namenode * Add couch * Add cassandra_nodetool * Add activemq_xml * Add supabase * Add harbor * Add amazon_msk * Add proxmox * Add openldap * Add sonarqube * Add ibm_ace * Add slurm * Add sidekiq * Add zeek * Add kubernetes_state_core * Add hive * Add kubernetes_cluster_autoscaler * Add mesos_slave * Add sonatype_nexus * Add gearmand * Add weaviate * Add tenable * Add mesos_master * Add hivemq * Add zscaler_private_access * Add exchange_server * Add kuma * Add rethinkdb * Add hudi * Add lighttpd * Add eset_protect * Add kafka_consumer * Add mcache * Add fly_io * Add guarddog Signed-off-by: lukepatrick <lukephilips@gmail.com>
2 participants
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged