Skip to content

update confluent kafka to 2.13.0#22509

Merged
steveny91 merged 2 commits intopiotr.wolski/update-confluent-kafkafrom
alopez/patch-librdkafka-getentropy
Feb 11, 2026
Merged

update confluent kafka to 2.13.0#22509
steveny91 merged 2 commits intopiotr.wolski/update-confluent-kafkafrom
alopez/patch-librdkafka-getentropy

Conversation

@alopezz
Copy link
Copy Markdown
Contributor

@alopezz alopezz commented Feb 3, 2026

What does this PR do?

This PR applies a patch to librdkafka to let us build it in our runners, such that we don't sacrifice glibc compatibility in the Agent (glibc 2.17 for linux amd64, glibc 2.23 for linux arm64).

This change in librdkafka adds usage of the getentropy function, declared in the <sys/random.h> header. This function was introduced with glibc 2.25, which is above our compatibility threshold. This header is not in our builders, causing the build to fail.

However, the usage of getentropy on that change is gated by a configure-time check that sets the HAVE_GETENTROPY preprocessor variable. Therefore, we can simply skip the offending includes based on this variable for no apparent harm. I will try to upstream this patch, as it seems to be generally correct.

Post merge note: I realized this had already been reported upstream: confluentinc/librdkafka#5283

Motivation

Making it possible to support the confluent-kafka update to 2.13.0 as #22446 intended.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-datadog-prod-us1

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (piotr.wolski/update-confluent-kafka@ef93a9d). Learn more about missing BASE report.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alopezz alopezz force-pushed the alopez/patch-librdkafka-getentropy branch from 778328a to c9939f8 Compare February 3, 2026 13:26
@alopezz alopezz force-pushed the alopez/patch-librdkafka-getentropy branch 2 times, most recently from 56cffe7 to 45487a6 Compare February 3, 2026 14:27
@alopezz alopezz marked this pull request as ready for review February 9, 2026 15:25
@alopezz alopezz requested review from a team as code owners February 9, 2026 15:25
steveny91
steveny91 previously approved these changes Feb 9, 2026
@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed steveny91’s stale review February 9, 2026 15:27

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • .builders/images/windows-x86_64/build_script.ps1
    • agent_requirements.in
    • kafka_actions/pyproject.toml
    • kafka_consumer/pyproject.toml
@steveny91 steveny91 changed the base branch from master to piotr.wolski/update-confluent-kafka February 9, 2026 15:31
@rdesgroppes
Copy link
Copy Markdown
Contributor

I will try to upstream this patch

❤️

@steveny91 steveny91 merged commit 4a3bbfa into piotr.wolski/update-confluent-kafka Feb 11, 2026
75 of 83 checks passed
@steveny91 steveny91 deleted the alopez/patch-librdkafka-getentropy branch February 11, 2026 15:32
steveny91 added a commit that referenced this pull request Feb 13, 2026
* update confluent kafka to 2.13.0

* move changelog

* Patch librdkafka to avoid build error due to missing header (#22509)

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>

* changelogs

* remove stale changelogs

---------

Co-authored-by: Piotr Wolski <piotr.wolski42@gmail.com>
Co-authored-by: Alex Lopez <alex.lopez.zorzano@gmail.com>
lukepatrick pushed a commit to lukepatrick/integrations-core that referenced this pull request Mar 17, 2026
* update confluent kafka to 2.13.0

* move changelog

* Patch librdkafka to avoid build error due to missing header (DataDog#22509)

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>

* changelogs

* remove stale changelogs

---------

Co-authored-by: Piotr Wolski <piotr.wolski42@gmail.com>
Co-authored-by: Alex Lopez <alex.lopez.zorzano@gmail.com>
Signed-off-by: lukepatrick <lukephilips@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants