refactor connect logs and traces - Node.js #16309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use [BigInt()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt) to convert hex strings to 64bit unsigned int strings.
apigirl
added
the
under_review
Contributor
|
hi @naseemkullah, thanks for the PR! We're working on getting it validated and should get back to you soon |
kayayarai
approved these changes
Feb 16, 2023
Collaborator
|
Thank you so. much for the docs improvement @naseemkullah , and for your patience! |
Contributor
Author
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use BigInt() to convert hex strings to 64bit unsigned int strings.
Motivation
The amount of custom logic currently documented was quite large, perhaps BigInt() was not available at the time.
Additional Notes
There is an example where this code is duplicated here
The PR to change it is DataDog/trace-examples#124
Reviewer checklist