ci: prepare for PHP 8.4.22/8.5.7 rebuilds#3969
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a298b9a8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --XFAIL-- | ||
| PHP 8.5 Bookworm image needs to be rebuilt with ASAN preserve_none enabled |
There was a problem hiding this comment.
Constrain XFAIL to the PHP 8.5 ASAN image
This unconditional --XFAIL-- applies to every make test_opcache run, including the non-ASAN opcache jobs and all PHP 8.x versions generated in .gitlab/generate-tracer.php, even though the reason is specifically the current PHP 8.5 Bookworm ASAN image. In those other contexts, a real regression in this crash test will be reported as an expected failure instead of failing CI, so the temporary waiver should be made conditional in SKIPIF or otherwise limited to the affected PHP 8.5 ASAN environment.
Useful? React with 👍 / 👎.
Description
This marks a test on master that's failing as XFAIL, as it will go away at the next container rebuild.
This begins preparing for that rebuild, by bumping 8.4.22 and 8.5.7 SHA hashes, and removing the now-bad patch.
Reviewer checklist