Skip to content

ci: prepare for PHP 8.4.22/8.5.7 rebuilds#3969

Open
morrisonlevi wants to merge 3 commits into
masterfrom
levi/prepare-ci-rebuilds
Open

ci: prepare for PHP 8.4.22/8.5.7 rebuilds#3969
morrisonlevi wants to merge 3 commits into
masterfrom
levi/prepare-ci-rebuilds

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Description

This marks a test on master that's failing as XFAIL, as it will go away at the next container rebuild.

This begins preparing for that rebuild, by bumping 8.4.22 and 8.5.7 SHA hashes, and removing the now-bad patch.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 9, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.5]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [7.0]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.3]   View in Datadog   GitLab

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 54.12% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5a298b9 | Docs | Datadog PR Page | Give us feedback!

@morrisonlevi morrisonlevi marked this pull request as ready for review June 9, 2026 15:54
@morrisonlevi morrisonlevi requested a review from a team as a code owner June 9, 2026 15:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a298b9a8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +15 to +16
--XFAIL--
PHP 8.5 Bookworm image needs to be rebuilt with ASAN preserve_none enabled

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Constrain XFAIL to the PHP 8.5 ASAN image

This unconditional --XFAIL-- applies to every make test_opcache run, including the non-ASAN opcache jobs and all PHP 8.x versions generated in .gitlab/generate-tracer.php, even though the reason is specifically the current PHP 8.5 Bookworm ASAN image. In those other contexts, a real regression in this crash test will be reported as an expected failure instead of failing CI, so the temporary waiver should be made conditional in SKIPIF or otherwise limited to the affected PHP 8.5 ASAN environment.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant