Skip to content

chore: bump libdatadog#3968

Open
Leiyks wants to merge 2 commits into
masterfrom
leiyks/bump-libdatadog
Open

chore: bump libdatadog#3968
Leiyks wants to merge 2 commits into
masterfrom
leiyks/bump-libdatadog

Conversation

@Leiyks

@Leiyks Leiyks commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@Leiyks Leiyks requested review from a team as code owners June 9, 2026 14:09
@Leiyks Leiyks requested review from leoromanovsky and typotter and removed request for a team June 9, 2026 14:09
@datadog-official

datadog-official Bot commented Jun 9, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 11 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN Opcache tests: [8.5]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.3]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.4]   View in Datadog   GitLab

View all 11 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 54.12% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 522d1e4 | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e2a163344

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libdatadog
@@ -1 +1 @@
Subproject commit 93e97238020b5cf1165b2583ec555d58307af3c1
Subproject commit 382a08732c4f0061c55f890830b5206afc3e929f

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the renamed remote-config dependency

This submodule bump points at a libdatadog revision where datadog-remote-config has been renamed to libdd-remote-config, but the PHP Rust workspace still has components-rs/Cargo.toml:19 depending on ../libdatadog/datadog-remote-config and the root Cargo.lock still references the old package name. With this gitlink checked out, any cargo metadata/Rust build of components-rs fails before compiling because that path no longer exists, so the bump needs to update the local dependency name/path and lockfile together.

Useful? React with 👍 / 👎.

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/bump-libdatadog branch from 6e2a163 to 7a42df1 Compare June 9, 2026 14:48
@Leiyks Leiyks requested review from a team as code owners June 9, 2026 14:48

@typotter typotter left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade lgtm, in theory. pending Green CI

The libdatadog bump renamed the datadog-remote-config crate to
libdd-remote-config. Cargo.toml and cbindgen.toml were updated but the
use statements in components-rs/remote_config.rs still referenced the
old crate name, breaking the Rust build.

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks requested a review from typotter June 9, 2026 16:08
@pr-commenter

pr-commenter Bot commented Jun 9, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-06-09 17:11:30

Comparing candidate commit 522d1e4 in PR branch leiyks/bump-libdatadog with baseline commit 0f53344 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟩 execution_time [-123.811ns; -38.789ns] or [-7.597%; -2.380%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-151.937ns; -60.863ns] or [-8.809%; -3.529%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants