chore: bump libdatadog#3968
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e2a163344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 93e97238020b5cf1165b2583ec555d58307af3c1 | |||
| Subproject commit 382a08732c4f0061c55f890830b5206afc3e929f | |||
There was a problem hiding this comment.
Update the renamed remote-config dependency
This submodule bump points at a libdatadog revision where datadog-remote-config has been renamed to libdd-remote-config, but the PHP Rust workspace still has components-rs/Cargo.toml:19 depending on ../libdatadog/datadog-remote-config and the root Cargo.lock still references the old package name. With this gitlink checked out, any cargo metadata/Rust build of components-rs fails before compiling because that path no longer exists, so the bump needs to update the local dependency name/path and lockfile together.
Useful? React with 👍 / 👎.
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
6e2a163 to
7a42df1
Compare
typotter
left a comment
There was a problem hiding this comment.
upgrade lgtm, in theory. pending Green CI
The libdatadog bump renamed the datadog-remote-config crate to libdd-remote-config. Cargo.toml and cbindgen.toml were updated but the use statements in components-rs/remote_config.rs still referenced the old crate name, breaking the Rust build. Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Benchmarks [ tracer ]Benchmark execution time: 2026-06-09 17:11:30 Comparing candidate commit 522d1e4 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.
|
Description
Reviewer checklist