fix(ci): silence sidecar flush-timeout log noise in client_side_stats test#3949
Draft
Leiyks wants to merge 1 commit into
Draft
fix(ci): silence sidecar flush-timeout log noise in client_side_stats test#3949Leiyks wants to merge 1 commit into
Leiyks wants to merge 1 commit into
Conversation
|
Leiyks
force-pushed
the
leiyks/fix-ci-crashtracker-threads
branch
from
d340f37 to
6da4162
Compare
Leiyks
changed the title
…est_extension_ci] Default-config .phpt tests fall back to the ddtrace default agent localhost:8126, which has no listener in the CI container. Their sidecar trace sends get ECONNREFUSED and retry (max_retries=5, exponential backoff, ~21s). Because the sidecar trace flusher is shared across sessions, those doomed sends stall the synchronous flush of unrelated tests (e.g. client_side_stats) past the 10s IPC read timeout -> flaky 'Failed synchronously flushing traces: Kind(TimedOut)'. Point default traffic at the already-provisioned test-agent (9126) so those sends succeed fast. Uses DD_AGENT_HOST/DD_TRACE_AGENT_PORT (not DD_TRACE_AGENT_URL) so per-test --ENV-- DD_AGENT_HOST=request-replayer still takes precedence.
Leiyks
force-pushed
the
leiyks/fix-ci-crashtracker-threads
branch
from
bc04aed to
7b1e0a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under concurrent CI load,
tests/ext/request-replayer/client_side_stats.phptintermittently failed on a stray[ddtrace] [error] Failed synchronously flushing traces: Kind(TimedOut)line from the best-effort 5s synchronous flush — the stats themselves still arrive via the polled async sidecar path. AddDD_TRACE_LOG_LEVEL=off, matching its sibling testsclient_side_stats_peer_tags/client_side_stats_trace_filters. Verified 60/60 under load in docker.Note: the crashtracker thread-format fix originally here is now redundant — landed on master via #3953 — so this branch was rebased to contain only the client_side_stats fix.