Skip to content

libdatadog update to 42d9ab04#3927

Open
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest
Open

libdatadog update to 42d9ab04#3927
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented May 28, 2026

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous cea1e44edddd9124f75d5095f31026904a1f58d8
New 42d9ab0438338516d2e8ef962de4f8ed158c519d

Full CI result: ❌ 40 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116054833


libdatadog Integration Report

libdatadog SHA: 42d9ab0438338516d2e8ef962de4f8ed158c519d
Analysis date: 2026-05-29

Overall status

⚠️ Adapted (toolchain requirement bump fixed) — with a caveat: the build could not
proceed far enough in CI to expose any FFI-level API changes (see "Identified
libdatadog issues" → none, and the note under "Build & test summary").

Build & test summary

40 jobs failed across the package-trigger sub-pipeline (plus one cascade failure in
the tracer trigger). They fall into exactly three buckets:

Count Failure Classification
2 error: rustc 1.84.1 is not supported … requires rustc 1.87.0 (the compile tracing extension asan jobs) Fix — toolchain/MSRV bump
37 fatal: git fetch-pack: expected shallow list / The remote end hung up unexpectedly Ignore — transient git infra
1 aggregate tested versions (tracer-trigger, stage "aggregate versions") Ignore — cascade from the failures above

The substantive issue is a single one: libdatadog bumped its MSRV (minimum supported
Rust version) from 1.84 to 1.87.0
(changelog commit 276039da8 ci: bump msrv to 1.87.0 (#2017); libdatadog's rust-toolchain.toml channel and workspace
rust-version are both now 1.87.0). dd-trace-php pinned Rust 1.84.1, so cargo refuses
to build the workspace because every libdd-* crate now requires 1.87.0.

Only the two ASAN jobs got far enough to fetch crates and hit the MSRV gate; the other 37
compile jobs died earlier on an unrelated, transient git submodule-fetch error
(expected shallow list) and never reached compilation. The aggregate tested versions
job has no compilation step — it failed only because its downstream jobs failed.

Caveat: because the MSRV gate aborts the build before any Rust source is compiled, this
CI run could not surface FFI/API breakages. The changelog contains several breaking
changes (feat!/fix!) — e.g. #2029 (align tracer FFI error/response types), #2054
(flatten threads into a ThreadData list), #2022 (VecMap), #2011 (from_string on
span text), #1896 (v04→v1 encoder). None of these are observable here. After the
toolchain bump lands and CI is re-run, a follow-up pass may be needed to adapt call sites
if any of these touch the FFI surface dd-trace-php consumes.

Non-trivial changes made

Bumped the pinned Rust toolchain from 1.84.11.87.0 everywhere dd-trace-php pins it,
to satisfy the new libdatadog MSRV. (Per the task constraints, version requirements are
raised to match, never lowered to hide the incompatibility.)

  • Cargo.toml — workspace rust-version 1.84.1 → 1.87.0 (declared MSRV).
  • profiling/Cargo.toml — package rust-version 1.84.1 → 1.87.0.
  • profiling/rust-toolchain.toml — toolchain channel 1.84.1 → 1.87.0.
  • dockerfiles/ci/bookworm/DockerfileARG RUST_VERSION 1.84.1 → 1.87.0
    (installs via rustup --default-toolchain, no checksum to update).
  • dockerfiles/ci/buster/DockerfileARG RUST_VERSION 1.84.1 → 1.87.0 and the
    hardcoded tarball checksums, since this image downloads rust-<ver>-…tar.gz and verifies
    it with sha256sum:
    • RUST_SHA256_X861f6f18ce19387c42968a474cf175e67f99280614ded9c752d5d2e37af3204bcd
    • RUST_SHA256_ARM2c66e31d774a0dcd4422db74584ebc6362ff3ae90c452caff9d2fb912c821e8d
    • (both are the official published sums from
      https://static.rust-lang.org/dist/rust-1.87.0-<arch>-unknown-linux-gnu.tar.gz.sha256)
  • dockerfiles/ci/centos/7/base.Dockerfile — same ARG RUST_VERSION + the same two
    checksums (identical manual-tarball install logic as buster).
  • dockerfiles/ci/windows/basetools.Dockerfile — rustup --default-toolchain=1.84.1
    1.87.0 (no checksum).
  • appsec/tests/integration/src/docker/nginx-fpm-musl/Dockerfile — rustup
    --default-toolchain 1.84.11.87.0.
  • appsec/tests/integration/src/docker/php/Dockerfile-php-deps — rustup
    --default-toolchain 1.84.11.87.0.
  • appsec/tests/integration/build.gradle — hardcoded toolchain path
    …/toolchains/1.84.1-${RUST_TARGET}/…1.87.0-… (used to locate llvm-tools for
    coverage export).
  • README.md — documented minimum cargo version 1.84.1 → 1.87.0.

No Rust source (.rs) files were changed — the only adaptation required for the observed
failures was the toolchain version bump.

Note: the CI Docker images are pre-built and tagged out of band; these Dockerfile edits
only take effect once those base images are rebuilt and re-published. That rebuild is a
separate operational step outside this analysis.

Identified libdatadog issues

None identified. The MSRV bump is an intentional, documented change in libdatadog
(#2017), not a bug, and the correct response is to raise dd-trace-php's pinned toolchain
to match (done above).

Flaky / ignored failures

  • 37 × git fetch-pack: expected shallow list / The remote end hung up unexpectedly
    (most compile tracing extension and compile profiler extension jobs). This happens in
    the pre-build step (cd libdatadog; git fetch --depth=1 origin <SHA>), before any
    compilation. It is a transient git-server/infra issue (the shallow-fetch negotiation
    failed), unrelated to libdatadog's API. Not actionable from the source tree; expected to
    pass on re-run.
  • 1 × aggregate tested versions (tracer-trigger). A roll-up/trigger job with no build
    step; it failed only as a cascade of the downstream failures. Resolves once the real
    failures are fixed.

/cc @bwoebi

@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner May 28, 2026 02:23
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented May 28, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 238 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Extension Tea Tests: [8.3, nts]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation failed due to incompatible Rust version. Expected rustc 1.87.0 but found rustc 1.84.1.

DataDog/apm-reliability/dd-trace-php | compile tracing extension asan: [7.4, arm64, aarch64-unknown-linux-gnu]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error due to unsupported Rust version. Requires rustc 1.87.0 but found rustc 1.84.1.

DataDog/apm-reliability/dd-trace-php | clippy NTS: [8.3]   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. Permission denied while creating a temporary file in /rust/rustup/tmp/

View all 238 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 405c9b4 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 269af891ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdatadog Outdated
@@ -1 +1 @@
Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8
Subproject commit 8ac735802ccd4eca304019be37960183a19bdaeb
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update Rust toolchains with this submodule bump

In environments that use this repo's pinned Rust 1.84.1 (Cargo.toml, profiling/rust-toolchain.toml, and the CI Dockerfiles), this new libdatadog SHA cannot be compiled because libdatadog at 8ac735802ccd4eca304019be37960183a19bdaeb declares workspace.package.rust-version = "1.87.0". Since profiling/Cargo.toml depends on libdatadog path crates, Cargo rejects the dependency before building; the toolchain/manifests/images need to be bumped alongside this gitlink, or the previous SHA kept.

Useful? React with 👍 / 👎.

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 8ac73580 libdatadog update to f7d471dc May 28, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 269af89 to 578859b Compare May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot requested review from greghuels and leoromanovsky and removed request for a team May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to f7d471dc libdatadog update to 2a659a6e May 29, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 578859b to f75861e Compare May 29, 2026 03:04
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 2a659a6e libdatadog update to 42d9ab04 May 30, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from f75861e to 405c9b4 Compare May 30, 2026 02:23
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners May 30, 2026 02:23
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 30, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-05-30 02:40:12

Comparing candidate commit 405c9b4 in PR branch bot/libdatadog-latest with baseline commit 095538e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants