libdatadog update to e2680762#3895
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e412997b4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8 | |||
| Subproject commit 0f83957630ee6eb945f70f3036f0e937a862f99a | |||
There was a problem hiding this comment.
Revert submodule bump to failing libdatadog revision
This change advances libdatadog to 0f839576, but the commit metadata for this exact update reports a full CI failure (64 failed jobs in pipeline 114403599), which indicates the pinned revision is not currently integration-safe for dd-trace-php. Merging this pointer as-is will keep the main branch on a known-bad dependency state across the tested matrix; keep the previous SHA until the upstream breakage is fixed or a known-good follow-up SHA is identified.
Useful? React with 👍 / 👎.
56080c7 to
2f06e0d
Compare
be710ed to
fb95ca7
Compare
fb95ca7 to
d3b1ff4
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/115309415 Full CI result: ❌ 12 job(s) failed
d3b1ff4 to
4329aa2
Compare
|
This isn't going to be an automated update, we have to fix docker images first (which is in progress in #3926). |
Summary
Automated update of the libdatadog submodule to the latest HEAD.
cea1e44edddd9124f75d5095f31026904a1f58d8e2680762216c70b64e732cb55e450584c6732edfFull CI result: ❌ 12 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/115309415
libdatadog Integration Report
libdatadog SHA: e2680762216c70b64e732cb55e450584c6732edf
Analysis date: 2026-05-26
Overall status
❌ Blocking issues remain — libdatadog 34.0.0 bumps its MSRV from 1.84.1 → 1.87.0, but the dd-trace-php CI Docker images still ship rustc 1.84.1. No Rust source-level fix in dd-trace-php can unblock CI; the images themselves must be rebuilt. Nothing in
components-rswas changed.Build & test summary
12 failures, all from the same root cause:
compile tracing extension asan: [7.4/8.0/8.1/8.2/8.3/8.4/8.5, arm64](7 jobs)error: rustc 1.84.1 is not supported by the following packagescompile tracing extension asan: [8.2/8.3/8.4/8.5, amd64](4 jobs)aggregate tested versions(tracer pipeline)Every failing compile job emits the identical Cargo MSRV diagnostic listing ~30 libdatadog crates (
build_common@34.0.0,libdd-capabilities@2.0.0,libdd-common@4.1.0,libdd-common-ffi@34.0.0,libdd-crashtracker@1.0.0,libdd-data-pipeline@5.0.0,libdd-ddsketch@1.0.1,libdd-dogstatsd-client@3.0.0,libdd-shared-runtime@1.0.0,libdd-telemetry@5.0.0,libdd-telemetry-ffi@34.0.0,libdd-tinybytes@1.1.1,libdd-trace-normalization@2.0.0,libdd-trace-obfuscation@3.1.0,libdd-trace-protobuf@3.0.2,libdd-trace-stats@4.0.0,libdd-trace-utils@5.0.0, …) — each now declaringrust-version = "1.87.0". Cargo refuses to build before any Rust code is compiled, so no API-compatibility analysis is possible until the toolchain is bumped.Confirmation in the source tree:
libdatadog/Cargo.tomlworkspace package setsrust-version = "1.87.0".libdd-profiling,libdd-alloc,libdd-common) inherit it viarust-version.workspace = true.276039da8 ci: bump msrv to 1.87.0 (#2017).Non-trivial changes made
No code changes required (and none would help on their own).
I considered touching the source-level pins listed below, but chose not to, because:
./install.shwith a baked-inARG RUST_VERSION="1.84.1". Even after arustup-managed install on bookworm, the active default is still 1.84.1 because there is no root-levelrust-toolchain.tomlto override it;profiling/rust-toolchain.tomlonly applies inside the profiler subtree.Cargo.toml'srust-versionor the README copy without also rebuilding the images would change MSRV metadata while CI continues to fail in the same way — pure noise.ARG RUST_VERSIONvalues requires fresh SHA256 checksums for the 1.87.0 prebuilt tarballs (forRUST_SHA256_ARMandRUST_SHA256_X86indockerfiles/ci/centos/7/base.Dockerfile), and the resulting images must be rebuilt, retagged (e.g.bookworm-7), and the new tag referenced in.gitlab/generate-*.php. This is a coordinated infra change that I cannot perform or verify here.The files that will need updating once the CI images are rebuilt:
Cargo.toml— workspacerust-version = "1.84.1"→1.87.0profiling/Cargo.toml— sameprofiling/rust-toolchain.toml—channel = "1.84.1"→1.87.0README.mdline 26 — docs-only mention of 1.84.1dockerfiles/ci/centos/7/base.Dockerfileline 229 —ARG RUST_VERSION="1.84.1"+ new SHA256 values on lines 230–231dockerfiles/ci/buster/Dockerfileline 299dockerfiles/ci/bookworm/Dockerfileline 301dockerfiles/ci/windows/basetools.Dockerfileline 9appsec/tests/integration/src/docker/php/Dockerfile-php-depsline 25appsec/tests/integration/src/docker/nginx-fpm-musl/Dockerfileline 21appsec/tests/integration/build.gradleline 1111Identified libdatadog issues
None — the MSRV bump is an explicit intentional change in libdatadog (PR #2017, "ci: bump msrv to 1.87.0"). It is a normal versioning event, just one that the dd-trace-php CI environment is not yet prepared for. There is no API surface change required from us to call any libdatadog 34.0.0 type or function, because Cargo's MSRV gate trips before any of our Rust code is compiled — so we cannot yet observe whether subsequent commits in the changelog (e.g.
ecdca7d4e feat(trace-utils)!: add from_string to span text,e2fb8860d feat!: add encoder from v04 to v1,76474462f chore(sidecar): reorg/remove unsafe code in span FFI,8733ac262 fix(sidecar-ffi): revert ddog_free_charslice to Box::from_raw) require call-site updates incomponents-rs/. A second run will be needed against rustc 1.87.0 to surface any real API breakage.Flaky / ignored failures
None. All 12 failures are the same deterministic toolchain-version error; no flakes or unrelated failures were observed.
/cc @bwoebi