Skip to content

libdatadog update to e2680762#3895

Closed
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest
Closed

libdatadog update to e2680762#3895
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented May 21, 2026

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous cea1e44edddd9124f75d5095f31026904a1f58d8
New e2680762216c70b64e732cb55e450584c6732edf

Full CI result: ❌ 12 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/115309415


libdatadog Integration Report

libdatadog SHA: e2680762216c70b64e732cb55e450584c6732edf
Analysis date: 2026-05-26

Overall status

❌ Blocking issues remain — libdatadog 34.0.0 bumps its MSRV from 1.84.1 → 1.87.0, but the dd-trace-php CI Docker images still ship rustc 1.84.1. No Rust source-level fix in dd-trace-php can unblock CI; the images themselves must be rebuilt. Nothing in components-rs was changed.

Build & test summary

12 failures, all from the same root cause:

Job Failure
compile tracing extension asan: [7.4/8.0/8.1/8.2/8.3/8.4/8.5, arm64] (7 jobs) error: rustc 1.84.1 is not supported by the following packages
compile tracing extension asan: [8.2/8.3/8.4/8.5, amd64] (4 jobs) Same MSRV error
aggregate tested versions (tracer pipeline) Downstream collector — fails because the compile jobs above failed

Every failing compile job emits the identical Cargo MSRV diagnostic listing ~30 libdatadog crates (build_common@34.0.0, libdd-capabilities@2.0.0, libdd-common@4.1.0, libdd-common-ffi@34.0.0, libdd-crashtracker@1.0.0, libdd-data-pipeline@5.0.0, libdd-ddsketch@1.0.1, libdd-dogstatsd-client@3.0.0, libdd-shared-runtime@1.0.0, libdd-telemetry@5.0.0, libdd-telemetry-ffi@34.0.0, libdd-tinybytes@1.1.1, libdd-trace-normalization@2.0.0, libdd-trace-obfuscation@3.1.0, libdd-trace-protobuf@3.0.2, libdd-trace-stats@4.0.0, libdd-trace-utils@5.0.0, …) — each now declaring rust-version = "1.87.0". Cargo refuses to build before any Rust code is compiled, so no API-compatibility analysis is possible until the toolchain is bumped.

Confirmation in the source tree:

  • libdatadog/Cargo.toml workspace package sets rust-version = "1.87.0".
  • Individual libdatadog crates (e.g. libdd-profiling, libdd-alloc, libdd-common) inherit it via rust-version.workspace = true.
  • The libdatadog changelog calls this out explicitly: commit 276039da8 ci: bump msrv to 1.87.0 (#2017).

Non-trivial changes made

No code changes required (and none would help on their own).

I considered touching the source-level pins listed below, but chose not to, because:

  1. None of these pins drives the toolchain actually used by CI — the bookworm/centos/buster CI images install rustc directly via ./install.sh with a baked-in ARG RUST_VERSION="1.84.1". Even after a rustup-managed install on bookworm, the active default is still 1.84.1 because there is no root-level rust-toolchain.toml to override it; profiling/rust-toolchain.toml only applies inside the profiler subtree.
  2. Bumping Cargo.toml's rust-version or the README copy without also rebuilding the images would change MSRV metadata while CI continues to fail in the same way — pure noise.
  3. Updating the Dockerfile ARG RUST_VERSION values requires fresh SHA256 checksums for the 1.87.0 prebuilt tarballs (for RUST_SHA256_ARM and RUST_SHA256_X86 in dockerfiles/ci/centos/7/base.Dockerfile), and the resulting images must be rebuilt, retagged (e.g. bookworm-7), and the new tag referenced in .gitlab/generate-*.php. This is a coordinated infra change that I cannot perform or verify here.

The files that will need updating once the CI images are rebuilt:

  • Cargo.toml — workspace rust-version = "1.84.1"1.87.0
  • profiling/Cargo.toml — same
  • profiling/rust-toolchain.tomlchannel = "1.84.1"1.87.0
  • README.md line 26 — docs-only mention of 1.84.1
  • dockerfiles/ci/centos/7/base.Dockerfile line 229 — ARG RUST_VERSION="1.84.1" + new SHA256 values on lines 230–231
  • dockerfiles/ci/buster/Dockerfile line 299
  • dockerfiles/ci/bookworm/Dockerfile line 301
  • dockerfiles/ci/windows/basetools.Dockerfile line 9
  • appsec/tests/integration/src/docker/php/Dockerfile-php-deps line 25
  • appsec/tests/integration/src/docker/nginx-fpm-musl/Dockerfile line 21
  • appsec/tests/integration/build.gradle line 1111

Identified libdatadog issues

None — the MSRV bump is an explicit intentional change in libdatadog (PR #2017, "ci: bump msrv to 1.87.0"). It is a normal versioning event, just one that the dd-trace-php CI environment is not yet prepared for. There is no API surface change required from us to call any libdatadog 34.0.0 type or function, because Cargo's MSRV gate trips before any of our Rust code is compiled — so we cannot yet observe whether subsequent commits in the changelog (e.g. ecdca7d4e feat(trace-utils)!: add from_string to span text, e2fb8860d feat!: add encoder from v04 to v1, 76474462f chore(sidecar): reorg/remove unsafe code in span FFI, 8733ac262 fix(sidecar-ffi): revert ddog_free_charslice to Box::from_raw) require call-site updates in components-rs/. A second run will be needed against rustc 1.87.0 to surface any real API breakage.

Flaky / ignored failures

None. All 12 failures are the same deterministic toolchain-version error; no flakes or unrelated failures were observed.


/cc @bwoebi

@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner May 21, 2026 02:26
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 21, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 295 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Cargo test   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error: use of unstable library feature `unsigned_is_multiple_of` in libdatadog/libdd-profiling/src/internal/profile/interning_api/mod.rs:237:20.

DataDog/apm-reliability/dd-trace-php | Extension Tea Tests: [7.0, nts]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation failed due to unsupported rustc version 1.84.1. Required rustc version is 1.87.0.

DataDog/apm-reliability/dd-trace-php | ZAI Shared Tests: [7.4]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error in sql.rs:278: `std::string::String::as_bytes` is not yet stable as a const fn. Add `#![feature(const_vec_string_slice)]` to the crate attributes.

View all 295 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4329aa2 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e412997b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdatadog Outdated
@@ -1 +1 @@
Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8
Subproject commit 0f83957630ee6eb945f70f3036f0e937a862f99a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Revert submodule bump to failing libdatadog revision

This change advances libdatadog to 0f839576, but the commit metadata for this exact update reports a full CI failure (64 failed jobs in pipeline 114403599), which indicates the pinned revision is not currently integration-safe for dd-trace-php. Merging this pointer as-is will keep the main branch on a known-bad dependency state across the tested matrix; keep the previous SHA until the upstream breakage is fixed or a known-good follow-up SHA is identified.

Useful? React with 👍 / 👎.

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 0f839576 libdatadog update to 09d307dd May 22, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 2 times, most recently from 56080c7 to 2f06e0d Compare May 23, 2026 02:20
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 09d307dd libdatadog update to 118d2607 May 23, 2026
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 118d2607 libdatadog update to 276039da May 24, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 2 times, most recently from be710ed to fb95ca7 Compare May 25, 2026 03:18
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 276039da libdatadog update to 3bf778c3 May 26, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from fb95ca7 to d3b1ff4 Compare May 26, 2026 02:24
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 3bf778c3 libdatadog update to e2680762 May 27, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from d3b1ff4 to 4329aa2 Compare May 27, 2026 02:22
@morrisonlevi
Copy link
Copy Markdown
Collaborator

This isn't going to be an automated update, we have to fix docker images first (which is in progress in #3926).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant