Skip to content

Enable rust helper on PHP 8.5#3780

Merged
cataphract merged 3 commits intomasterfrom
glopes/helper-on-85
Apr 13, 2026
Merged

Enable rust helper on PHP 8.5#3780
cataphract merged 3 commits intomasterfrom
glopes/helper-on-85

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested review from a team as code owners April 9, 2026 14:12
@datadog-official

This comment has been minimized.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 9, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-04-10 15:34:04

Comparing candidate commit 59564e0 in PR branch glopes/helper-on-85 with baseline commit 14dabf8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 9, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-10 16:12:26

Comparing candidate commit 59564e0 in PR branch glopes/helper-on-85 with baseline commit 14dabf8 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟥 execution_time [+340.178ns; +1659.822ns] or [+2.167%; +10.572%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+4.911µs; +7.089µs] or [+4.945%; +7.136%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟥 execution_time [+1.836ms; +2.610ms] or [+7.286%; +10.356%]

@cataphract cataphract force-pushed the glopes/helper-on-85 branch 2 times, most recently from c56681e to 59564e0 Compare April 10, 2026 14:54
@cataphract cataphract enabled auto-merge April 10, 2026 14:54
cataphract and others added 3 commits April 13, 2026 10:04
PHP 8.5 now defaults to the Rust helper via DD_APPSEC_HELPER_RUST_REDIRECTION,
so the test tasks need to depend on buildHelperRust to ensure the volume is
populated before tests run in CI.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cataphract cataphract force-pushed the glopes/helper-on-85 branch from 59564e0 to 781d419 Compare April 13, 2026 09:04
@cataphract cataphract merged commit df43587 into master Apr 13, 2026
21 of 22 checks passed
@cataphract cataphract deleted the glopes/helper-on-85 branch April 13, 2026 09:04
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing area:asm labels Apr 13, 2026
@github-actions github-actions bot added this to the 1.18.0 milestone Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:asm profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants