Open
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3756 +/- ##
==========================================
- Coverage 68.85% 68.79% -0.07%
==========================================
Files 166 166
Lines 19015 19015
Branches 1792 1792
==========================================
- Hits 13093 13081 -12
- Misses 5111 5121 +10
- Partials 811 813 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2026-04-10 21:42:42 Comparing candidate commit 08963a3 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 187 metrics, 1 unstable metrics. scenario:HookBench/benchHookOverheadTraceFunction-opcache
scenario:HookBench/benchHookOverheadTraceMethod-opcache
scenario:HookBench/benchWithoutHook-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache
|
Leiyks
approved these changes
Apr 7, 2026
| zend_string *type; /* resolved span type */ | ||
| zend_string *env; /* from span->property_env; NULL when empty */ | ||
| zend_string *version; /* from span->root->property_version; NULL when empty */ | ||
| zend_string *span_kind; /* meta["span.kind"], NULL if absent or not a string */ |
Contributor
There was a problem hiding this comment.
nit: this is not a owned strings but a borrowed one right ?
Comment on lines
+275
to
+277
| ddog_CharSlice grpc_meta[4]; | ||
| double grpc_metrics[4]; | ||
| for (int i = 0; i < 4; i++) { |
Contributor
There was a problem hiding this comment.
Suggested change
| ddog_CharSlice grpc_meta[4]; | |
| double grpc_metrics[4]; | |
| for (int i = 0; i < 4; i++) { | |
| ddog_CharSlice grpc_meta[ddog_PHP_GRPC_KEY_COUNT]; | |
| double grpc_metrics[ddog_PHP_GRPC_KEY_COUNT]; | |
| for (int i = 0; i < ddog_PHP_GRPC_KEY_COUNT; i++) { |
Uses SHM under the hood, with fallback to sending over the socket (very first payloads when tracer starts, until the sidecar creates the SHM file). Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> # Conflicts: # Cargo.lock # components-rs/common.h # libdatadog
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/shm-stats-computation
branch
2 times, most recently
from
51aee07 to
03e93e3
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/shm-stats-computation
branch
from
03e93e3 to
08963a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses SHM under the hood, with fallback to sending over the socket (very first payloads when tracer starts, until the sidecar creates the SHM file).