Skip to content

Conversation

@randomanderson
Copy link
Contributor

Description

Currently, the reliability env branch is not passed forward to the packaging pipeline. This makes it impossible to test rel-env changes on a branch.

With this PR, the variable is passed forward. I also renamed the variable to be consistent with https://github.com/DataDog/dd-trace-php/blob/master/.gitlab/generate-package.php#L1431

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@randomanderson randomanderson requested a review from a team as a code owner January 28, 2026 17:31
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 28, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

ext/soap/tests/bugs/bug76348.phpt (Bug #76348 (WSDL_CACHE_MEMORY causes Segmentation fault)) from php.ext.soap.tests.bugs (Datadog) (Fix with Cursor)
001- ===DONE===
001+ Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing Schema: can't import schema from 'http://www.w3.org/2009/01/xml.xsd' in /usr/local/src/php/ext/soap/tests/bugs/bug76348.php:2
002+ Stack trace:
003+ #0 /usr/local/src/php/ext/soap/tests/bugs/bug76348.php(2): SoapClient->__construct('/usr/local/src/...', Array)
004+ #1 {main}
005+   thrown in /usr/local/src/php/ext/soap/tests/bugs/bug76348.php on line 2

    testUserLoginSuccessEvent from tests/Integrations/Laravel/V4.DDTrace\Tests\Integrations\Laravel\V4\AutomatedLoginEventsTest (Fix with Cursor)

🧪 1026 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 697a5cf700000000bb245f0a030e5ae4
tid: 697a5cf700000000
hexProcessTraceId: bb245f0a030e5ae4
hexProcessSpanId: 26a3bd98ad853e74
processTraceId: 13485007680859691748
processSpanId: 2784277458088967796

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

    testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Fix with Cursor)

View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 80abc5e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.12%. Comparing base (21d2f00) to head (80abc5e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
- Coverage   62.23%   62.12%   -0.11%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8331     8317      -14     
- Misses       4260     4270      +10     
- Partials      796      800       +4     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d2f00...80abc5e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@randomanderson randomanderson enabled auto-merge (squash) January 28, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants