Fix installer AppSec tests for duplicate INI entry registration

[Leiyks]

Description

Fixes installer test failures caused by duplicate INI entry registration in 1.16.0.

Problem

In 1.16.0, commit f1ee6fb added DD_APPSEC_ENABLED to ext/configuration.h. This created a duplicate registration since the same INI entry was already defined in appsec/src/extension/configuration.h.

When both extensions register the same INI entry, only the first one (ddtrace) succeeds. The AppSec extension's php --ri ddappsec output no longer displays datadog.appsec.enabled because it's now owned by the ddtrace extension.

Solution

Updated assert_appsec_enabled() and assert_appsec_disabled() to check for "Current state => Enabled" instead of datadog.appsec.enabled => On. This status line is always displayed by AppSec's phpinfo function regardless of INI ownership

[datadog-official]

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)

DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 697a34fb0000000046cce979a761cccd
tid: 697a34fb00000000
hexProcessTraceId: 46cce979a761cccd
hexProcessSpanId: aaac80d0cb85e160
processTraceId: 5101709186612448461
processSpanId: 12298346316698083680

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

View all

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: db8daf3 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.91%. Comparing base (ba0eb26) to head (db8daf3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3604      +/-   ##
==========================================
- Coverage   61.92%   61.91%   -0.02%     
==========================================
  Files         140      140              
  Lines       13312    13312              
  Branches     1762     1762              
==========================================
- Hits         8244     8242       -2     
- Misses       4277     4280       +3     
+ Partials      791      790       -1     

see 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0eb26...db8daf3. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[estringana]

I'm trying to understand why this is failing again. I got it fixed here #3598 but seems as it didn't work, even thought I worked on my branch