Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 20, 2026

Description

Process_tags will be added to remote config in a follow-up PR.
To test the feature we need to do something like that:

try {
    $request = $rr->waitForRequest(function($req) {
        return strpos($req["uri"], '/v0.7/config') !== false;
    });
    $body = json_decode($request["body"], true);
} catch (Exception $e) {
    echo "ERROR: No RC request found\n";
    exit(1);
}

if (!isset($body["client"]["client_tracer"]["process_tags"])) {
    echo "ERROR: Missing 'process_tags' field\n";
    exit(1);
}

echo $body["client"]["client_tracer"]["process_tags"];
del_rc_file($path);

However, until this PR, RC requests were not stored which was making a test like that impossible.
This PR therefore stores the RC requests so we can retrieve them in tests.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-official
Copy link

datadog-official bot commented Jan 20, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1027 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 697c8644000000000e4c4feb1f433df6
tid: 697c864400000000
hexProcessTraceId: 0e4c4feb1f433df6
hexProcessSpanId: bc7d7975ac6915b6
processTraceId: 1030286286021410294
processSpanId: 13582145597529986486
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 33c76cc | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dubloom dubloom marked this pull request as ready for review January 30, 2026 10:02
@dubloom dubloom requested a review from a team as a code owner January 30, 2026 10:02
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (ff8f987) to head (33c76cc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3585      +/-   ##
==========================================
- Coverage   62.24%   62.11%   -0.14%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8333     8315      -18     
- Misses       4257     4273      +16     
- Partials      797      799       +2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8f987...33c76cc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants