Skip to content

Conversation

@cataphract
Copy link
Contributor

Description

  • Appsec helper submits per-service worker count
  • This all the other existing telemetry metrics that the helper generates are now submitted directly to sidecar, rather than going through the extension.

See also DataDog/libdatadog#1400

@cataphract cataphract requested review from a team as code owners December 12, 2025 18:45
@cataphract cataphract changed the base branch from master to glopes/appsec-abstract-ns December 12, 2025 18:45
@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from e8d6f32 to 1d00e73 Compare December 12, 2025 18:48
@cataphract cataphract changed the base branch from glopes/appsec-abstract-ns to master December 12, 2025 18:50
@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2026-01-28 11:24:05

Comparing candidate commit a9545e1 in PR branch glopes/sidecar-ffi-tel-metrics with baseline commit 5456721 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6979eb210000000040a82342617c5dbd
tid: 6979eb2100000000
hexProcessTraceId: 40a82342617c5dbd
hexProcessSpanId: f5fb3f906252d6cf
processTraceId: 4659012582525132221
processSpanId: 17724830647804155599

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6979eb2b0000000065c3b69ae226b23e
tid: 6979eb2b00000000
hexProcessTraceId: 65c3b69ae226b23e
hexProcessSpanId: 977c721ba7545df8
processTraceId: 7332905394624705086
processSpanId: 10915725059936247288
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a9545e1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from 26633c8 to 6c240c5 Compare January 20, 2026 13:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 61.93548% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.12%. Comparing base (5456721) to head (a9545e1).

Files with missing lines Patch % Lines
appsec/src/helper/service.cpp 55.79% 50 Missing and 11 partials ⚠️
appsec/src/helper/service.hpp 64.40% 16 Missing and 5 partials ⚠️
appsec/src/helper/runner.cpp 0.00% 14 Missing ⚠️
appsec/src/helper/ffi.hpp 67.74% 7 Missing and 3 partials ⚠️
appsec/src/helper/client.cpp 75.00% 2 Missing and 3 partials ⚠️
appsec/src/helper/client.hpp 87.50% 2 Missing and 2 partials ⚠️
appsec/src/helper/sidecar_settings.hpp 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (61.93%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3530      +/-   ##
==========================================
+ Coverage   61.92%   62.12%   +0.19%     
==========================================
  Files         140      141       +1     
  Lines       13312    13387      +75     
  Branches     1762     1753       -9     
==========================================
+ Hits         8244     8317      +73     
+ Misses       4277     4270       -7     
- Partials      791      800       +9     
Files with missing lines Coverage Δ
appsec/src/extension/commands/client_init.c 83.10% <ø> (+2.18%) ⬆️
appsec/src/extension/commands/request_shutdown.c 77.46% <100.00%> (+0.10%) ⬆️
appsec/src/extension/commands_helpers.c 69.23% <ø> (-0.47%) ⬇️
appsec/src/helper/engine.hpp 100.00% <100.00%> (ø)
appsec/src/helper/network/proto.hpp 93.22% <ø> (ø)
appsec/src/helper/remote_config/client.cpp 14.55% <100.00%> (-4.34%) ⬇️
appsec/src/helper/remote_config/client.hpp 100.00% <ø> (ø)
appsec/src/helper/runner.hpp 0.00% <ø> (ø)
appsec/src/helper/subscriber/waf.cpp 71.53% <100.00%> (+0.12%) ⬆️
appsec/src/helper/telemetry.hpp 47.72% <ø> (ø)
... and 7 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5456721...a9545e1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-28 11:43:52

Comparing candidate commit a9545e1 in PR branch glopes/sidecar-ffi-tel-metrics with baseline commit 5456721 in branch master.

Found 1 performance improvements and 6 performance regressions! Performance is the same for 185 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-1213.197ns; -386.803ns] or [-9.629%; -3.070%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+4.718µs; +5.762µs] or [+4.675%; +5.710%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+6.315µs; +8.605µs] or [+6.366%; +8.675%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+30.640ns; +103.560ns] or [+2.563%; +8.661%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+78.940ns; +150.260ns] or [+6.749%; +12.847%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+64.528ns; +131.472ns] or [+5.433%; +11.070%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+86.319ns; +139.881ns] or [+7.456%; +12.083%]

@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from 1d1c8e1 to b4a6ce2 Compare January 23, 2026 14:40
@cataphract cataphract requested a review from a team as a code owner January 23, 2026 14:40
@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch 3 times, most recently from b833c8b to ff24295 Compare January 26, 2026 17:10
@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from ff24295 to f1190ee Compare January 26, 2026 17:27
@cataphract cataphract enabled auto-merge January 26, 2026 17:46
@cataphract cataphract force-pushed the glopes/sidecar-ffi-tel-metrics branch from 70a51b1 to ceaf887 Compare January 27, 2026 10:10
@estringana estringana self-requested a review January 28, 2026 10:45
@cataphract cataphract self-assigned this Jan 28, 2026
@cataphract cataphract disabled auto-merge January 28, 2026 16:33
@cataphract cataphract merged commit 21d2f00 into master Jan 28, 2026
2027 of 2036 checks passed
@cataphract cataphract deleted the glopes/sidecar-ffi-tel-metrics branch January 28, 2026 16:33
@github-actions github-actions bot added this to the 1.17.0 milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants