Draft
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (315.767 µs) : 278, 354
. : milestone, 316,
basic (279.121 µs) : 273, 285
. : milestone, 279,
loop (8.962 ms) : 8958, 8967
. : milestone, 8962,
section candidate
noprobe (313.789 µs) : 281, 346
. : milestone, 314,
basic (273.492 µs) : 267, 280
. : milestone, 273,
loop (8.957 ms) : 8952, 8961
. : milestone, 8957,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066073
Total [baseline] (11.145 s) : 0, 11144588
Agent [candidate] (1.059 s) : 0, 1058840
Total [candidate] (11.007 s) : 0, 11007249
section appsec
Agent [baseline] (1.248 s) : 0, 1248140
Total [baseline] (11.221 s) : 0, 11220891
Agent [candidate] (1.247 s) : 0, 1247302
Total [candidate] (11.213 s) : 0, 11212727
section iast
Agent [baseline] (1.231 s) : 0, 1231252
Total [baseline] (11.343 s) : 0, 11343138
Agent [candidate] (1.228 s) : 0, 1227622
Total [candidate] (11.303 s) : 0, 11302890
section profiling
Agent [baseline] (1.184 s) : 0, 1184497
Total [baseline] (11.102 s) : 0, 11101636
Agent [candidate] (1.181 s) : 0, 1181102
Total [candidate] (11.122 s) : 0, 11122431
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (630.721 ms) : 0, 630721
BytebuddyAgent [candidate] (627.626 ms) : 0, 627626
AgentMeter [baseline] (29.347 ms) : 0, 29347
AgentMeter [candidate] (29.066 ms) : 0, 29066
GlobalTracer [baseline] (258.415 ms) : 0, 258415
GlobalTracer [candidate] (256.602 ms) : 0, 256602
AppSec [baseline] (31.918 ms) : 0, 31918
AppSec [candidate] (31.584 ms) : 0, 31584
Debugger [baseline] (60.665 ms) : 0, 60665
Debugger [candidate] (60.084 ms) : 0, 60084
Remote Config [baseline] (593.639 µs) : 0, 594
Remote Config [candidate] (587.674 µs) : 0, 588
Telemetry [baseline] (8.117 ms) : 0, 8117
Telemetry [candidate] (7.981 ms) : 0, 7981
Flare Poller [baseline] (8.96 ms) : 0, 8960
Flare Poller [candidate] (8.071 ms) : 0, 8071
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (658.462 ms) : 0, 658462
BytebuddyAgent [candidate] (658.985 ms) : 0, 658985
AgentMeter [baseline] (12.051 ms) : 0, 12051
AgentMeter [candidate] (11.969 ms) : 0, 11969
GlobalTracer [baseline] (258.749 ms) : 0, 258749
GlobalTracer [candidate] (258.266 ms) : 0, 258266
IAST [baseline] (24.275 ms) : 0, 24275
IAST [candidate] (24.18 ms) : 0, 24180
AppSec [baseline] (177.937 ms) : 0, 177937
AppSec [candidate] (177.651 ms) : 0, 177651
Debugger [baseline] (66.541 ms) : 0, 66541
Debugger [candidate] (66.244 ms) : 0, 66244
Remote Config [baseline] (620.751 µs) : 0, 621
Remote Config [candidate] (611.803 µs) : 0, 612
Telemetry [baseline] (8.321 ms) : 0, 8321
Telemetry [candidate] (8.279 ms) : 0, 8279
Flare Poller [baseline] (3.603 ms) : 0, 3603
Flare Poller [candidate] (3.611 ms) : 0, 3611
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (797.694 ms) : 0, 797694
BytebuddyAgent [candidate] (795.06 ms) : 0, 795060
AgentMeter [baseline] (11.384 ms) : 0, 11384
AgentMeter [candidate] (11.348 ms) : 0, 11348
GlobalTracer [baseline] (248.779 ms) : 0, 248779
GlobalTracer [candidate] (247.705 ms) : 0, 247705
IAST [baseline] (25.452 ms) : 0, 25452
IAST [candidate] (25.356 ms) : 0, 25356
AppSec [baseline] (26.601 ms) : 0, 26601
AppSec [candidate] (26.527 ms) : 0, 26527
Debugger [baseline] (70.925 ms) : 0, 70925
Debugger [candidate] (71.19 ms) : 0, 71190
Remote Config [baseline] (534.779 µs) : 0, 535
Remote Config [candidate] (533.513 µs) : 0, 534
Telemetry [baseline] (9.184 ms) : 0, 9184
Telemetry [candidate] (9.185 ms) : 0, 9185
Flare Poller [baseline] (3.367 ms) : 0, 3367
Flare Poller [candidate] (3.352 ms) : 0, 3352
section profiling
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (683.546 ms) : 0, 683546
BytebuddyAgent [candidate] (682.052 ms) : 0, 682052
AgentMeter [baseline] (8.627 ms) : 0, 8627
AgentMeter [candidate] (8.621 ms) : 0, 8621
GlobalTracer [baseline] (215.513 ms) : 0, 215513
GlobalTracer [candidate] (215.119 ms) : 0, 215119
AppSec [baseline] (32.275 ms) : 0, 32275
AppSec [candidate] (32.192 ms) : 0, 32192
Debugger [baseline] (62.295 ms) : 0, 62295
Debugger [candidate] (66.122 ms) : 0, 66122
Remote Config [baseline] (582.871 µs) : 0, 583
Remote Config [candidate] (581.071 µs) : 0, 581
Telemetry [baseline] (10.19 ms) : 0, 10190
Telemetry [candidate] (7.617 ms) : 0, 7617
Flare Poller [baseline] (5.025 ms) : 0, 5025
Flare Poller [candidate] (3.414 ms) : 0, 3414
ProfilingAgent [baseline] (94.46 ms) : 0, 94460
ProfilingAgent [candidate] (93.485 ms) : 0, 93485
Profiling [baseline] (95.039 ms) : 0, 95039
Profiling [candidate] (94.039 ms) : 0, 94039
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058698
Total [baseline] (8.811 s) : 0, 8811024
Agent [candidate] (1.067 s) : 0, 1067079
Total [candidate] (8.852 s) : 0, 8851927
section iast
Agent [baseline] (1.226 s) : 0, 1225664
Total [baseline] (9.557 s) : 0, 9557387
Agent [candidate] (1.231 s) : 0, 1230631
Total [candidate] (9.549 s) : 0, 9549497
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (627.197 ms) : 0, 627197
BytebuddyAgent [candidate] (631.836 ms) : 0, 631836
AgentMeter [baseline] (29.041 ms) : 0, 29041
AgentMeter [candidate] (29.289 ms) : 0, 29289
GlobalTracer [baseline] (256.922 ms) : 0, 256922
GlobalTracer [candidate] (258.882 ms) : 0, 258882
AppSec [baseline] (31.567 ms) : 0, 31567
AppSec [candidate] (31.937 ms) : 0, 31937
Debugger [baseline] (59.264 ms) : 0, 59264
Debugger [candidate] (59.914 ms) : 0, 59914
Remote Config [baseline] (589.447 µs) : 0, 589
Remote Config [candidate] (590.171 µs) : 0, 590
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.188 ms) : 0, 8188
Flare Poller [baseline] (8.845 ms) : 0, 8845
Flare Poller [candidate] (9.069 ms) : 0, 9069
section iast
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (795.426 ms) : 0, 795426
BytebuddyAgent [candidate] (799.006 ms) : 0, 799006
AgentMeter [baseline] (11.305 ms) : 0, 11305
AgentMeter [candidate] (11.547 ms) : 0, 11547
GlobalTracer [baseline] (247.201 ms) : 0, 247201
GlobalTracer [candidate] (248.174 ms) : 0, 248174
AppSec [baseline] (26.477 ms) : 0, 26477
AppSec [candidate] (26.464 ms) : 0, 26464
Debugger [baseline] (69.673 ms) : 0, 69673
Debugger [candidate] (68.935 ms) : 0, 68935
Remote Config [baseline] (528.214 µs) : 0, 528
Remote Config [candidate] (518.895 µs) : 0, 519
Telemetry [baseline] (9.145 ms) : 0, 9145
Telemetry [candidate] (9.612 ms) : 0, 9612
Flare Poller [baseline] (3.312 ms) : 0, 3312
Flare Poller [candidate] (3.46 ms) : 0, 3460
IAST [baseline] (25.278 ms) : 0, 25278
IAST [candidate] (25.47 ms) : 0, 25470
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1178, 1201
. : milestone, 1190,
iast (3.133 ms) : 3094, 3172
. : milestone, 3133,
iast_FULL (5.846 ms) : 5787, 5904
. : milestone, 5846,
iast_GLOBAL (3.576 ms) : 3521, 3631
. : milestone, 3576,
profiling (2.121 ms) : 2102, 2141
. : milestone, 2121,
tracing (1.886 ms) : 1868, 1904
. : milestone, 1886,
section candidate
no_agent (1.19 ms) : 1178, 1202
. : milestone, 1190,
iast (3.142 ms) : 3100, 3185
. : milestone, 3142,
iast_FULL (6.076 ms) : 6013, 6138
. : milestone, 6076,
iast_GLOBAL (3.57 ms) : 3516, 3624
. : milestone, 3570,
profiling (2.053 ms) : 2035, 2072
. : milestone, 2053,
tracing (1.792 ms) : 1778, 1806
. : milestone, 1792,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (19.273 ms) : 19073, 19473
. : milestone, 19273,
appsec (18.756 ms) : 18565, 18947
. : milestone, 18756,
code_origins (17.798 ms) : 17620, 17975
. : milestone, 17798,
iast (17.66 ms) : 17484, 17836
. : milestone, 17660,
profiling (19.215 ms) : 19020, 19411
. : milestone, 19215,
tracing (17.633 ms) : 17457, 17809
. : milestone, 17633,
section candidate
no_agent (17.526 ms) : 17346, 17707
. : milestone, 17526,
appsec (18.477 ms) : 18288, 18665
. : milestone, 18477,
code_origins (17.842 ms) : 17664, 18020
. : milestone, 17842,
iast (18.675 ms) : 18486, 18864
. : milestone, 18675,
profiling (19.419 ms) : 19222, 19617
. : milestone, 19419,
tracing (17.654 ms) : 17480, 17828
. : milestone, 17654,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
appsec (14.632 s) : 14632000, 14632000
. : milestone, 14632000,
iast (18.502 s) : 18502000, 18502000
. : milestone, 18502000,
iast_GLOBAL (17.778 s) : 17778000, 17778000
. : milestone, 17778000,
profiling (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
tracing (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
section candidate
no_agent (15.691 s) : 15691000, 15691000
. : milestone, 15691000,
appsec (14.539 s) : 14539000, 14539000
. : milestone, 14539000,
iast (18.04 s) : 18040000, 18040000
. : milestone, 18040000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
. : milestone, 17770000,
profiling (15.318 s) : 15318000, 15318000
. : milestone, 15318000,
tracing (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~529fc8ae6c, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.808 ms) : 3586, 4030
. : milestone, 3808,
iast (2.264 ms) : 2195, 2333
. : milestone, 2264,
iast_GLOBAL (2.299 ms) : 2230, 2369
. : milestone, 2299,
profiling (2.109 ms) : 2053, 2166
. : milestone, 2109,
tracing (2.071 ms) : 2017, 2125
. : milestone, 2071,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.75 ms) : 3534, 3966
. : milestone, 3750,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.308 ms) : 2238, 2378
. : milestone, 2308,
profiling (2.08 ms) : 2025, 2135
. : milestone, 2080,
tracing (2.065 ms) : 2011, 2118
. : milestone, 2065,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR introduces an
:logging-utilsmodule forRatelimitedLoggerandIOLogger.Additionally, Spock tests were migrated to JUnit.
Motivation
The goal is to move them away from the
:internal-apimodule so they can be reused in various components without having to rely on the global internal APIs.Additional Notes
The PR is split in 3 PR:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.