Use local root span to set resource name for vertx and jakartars#10876
Draft
sarahchen6 wants to merge 2 commits intomasterfrom
Draft
Use local root span to set resource name for vertx and jakartars#10876sarahchen6 wants to merge 2 commits intomasterfrom
sarahchen6 wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056988
Total [baseline] (10.977 s) : 0, 10977128
Agent [candidate] (1.063 s) : 0, 1063365
Total [candidate] (11.013 s) : 0, 11013458
section appsec
Agent [baseline] (1.243 s) : 0, 1243151
Total [baseline] (11.145 s) : 0, 11145456
Agent [candidate] (1.244 s) : 0, 1243926
Total [candidate] (11.166 s) : 0, 11166453
section iast
Agent [baseline] (1.229 s) : 0, 1229001
Total [baseline] (11.3 s) : 0, 11299678
Agent [candidate] (1.224 s) : 0, 1223583
Total [candidate] (11.279 s) : 0, 11278964
section profiling
Agent [baseline] (1.18 s) : 0, 1179523
Total [baseline] (11.089 s) : 0, 11089277
Agent [candidate] (1.18 s) : 0, 1180280
Total [candidate] (11.008 s) : 0, 11007939
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (626.669 ms) : 0, 626669
BytebuddyAgent [candidate] (630.688 ms) : 0, 630688
AgentMeter [baseline] (29.054 ms) : 0, 29054
AgentMeter [candidate] (29.055 ms) : 0, 29055
GlobalTracer [baseline] (256.393 ms) : 0, 256393
GlobalTracer [candidate] (256.995 ms) : 0, 256995
AppSec [baseline] (31.671 ms) : 0, 31671
AppSec [candidate] (31.693 ms) : 0, 31693
Debugger [baseline] (60.03 ms) : 0, 60030
Debugger [candidate] (60.176 ms) : 0, 60176
Remote Config [baseline] (591.476 µs) : 0, 591
Remote Config [candidate] (615.306 µs) : 0, 615
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.072 ms) : 0, 8072
Flare Poller [baseline] (7.348 ms) : 0, 7348
Flare Poller [candidate] (8.684 ms) : 0, 8684
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (656.474 ms) : 0, 656474
BytebuddyAgent [candidate] (657.036 ms) : 0, 657036
AgentMeter [baseline] (12.027 ms) : 0, 12027
AgentMeter [candidate] (11.964 ms) : 0, 11964
GlobalTracer [baseline] (257.398 ms) : 0, 257398
GlobalTracer [candidate] (257.773 ms) : 0, 257773
AppSec [baseline] (177.082 ms) : 0, 177082
AppSec [candidate] (177.163 ms) : 0, 177163
Debugger [baseline] (66.201 ms) : 0, 66201
Debugger [candidate] (65.998 ms) : 0, 65998
Remote Config [baseline] (615.459 µs) : 0, 615
Remote Config [candidate] (624.781 µs) : 0, 625
Telemetry [baseline] (8.246 ms) : 0, 8246
Telemetry [candidate] (8.249 ms) : 0, 8249
Flare Poller [baseline] (3.599 ms) : 0, 3599
Flare Poller [candidate] (3.598 ms) : 0, 3598
IAST [baseline] (24.091 ms) : 0, 24091
IAST [candidate] (24.153 ms) : 0, 24153
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (795.334 ms) : 0, 795334
BytebuddyAgent [candidate] (792.561 ms) : 0, 792561
AgentMeter [baseline] (11.31 ms) : 0, 11310
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (248.645 ms) : 0, 248645
GlobalTracer [candidate] (247.067 ms) : 0, 247067
AppSec [baseline] (26.897 ms) : 0, 26897
AppSec [candidate] (26.422 ms) : 0, 26422
Debugger [baseline] (71.016 ms) : 0, 71016
Debugger [candidate] (70.7 ms) : 0, 70700
Remote Config [baseline] (527.779 µs) : 0, 528
Remote Config [candidate] (520.08 µs) : 0, 520
Telemetry [baseline] (9.143 ms) : 0, 9143
Telemetry [candidate] (9.246 ms) : 0, 9246
Flare Poller [baseline] (3.347 ms) : 0, 3347
Flare Poller [candidate] (3.321 ms) : 0, 3321
IAST [baseline] (25.596 ms) : 0, 25596
IAST [candidate] (25.294 ms) : 0, 25294
section profiling
crashtracking [baseline] (1.169 ms) : 0, 1169
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (680.591 ms) : 0, 680591
BytebuddyAgent [candidate] (681.678 ms) : 0, 681678
AgentMeter [baseline] (8.592 ms) : 0, 8592
AgentMeter [candidate] (8.609 ms) : 0, 8609
GlobalTracer [baseline] (215.067 ms) : 0, 215067
GlobalTracer [candidate] (215.282 ms) : 0, 215282
AppSec [baseline] (32.098 ms) : 0, 32098
AppSec [candidate] (32.33 ms) : 0, 32330
Debugger [baseline] (64.424 ms) : 0, 64424
Debugger [candidate] (62.576 ms) : 0, 62576
Remote Config [baseline] (584.543 µs) : 0, 585
Remote Config [candidate] (570.919 µs) : 0, 571
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (10.004 ms) : 0, 10004
Flare Poller [baseline] (4.238 ms) : 0, 4238
Flare Poller [candidate] (4.243 ms) : 0, 4243
ProfilingAgent [baseline] (93.76 ms) : 0, 93760
ProfilingAgent [candidate] (93.11 ms) : 0, 93110
Profiling [baseline] (94.324 ms) : 0, 94324
Profiling [candidate] (93.664 ms) : 0, 93664
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056758
Total [baseline] (8.833 s) : 0, 8833397
Agent [candidate] (1.059 s) : 0, 1059450
Total [candidate] (8.806 s) : 0, 8806361
section iast
Agent [baseline] (1.23 s) : 0, 1230004
Total [baseline] (9.542 s) : 0, 9541594
Agent [candidate] (1.229 s) : 0, 1228726
Total [candidate] (9.598 s) : 0, 9597784
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (627.524 ms) : 0, 627524
BytebuddyAgent [candidate] (627.15 ms) : 0, 627150
AgentMeter [baseline] (28.931 ms) : 0, 28931
AgentMeter [candidate] (29.012 ms) : 0, 29012
GlobalTracer [baseline] (256.234 ms) : 0, 256234
GlobalTracer [candidate] (256.996 ms) : 0, 256996
AppSec [baseline] (31.661 ms) : 0, 31661
AppSec [candidate] (31.648 ms) : 0, 31648
Debugger [baseline] (59.272 ms) : 0, 59272
Debugger [candidate] (59.183 ms) : 0, 59183
Remote Config [baseline] (593.033 µs) : 0, 593
Remote Config [candidate] (585.167 µs) : 0, 585
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (8.139 ms) : 0, 8139
Flare Poller [baseline] (7.253 ms) : 0, 7253
Flare Poller [candidate] (9.49 ms) : 0, 9490
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (799.419 ms) : 0, 799419
BytebuddyAgent [candidate] (796.951 ms) : 0, 796951
AgentMeter [baseline] (11.563 ms) : 0, 11563
AgentMeter [candidate] (11.318 ms) : 0, 11318
GlobalTracer [baseline] (247.052 ms) : 0, 247052
GlobalTracer [candidate] (247.614 ms) : 0, 247614
AppSec [baseline] (26.453 ms) : 0, 26453
AppSec [candidate] (26.48 ms) : 0, 26480
Debugger [baseline] (69.124 ms) : 0, 69124
Debugger [candidate] (70.743 ms) : 0, 70743
Remote Config [baseline] (521.524 µs) : 0, 522
Remote Config [candidate] (529.682 µs) : 0, 530
Telemetry [baseline] (9.699 ms) : 0, 9699
Telemetry [candidate] (9.215 ms) : 0, 9215
Flare Poller [baseline] (3.474 ms) : 0, 3474
Flare Poller [candidate] (3.365 ms) : 0, 3365
IAST [baseline] (25.299 ms) : 0, 25299
IAST [candidate] (25.278 ms) : 0, 25278
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (19.06 ms) : 18860, 19259
. : milestone, 19060,
appsec (18.641 ms) : 18447, 18835
. : milestone, 18641,
code_origins (17.83 ms) : 17652, 18008
. : milestone, 17830,
iast (17.719 ms) : 17544, 17893
. : milestone, 17719,
profiling (18.747 ms) : 18562, 18932
. : milestone, 18747,
tracing (17.989 ms) : 17809, 18168
. : milestone, 17989,
section candidate
no_agent (17.799 ms) : 17616, 17981
. : milestone, 17799,
appsec (18.757 ms) : 18567, 18946
. : milestone, 18757,
code_origins (17.695 ms) : 17519, 17871
. : milestone, 17695,
iast (17.957 ms) : 17780, 18134
. : milestone, 17957,
profiling (19.311 ms) : 19116, 19506
. : milestone, 19311,
tracing (17.734 ms) : 17555, 17913
. : milestone, 17734,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.202 ms) : 3157, 3246
. : milestone, 3202,
iast_FULL (5.956 ms) : 5896, 6016
. : milestone, 5956,
iast_GLOBAL (3.451 ms) : 3399, 3503
. : milestone, 3451,
profiling (2.182 ms) : 2160, 2204
. : milestone, 2182,
tracing (1.786 ms) : 1771, 1801
. : milestone, 1786,
section candidate
no_agent (1.19 ms) : 1178, 1202
. : milestone, 1190,
iast (3.368 ms) : 3326, 3410
. : milestone, 3368,
iast_FULL (6.084 ms) : 6021, 6146
. : milestone, 6084,
iast_GLOBAL (3.529 ms) : 3478, 3579
. : milestone, 3529,
profiling (2.061 ms) : 2041, 2081
. : milestone, 2061,
tracing (1.81 ms) : 1795, 1825
. : milestone, 1810,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.816 ms) : 3592, 4041
. : milestone, 3816,
iast (2.276 ms) : 2206, 2346
. : milestone, 2276,
iast_GLOBAL (2.306 ms) : 2237, 2376
. : milestone, 2306,
profiling (2.11 ms) : 2054, 2165
. : milestone, 2110,
tracing (2.08 ms) : 2026, 2134
. : milestone, 2080,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.837 ms) : 3614, 4060
. : milestone, 3837,
iast (2.273 ms) : 2204, 2343
. : milestone, 2273,
iast_GLOBAL (2.309 ms) : 2240, 2379
. : milestone, 2309,
profiling (2.523 ms) : 2354, 2691
. : milestone, 2523,
tracing (2.071 ms) : 2017, 2124
. : milestone, 2071,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~8b0a96dc90, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
iast_GLOBAL (17.967 s) : 17967000, 17967000
. : milestone, 17967000,
profiling (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
section candidate
no_agent (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
appsec (14.563 s) : 14563000, 14563000
. : milestone, 14563000,
iast (18.55 s) : 18550000, 18550000
. : milestone, 18550000,
iast_GLOBAL (18.309 s) : 18309000, 18309000
. : milestone, 18309000,
profiling (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
tracing (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.