Improper test isolation for muzzle plugin tests#10875
Open
Conversation
From https://docs.gradle.org/8.14.4/javadoc/org/gradle/testkit/runner/GradleRunner.html#withTestKitDir(java.io.File) > If no value has been specified when the build is initiated, a directory will be created within a temporary directory. > > * When executed from a Gradle Test task, the Test task's temporary directory is used (see Task.getTemporaryDir()).
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061158
Total [baseline] (11.06 s) : 0, 11059672
Agent [candidate] (1.06 s) : 0, 1059563
Total [candidate] (11.02 s) : 0, 11019985
section appsec
Agent [baseline] (1.246 s) : 0, 1246238
Total [baseline] (11.119 s) : 0, 11119259
Agent [candidate] (1.249 s) : 0, 1248755
Total [candidate] (11.133 s) : 0, 11133191
section iast
Agent [baseline] (1.225 s) : 0, 1225159
Total [baseline] (11.298 s) : 0, 11298458
Agent [candidate] (1.228 s) : 0, 1228064
Total [candidate] (11.348 s) : 0, 11347540
section profiling
Agent [baseline] (1.184 s) : 0, 1183533
Total [baseline] (11.064 s) : 0, 11064075
Agent [candidate] (1.182 s) : 0, 1181953
Total [candidate] (11.051 s) : 0, 11051465
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (628.034 ms) : 0, 628034
BytebuddyAgent [candidate] (628.404 ms) : 0, 628404
AgentMeter [baseline] (29.078 ms) : 0, 29078
AgentMeter [candidate] (29.089 ms) : 0, 29089
GlobalTracer [baseline] (257.103 ms) : 0, 257103
GlobalTracer [candidate] (257.369 ms) : 0, 257369
AppSec [baseline] (31.743 ms) : 0, 31743
AppSec [candidate] (31.895 ms) : 0, 31895
Debugger [baseline] (60.373 ms) : 0, 60373
Debugger [candidate] (60.348 ms) : 0, 60348
Remote Config [baseline] (597.348 µs) : 0, 597
Remote Config [candidate] (598.627 µs) : 0, 599
Telemetry [baseline] (8.09 ms) : 0, 8090
Telemetry [candidate] (8.12 ms) : 0, 8120
Flare Poller [baseline] (8.837 ms) : 0, 8837
Flare Poller [candidate] (6.498 ms) : 0, 6498
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (658.109 ms) : 0, 658109
BytebuddyAgent [candidate] (660.891 ms) : 0, 660891
AgentMeter [baseline] (11.993 ms) : 0, 11993
AgentMeter [candidate] (12.027 ms) : 0, 12027
GlobalTracer [baseline] (258.052 ms) : 0, 258052
GlobalTracer [candidate] (258.014 ms) : 0, 258014
IAST [baseline] (24.195 ms) : 0, 24195
IAST [candidate] (24.145 ms) : 0, 24145
AppSec [baseline] (177.76 ms) : 0, 177760
AppSec [candidate] (177.36 ms) : 0, 177360
Debugger [baseline] (66.156 ms) : 0, 66156
Debugger [candidate] (66.244 ms) : 0, 66244
Remote Config [baseline] (618.563 µs) : 0, 619
Remote Config [candidate] (621.474 µs) : 0, 621
Telemetry [baseline] (8.269 ms) : 0, 8269
Telemetry [candidate] (8.243 ms) : 0, 8243
Flare Poller [baseline] (3.614 ms) : 0, 3614
Flare Poller [candidate] (3.616 ms) : 0, 3616
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (794.296 ms) : 0, 794296
BytebuddyAgent [candidate] (796.187 ms) : 0, 796187
AgentMeter [baseline] (11.289 ms) : 0, 11289
AgentMeter [candidate] (11.342 ms) : 0, 11342
GlobalTracer [baseline] (246.926 ms) : 0, 246926
GlobalTracer [candidate] (247.541 ms) : 0, 247541
IAST [baseline] (25.245 ms) : 0, 25245
IAST [candidate] (25.315 ms) : 0, 25315
AppSec [baseline] (26.499 ms) : 0, 26499
AppSec [candidate] (26.48 ms) : 0, 26480
Debugger [baseline] (70.692 ms) : 0, 70692
Debugger [candidate] (70.77 ms) : 0, 70770
Remote Config [baseline] (529.965 µs) : 0, 530
Remote Config [candidate] (530.227 µs) : 0, 530
Telemetry [baseline] (9.17 ms) : 0, 9170
Telemetry [candidate] (9.251 ms) : 0, 9251
Flare Poller [baseline] (3.329 ms) : 0, 3329
Flare Poller [candidate] (3.368 ms) : 0, 3368
section profiling
crashtracking [baseline] (1.16 ms) : 0, 1160
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (683.161 ms) : 0, 683161
BytebuddyAgent [candidate] (682.516 ms) : 0, 682516
AgentMeter [baseline] (8.65 ms) : 0, 8650
AgentMeter [candidate] (8.662 ms) : 0, 8662
GlobalTracer [baseline] (215.814 ms) : 0, 215814
GlobalTracer [candidate] (215.529 ms) : 0, 215529
AppSec [baseline] (32.268 ms) : 0, 32268
AppSec [candidate] (32.357 ms) : 0, 32357
Debugger [baseline] (65.305 ms) : 0, 65305
Debugger [candidate] (65.004 ms) : 0, 65004
Remote Config [baseline] (583.345 µs) : 0, 583
Remote Config [candidate] (579.538 µs) : 0, 580
Telemetry [baseline] (8.451 ms) : 0, 8451
Telemetry [candidate] (8.494 ms) : 0, 8494
Flare Poller [baseline] (3.505 ms) : 0, 3505
Flare Poller [candidate] (3.475 ms) : 0, 3475
ProfilingAgent [baseline] (93.883 ms) : 0, 93883
ProfilingAgent [candidate] (93.527 ms) : 0, 93527
Profiling [baseline] (94.459 ms) : 0, 94459
Profiling [candidate] (94.079 ms) : 0, 94079
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064921
Total [baseline] (8.863 s) : 0, 8862795
Agent [candidate] (1.069 s) : 0, 1069138
Total [candidate] (8.875 s) : 0, 8874765
section iast
Agent [baseline] (1.226 s) : 0, 1226475
Total [baseline] (9.52 s) : 0, 9519602
Agent [candidate] (1.232 s) : 0, 1231757
Total [candidate] (9.535 s) : 0, 9534674
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (633.108 ms) : 0, 633108
BytebuddyAgent [candidate] (632.831 ms) : 0, 632831
AgentMeter [baseline] (29.214 ms) : 0, 29214
AgentMeter [candidate] (29.172 ms) : 0, 29172
GlobalTracer [baseline] (258.339 ms) : 0, 258339
GlobalTracer [candidate] (258.842 ms) : 0, 258842
AppSec [baseline] (31.97 ms) : 0, 31970
AppSec [candidate] (31.919 ms) : 0, 31919
Debugger [baseline] (59.799 ms) : 0, 59799
Debugger [candidate] (59.928 ms) : 0, 59928
Remote Config [baseline] (597.184 µs) : 0, 597
Remote Config [candidate] (602.759 µs) : 0, 603
Telemetry [baseline] (8.138 ms) : 0, 8138
Telemetry [candidate] (8.126 ms) : 0, 8126
Flare Poller [baseline] (6.441 ms) : 0, 6441
Flare Poller [candidate] (10.308 ms) : 0, 10308
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (795.801 ms) : 0, 795801
BytebuddyAgent [candidate] (800.254 ms) : 0, 800254
AgentMeter [baseline] (11.369 ms) : 0, 11369
AgentMeter [candidate] (11.441 ms) : 0, 11441
GlobalTracer [baseline] (247.515 ms) : 0, 247515
GlobalTracer [candidate] (247.753 ms) : 0, 247753
IAST [baseline] (25.301 ms) : 0, 25301
IAST [candidate] (25.272 ms) : 0, 25272
AppSec [baseline] (26.569 ms) : 0, 26569
AppSec [candidate] (26.327 ms) : 0, 26327
Debugger [baseline] (68.36 ms) : 0, 68360
Debugger [candidate] (69.518 ms) : 0, 69518
Remote Config [baseline] (518.536 µs) : 0, 519
Remote Config [candidate] (528.163 µs) : 0, 528
Telemetry [baseline] (10.13 ms) : 0, 10130
Telemetry [candidate] (9.818 ms) : 0, 9818
Flare Poller [baseline] (3.635 ms) : 0, 3635
Flare Poller [candidate] (3.462 ms) : 0, 3462
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.13 ms) : 3088, 3171
. : milestone, 3130,
iast_FULL (5.801 ms) : 5744, 5857
. : milestone, 5801,
iast_GLOBAL (3.535 ms) : 3472, 3599
. : milestone, 3535,
profiling (2.215 ms) : 2192, 2239
. : milestone, 2215,
tracing (1.814 ms) : 1799, 1829
. : milestone, 1814,
section candidate
no_agent (1.175 ms) : 1164, 1185
. : milestone, 1175,
iast (3.175 ms) : 3133, 3217
. : milestone, 3175,
iast_FULL (5.885 ms) : 5827, 5944
. : milestone, 5885,
iast_GLOBAL (3.462 ms) : 3402, 3522
. : milestone, 3462,
profiling (1.987 ms) : 1970, 2004
. : milestone, 1987,
tracing (1.764 ms) : 1748, 1779
. : milestone, 1764,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (18.482 ms) : 18288, 18676
. : milestone, 18482,
appsec (18.557 ms) : 18368, 18746
. : milestone, 18557,
code_origins (17.651 ms) : 17477, 17824
. : milestone, 17651,
iast (17.805 ms) : 17631, 17980
. : milestone, 17805,
profiling (19.912 ms) : 19706, 20119
. : milestone, 19912,
tracing (17.735 ms) : 17558, 17912
. : milestone, 17735,
section candidate
no_agent (19.522 ms) : 19320, 19725
. : milestone, 19522,
appsec (18.932 ms) : 18739, 19125
. : milestone, 18932,
code_origins (17.901 ms) : 17722, 18081
. : milestone, 17901,
iast (17.687 ms) : 17514, 17860
. : milestone, 17687,
profiling (18.6 ms) : 18416, 18783
. : milestone, 18600,
tracing (17.825 ms) : 17647, 18002
. : milestone, 17825,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (15.276 s) : 15276000, 15276000
. : milestone, 15276000,
appsec (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
iast (18.289 s) : 18289000, 18289000
. : milestone, 18289000,
iast_GLOBAL (17.853 s) : 17853000, 17853000
. : milestone, 17853000,
profiling (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
section candidate
no_agent (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
appsec (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
iast (18.229 s) : 18229000, 18229000
. : milestone, 18229000,
iast_GLOBAL (18.394 s) : 18394000, 18394000
. : milestone, 18394000,
profiling (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
tracing (14.793 s) : 14793000, 14793000
. : milestone, 14793000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~25009ba8e9, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.785 ms) : 3564, 4006
. : milestone, 3785,
iast (2.247 ms) : 2178, 2317
. : milestone, 2247,
iast_GLOBAL (2.295 ms) : 2225, 2364
. : milestone, 2295,
profiling (2.075 ms) : 2020, 2130
. : milestone, 2075,
tracing (2.056 ms) : 2002, 2110
. : milestone, 2056,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (3.788 ms) : 3566, 4011
. : milestone, 3788,
iast (2.242 ms) : 2172, 2311
. : milestone, 2242,
iast_GLOBAL (2.298 ms) : 2228, 2368
. : milestone, 2298,
profiling (2.51 ms) : 2343, 2676
. : milestone, 2510,
tracing (2.051 ms) : 1997, 2105
. : milestone, 2051,
|
AlexeyKuznetsov-DD
approved these changes
Mar 17, 2026
…tests MuzzleMavenRepoUtils.MUZZLE_REPOS is a lazy singleton initialized once per JVM from MAVEN_REPOSITORY_PROXY. When the Gradle daemon was reused across test cases, the env var value from the first test was cached, causing version range resolution to target a non-existent or unrelated local Maven repo in subsequent tests. Passing --no-daemon ensures each GradleRunner invocation starts a fresh JVM, so MUZZLE_REPOS is re-evaluated with the correct repo URL for each test. As a side effect, this also prevents the daemon from holding file handles on @tempdir directories at JUnit cleanup time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
The tests are asserting the correct things and pass, however during some cleanup operations, the test kit dir could be deleted too early.
In particular the use of
withTestKitDirwas likely incorrect.As the Javadoc says, having no value should prevent this behavior.