add limits to the view name size in spring#10873
Draft
Conversation
b82ed71 to
143f058
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064025
Total [baseline] (11.109 s) : 0, 11108903
Agent [candidate] (1.064 s) : 0, 1064471
Total [candidate] (11.059 s) : 0, 11059258
section appsec
Agent [baseline] (1.245 s) : 0, 1245128
Total [baseline] (11.166 s) : 0, 11166217
Agent [candidate] (1.253 s) : 0, 1252639
Total [candidate] (11.164 s) : 0, 11164162
section iast
Agent [baseline] (1.231 s) : 0, 1230686
Total [baseline] (11.346 s) : 0, 11345760
Agent [candidate] (1.229 s) : 0, 1229056
Total [candidate] (11.388 s) : 0, 11388240
section profiling
Agent [baseline] (1.183 s) : 0, 1183008
Total [baseline] (11.167 s) : 0, 11166517
Agent [candidate] (1.189 s) : 0, 1188756
Total [candidate] (11.085 s) : 0, 11085472
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (632.317 ms) : 0, 632317
BytebuddyAgent [candidate] (630.981 ms) : 0, 630981
AgentMeter [baseline] (29.321 ms) : 0, 29321
AgentMeter [candidate] (29.282 ms) : 0, 29282
GlobalTracer [baseline] (257.912 ms) : 0, 257912
GlobalTracer [candidate] (258.563 ms) : 0, 258563
AppSec [baseline] (31.889 ms) : 0, 31889
AppSec [candidate] (31.901 ms) : 0, 31901
Debugger [baseline] (60.667 ms) : 0, 60667
Debugger [candidate] (60.456 ms) : 0, 60456
Remote Config [baseline] (600.761 µs) : 0, 601
Remote Config [candidate] (592.363 µs) : 0, 592
Telemetry [baseline] (8.162 ms) : 0, 8162
Telemetry [candidate] (8.05 ms) : 0, 8050
Flare Poller [baseline] (5.731 ms) : 0, 5731
Flare Poller [candidate] (7.322 ms) : 0, 7322
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (656.854 ms) : 0, 656854
BytebuddyAgent [candidate] (661.718 ms) : 0, 661718
AgentMeter [baseline] (11.978 ms) : 0, 11978
AgentMeter [candidate] (12.07 ms) : 0, 12070
GlobalTracer [baseline] (258.182 ms) : 0, 258182
GlobalTracer [candidate] (259.327 ms) : 0, 259327
IAST [baseline] (24.093 ms) : 0, 24093
IAST [candidate] (24.298 ms) : 0, 24298
AppSec [baseline] (177.854 ms) : 0, 177854
AppSec [candidate] (178.232 ms) : 0, 178232
Debugger [baseline] (66.179 ms) : 0, 66179
Debugger [candidate] (66.844 ms) : 0, 66844
Remote Config [baseline] (617.664 µs) : 0, 618
Remote Config [candidate] (628.358 µs) : 0, 628
Telemetry [baseline] (8.258 ms) : 0, 8258
Telemetry [candidate] (8.336 ms) : 0, 8336
Flare Poller [baseline] (3.613 ms) : 0, 3613
Flare Poller [candidate] (3.608 ms) : 0, 3608
section iast
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (798.002 ms) : 0, 798002
BytebuddyAgent [candidate] (796.53 ms) : 0, 796530
AgentMeter [baseline] (11.378 ms) : 0, 11378
AgentMeter [candidate] (11.395 ms) : 0, 11395
GlobalTracer [baseline] (248.078 ms) : 0, 248078
GlobalTracer [candidate] (248.047 ms) : 0, 248047
IAST [baseline] (25.42 ms) : 0, 25420
IAST [candidate] (25.306 ms) : 0, 25306
AppSec [baseline] (26.597 ms) : 0, 26597
AppSec [candidate] (26.541 ms) : 0, 26541
Debugger [baseline] (70.694 ms) : 0, 70694
Debugger [candidate] (70.784 ms) : 0, 70784
Remote Config [baseline] (531.264 µs) : 0, 531
Remote Config [candidate] (532.649 µs) : 0, 533
Telemetry [baseline] (9.213 ms) : 0, 9213
Telemetry [candidate] (9.229 ms) : 0, 9229
Flare Poller [baseline] (3.371 ms) : 0, 3371
Flare Poller [candidate] (3.328 ms) : 0, 3328
section profiling
crashtracking [baseline] (1.164 ms) : 0, 1164
crashtracking [candidate] (1.164 ms) : 0, 1164
BytebuddyAgent [baseline] (683.12 ms) : 0, 683120
BytebuddyAgent [candidate] (686.416 ms) : 0, 686416
AgentMeter [baseline] (8.647 ms) : 0, 8647
AgentMeter [candidate] (8.726 ms) : 0, 8726
GlobalTracer [baseline] (215.444 ms) : 0, 215444
GlobalTracer [candidate] (216.839 ms) : 0, 216839
AppSec [baseline] (32.244 ms) : 0, 32244
AppSec [candidate] (32.559 ms) : 0, 32559
Debugger [baseline] (65.399 ms) : 0, 65399
Debugger [candidate] (63.135 ms) : 0, 63135
Remote Config [baseline] (575.086 µs) : 0, 575
Remote Config [candidate] (576.727 µs) : 0, 577
Telemetry [baseline] (8.446 ms) : 0, 8446
Telemetry [candidate] (10.821 ms) : 0, 10821
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.48 ms) : 0, 3480
ProfilingAgent [baseline] (93.717 ms) : 0, 93717
ProfilingAgent [candidate] (94.137 ms) : 0, 94137
Profiling [baseline] (94.278 ms) : 0, 94278
Profiling [candidate] (94.704 ms) : 0, 94704
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058420
Total [baseline] (8.867 s) : 0, 8867016
Agent [candidate] (1.07 s) : 0, 1069887
Total [candidate] (8.845 s) : 0, 8845105
section iast
Agent [baseline] (1.229 s) : 0, 1229241
Total [baseline] (9.582 s) : 0, 9582038
Agent [candidate] (1.238 s) : 0, 1237734
Total [candidate] (9.595 s) : 0, 9594650
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (628.384 ms) : 0, 628384
BytebuddyAgent [candidate] (635.985 ms) : 0, 635985
AgentMeter [baseline] (29.123 ms) : 0, 29123
AgentMeter [candidate] (29.151 ms) : 0, 29151
GlobalTracer [baseline] (257.219 ms) : 0, 257219
GlobalTracer [candidate] (258.533 ms) : 0, 258533
AppSec [baseline] (31.72 ms) : 0, 31720
AppSec [candidate] (32.054 ms) : 0, 32054
Debugger [baseline] (59.397 ms) : 0, 59397
Debugger [candidate] (59.882 ms) : 0, 59882
Remote Config [baseline] (601.882 µs) : 0, 602
Remote Config [candidate] (587.196 µs) : 0, 587
Telemetry [baseline] (8.093 ms) : 0, 8093
Telemetry [candidate] (8.139 ms) : 0, 8139
Flare Poller [baseline] (6.566 ms) : 0, 6566
Flare Poller [candidate] (8.069 ms) : 0, 8069
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (797.339 ms) : 0, 797339
BytebuddyAgent [candidate] (803.557 ms) : 0, 803557
AgentMeter [baseline] (11.371 ms) : 0, 11371
AgentMeter [candidate] (11.608 ms) : 0, 11608
GlobalTracer [baseline] (247.745 ms) : 0, 247745
GlobalTracer [candidate] (249.102 ms) : 0, 249102
IAST [baseline] (25.373 ms) : 0, 25373
IAST [candidate] (25.578 ms) : 0, 25578
AppSec [baseline] (26.598 ms) : 0, 26598
AppSec [candidate] (26.766 ms) : 0, 26766
Debugger [baseline] (68.884 ms) : 0, 68884
Debugger [candidate] (69.173 ms) : 0, 69173
Remote Config [baseline] (530.953 µs) : 0, 531
Remote Config [candidate] (529.678 µs) : 0, 530
Telemetry [baseline] (10.26 ms) : 0, 10260
Telemetry [candidate] (10.258 ms) : 0, 10258
Flare Poller [baseline] (3.678 ms) : 0, 3678
Flare Poller [candidate] (3.65 ms) : 0, 3650
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (1.167 ms) : 1156, 1178
. : milestone, 1167,
iast (3.07 ms) : 3029, 3110
. : milestone, 3070,
iast_FULL (5.734 ms) : 5678, 5790
. : milestone, 5734,
iast_GLOBAL (3.608 ms) : 3549, 3667
. : milestone, 3608,
profiling (2.025 ms) : 2008, 2042
. : milestone, 2025,
tracing (1.771 ms) : 1757, 1786
. : milestone, 1771,
section candidate
no_agent (1.179 ms) : 1167, 1190
. : milestone, 1179,
iast (3.292 ms) : 3252, 3332
. : milestone, 3292,
iast_FULL (6.071 ms) : 6009, 6132
. : milestone, 6071,
iast_GLOBAL (3.591 ms) : 3532, 3650
. : milestone, 3591,
profiling (2.077 ms) : 2059, 2096
. : milestone, 2077,
tracing (1.804 ms) : 1789, 1818
. : milestone, 1804,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (17.06 ms) : 16892, 17228
. : milestone, 17060,
appsec (19.325 ms) : 19131, 19519
. : milestone, 19325,
code_origins (17.745 ms) : 17570, 17920
. : milestone, 17745,
iast (17.95 ms) : 17773, 18128
. : milestone, 17950,
profiling (18.67 ms) : 18481, 18858
. : milestone, 18670,
tracing (18.59 ms) : 18400, 18781
. : milestone, 18590,
section candidate
no_agent (17.81 ms) : 17630, 17990
. : milestone, 17810,
appsec (18.492 ms) : 18304, 18681
. : milestone, 18492,
code_origins (17.758 ms) : 17581, 17934
. : milestone, 17758,
iast (17.896 ms) : 17717, 18076
. : milestone, 17896,
profiling (18.503 ms) : 18317, 18688
. : milestone, 18503,
tracing (17.62 ms) : 17441, 17798
. : milestone, 17620,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
appsec (14.433 s) : 14433000, 14433000
. : milestone, 14433000,
iast (18.43 s) : 18430000, 18430000
. : milestone, 18430000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
profiling (15.461 s) : 15461000, 15461000
. : milestone, 15461000,
tracing (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
section candidate
no_agent (15.441 s) : 15441000, 15441000
. : milestone, 15441000,
appsec (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
iast (17.831 s) : 17831000, 17831000
. : milestone, 17831000,
iast_GLOBAL (17.876 s) : 17876000, 17876000
. : milestone, 17876000,
profiling (15.35 s) : 15350000, 15350000
. : milestone, 15350000,
tracing (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~143f058349, baseline=1.61.0-SNAPSHOT~99d47ca835
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.821 ms) : 3601, 4042
. : milestone, 3821,
iast (2.266 ms) : 2196, 2336
. : milestone, 2266,
iast_GLOBAL (2.296 ms) : 2226, 2366
. : milestone, 2296,
profiling (2.118 ms) : 2061, 2175
. : milestone, 2118,
tracing (2.057 ms) : 2003, 2110
. : milestone, 2057,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.78 ms) : 3558, 4001
. : milestone, 3780,
iast (2.261 ms) : 2191, 2330
. : milestone, 2261,
iast_GLOBAL (2.294 ms) : 2224, 2363
. : milestone, 2294,
profiling (2.09 ms) : 2034, 2145
. : milestone, 2090,
tracing (2.066 ms) : 2013, 2120
. : milestone, 2066,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
if view name is huge, this can cause out of memory errors. We can guard against values that are too big on set.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.