Remove experimental jvmti wallclock profiler#10872
Open
zhengyu123 wants to merge 2 commits intomasterfrom
Open
Remove experimental jvmti wallclock profiler#10872zhengyu123 wants to merge 2 commits intomasterfrom
zhengyu123 wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057338
Total [baseline] (10.978 s) : 0, 10977867
Agent [candidate] (1.059 s) : 0, 1059291
Total [candidate] (11.002 s) : 0, 11002104
section appsec
Agent [baseline] (1.247 s) : 0, 1246974
Total [baseline] (11.087 s) : 0, 11086708
Agent [candidate] (1.243 s) : 0, 1243424
Total [candidate] (11.099 s) : 0, 11099369
section iast
Agent [baseline] (1.225 s) : 0, 1224704
Total [baseline] (11.265 s) : 0, 11264518
Agent [candidate] (1.228 s) : 0, 1227612
Total [candidate] (11.286 s) : 0, 11286363
section profiling
Agent [baseline] (1.179 s) : 0, 1179350
Total [baseline] (11.018 s) : 0, 11017852
Agent [candidate] (1.178 s) : 0, 1177826
Total [candidate] (10.922 s) : 0, 10921895
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (626.867 ms) : 0, 626867
BytebuddyAgent [candidate] (626.559 ms) : 0, 626559
AgentMeter [baseline] (29.201 ms) : 0, 29201
AgentMeter [candidate] (29.249 ms) : 0, 29249
GlobalTracer [baseline] (256.375 ms) : 0, 256375
GlobalTracer [candidate] (257.593 ms) : 0, 257593
AppSec [baseline] (31.679 ms) : 0, 31679
AppSec [candidate] (31.815 ms) : 0, 31815
Debugger [baseline] (60.165 ms) : 0, 60165
Debugger [candidate] (60.288 ms) : 0, 60288
Remote Config [baseline] (593.174 µs) : 0, 593
Remote Config [candidate] (591.47 µs) : 0, 591
Telemetry [baseline] (8.024 ms) : 0, 8024
Telemetry [candidate] (8.073 ms) : 0, 8073
Flare Poller [baseline] (7.186 ms) : 0, 7186
Flare Poller [candidate] (8.018 ms) : 0, 8018
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (659.491 ms) : 0, 659491
BytebuddyAgent [candidate] (656.305 ms) : 0, 656305
AgentMeter [baseline] (11.968 ms) : 0, 11968
AgentMeter [candidate] (11.969 ms) : 0, 11969
GlobalTracer [baseline] (257.766 ms) : 0, 257766
GlobalTracer [candidate] (257.49 ms) : 0, 257490
AppSec [baseline] (177.396 ms) : 0, 177396
AppSec [candidate] (177.25 ms) : 0, 177250
Debugger [baseline] (66.151 ms) : 0, 66151
Debugger [candidate] (66.328 ms) : 0, 66328
Remote Config [baseline] (620.928 µs) : 0, 621
Remote Config [candidate] (605.088 µs) : 0, 605
Telemetry [baseline] (8.271 ms) : 0, 8271
Telemetry [candidate] (8.285 ms) : 0, 8285
Flare Poller [baseline] (3.616 ms) : 0, 3616
Flare Poller [candidate] (3.632 ms) : 0, 3632
IAST [baseline] (24.112 ms) : 0, 24112
IAST [candidate] (24.155 ms) : 0, 24155
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (793.83 ms) : 0, 793830
BytebuddyAgent [candidate] (795.927 ms) : 0, 795927
AgentMeter [baseline] (11.32 ms) : 0, 11320
AgentMeter [candidate] (11.343 ms) : 0, 11343
GlobalTracer [baseline] (246.87 ms) : 0, 246870
GlobalTracer [candidate] (247.639 ms) : 0, 247639
AppSec [baseline] (26.476 ms) : 0, 26476
AppSec [candidate] (26.604 ms) : 0, 26604
Debugger [baseline] (70.544 ms) : 0, 70544
Debugger [candidate] (70.538 ms) : 0, 70538
Remote Config [baseline] (532.487 µs) : 0, 532
Remote Config [candidate] (526.232 µs) : 0, 526
Telemetry [baseline] (9.227 ms) : 0, 9227
Telemetry [candidate] (9.151 ms) : 0, 9151
Flare Poller [baseline] (3.364 ms) : 0, 3364
Flare Poller [candidate] (3.317 ms) : 0, 3317
IAST [baseline] (25.301 ms) : 0, 25301
IAST [candidate] (25.323 ms) : 0, 25323
section profiling
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (680.919 ms) : 0, 680919
BytebuddyAgent [candidate] (680.039 ms) : 0, 680039
AgentMeter [baseline] (8.63 ms) : 0, 8630
AgentMeter [candidate] (8.625 ms) : 0, 8625
GlobalTracer [baseline] (214.969 ms) : 0, 214969
GlobalTracer [candidate] (214.675 ms) : 0, 214675
AppSec [baseline] (32.099 ms) : 0, 32099
AppSec [candidate] (32.129 ms) : 0, 32129
Debugger [baseline] (62.65 ms) : 0, 62650
Debugger [candidate] (63.48 ms) : 0, 63480
Remote Config [baseline] (568.956 µs) : 0, 569
Remote Config [candidate] (570.884 µs) : 0, 571
Telemetry [baseline] (10.837 ms) : 0, 10837
Telemetry [candidate] (9.976 ms) : 0, 9976
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.455 ms) : 0, 3455
ProfilingAgent [baseline] (93.226 ms) : 0, 93226
ProfilingAgent [candidate] (93.2 ms) : 0, 93200
Profiling [baseline] (93.785 ms) : 0, 93785
Profiling [candidate] (93.75 ms) : 0, 93750
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061638
Total [baseline] (8.825 s) : 0, 8824985
Agent [candidate] (1.066 s) : 0, 1065688
Total [candidate] (8.811 s) : 0, 8811264
section iast
Agent [baseline] (1.233 s) : 0, 1232803
Total [baseline] (9.583 s) : 0, 9582908
Agent [candidate] (1.224 s) : 0, 1224246
Total [candidate] (9.562 s) : 0, 9561559
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (629.885 ms) : 0, 629885
BytebuddyAgent [candidate] (632.284 ms) : 0, 632284
AgentMeter [baseline] (29.111 ms) : 0, 29111
AgentMeter [candidate] (29.281 ms) : 0, 29281
GlobalTracer [baseline] (257.448 ms) : 0, 257448
GlobalTracer [candidate] (258.306 ms) : 0, 258306
AppSec [baseline] (31.803 ms) : 0, 31803
AppSec [candidate] (31.908 ms) : 0, 31908
Debugger [baseline] (59.474 ms) : 0, 59474
Debugger [candidate] (59.806 ms) : 0, 59806
Remote Config [baseline] (598.75 µs) : 0, 599
Remote Config [candidate] (597.768 µs) : 0, 598
Telemetry [baseline] (8.091 ms) : 0, 8091
Telemetry [candidate] (8.076 ms) : 0, 8076
Flare Poller [baseline] (7.978 ms) : 0, 7978
Flare Poller [candidate] (8.048 ms) : 0, 8048
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (800.381 ms) : 0, 800381
BytebuddyAgent [candidate] (793.983 ms) : 0, 793983
AgentMeter [baseline] (11.394 ms) : 0, 11394
AgentMeter [candidate] (11.316 ms) : 0, 11316
GlobalTracer [baseline] (247.89 ms) : 0, 247890
GlobalTracer [candidate] (246.771 ms) : 0, 246771
AppSec [baseline] (26.645 ms) : 0, 26645
AppSec [candidate] (26.459 ms) : 0, 26459
Debugger [baseline] (69.64 ms) : 0, 69640
Debugger [candidate] (69.113 ms) : 0, 69113
Remote Config [baseline] (536.246 µs) : 0, 536
Remote Config [candidate] (546.65 µs) : 0, 547
Telemetry [baseline] (9.712 ms) : 0, 9712
Telemetry [candidate] (9.963 ms) : 0, 9963
Flare Poller [baseline] (3.552 ms) : 0, 3552
Flare Poller [candidate] (3.53 ms) : 0, 3530
IAST [baseline] (25.463 ms) : 0, 25463
IAST [candidate] (25.265 ms) : 0, 25265
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 15 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1177, 1201
. : milestone, 1189,
iast (3.271 ms) : 3226, 3315
. : milestone, 3271,
iast_FULL (5.91 ms) : 5851, 5968
. : milestone, 5910,
iast_GLOBAL (3.447 ms) : 3392, 3501
. : milestone, 3447,
profiling (2.103 ms) : 2084, 2121
. : milestone, 2103,
tracing (1.759 ms) : 1744, 1774
. : milestone, 1759,
section candidate
no_agent (1.182 ms) : 1170, 1194
. : milestone, 1182,
iast (3.189 ms) : 3146, 3232
. : milestone, 3189,
iast_FULL (5.69 ms) : 5634, 5746
. : milestone, 5690,
iast_GLOBAL (3.555 ms) : 3498, 3612
. : milestone, 3555,
profiling (2.064 ms) : 2045, 2084
. : milestone, 2064,
tracing (1.844 ms) : 1829, 1860
. : milestone, 1844,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (17.975 ms) : 17790, 18161
. : milestone, 17975,
appsec (18.665 ms) : 18476, 18854
. : milestone, 18665,
code_origins (17.752 ms) : 17575, 17929
. : milestone, 17752,
iast (17.643 ms) : 17464, 17822
. : milestone, 17643,
profiling (19.823 ms) : 19622, 20025
. : milestone, 19823,
tracing (17.795 ms) : 17619, 17971
. : milestone, 17795,
section candidate
no_agent (18.007 ms) : 17820, 18194
. : milestone, 18007,
appsec (18.487 ms) : 18303, 18672
. : milestone, 18487,
code_origins (17.592 ms) : 17419, 17765
. : milestone, 17592,
iast (17.632 ms) : 17457, 17807
. : milestone, 17632,
profiling (18.53 ms) : 18348, 18712
. : milestone, 18530,
tracing (17.957 ms) : 17777, 18137
. : milestone, 17957,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.566 ms) : 2507, 2624
. : milestone, 2566,
iast (2.248 ms) : 2179, 2317
. : milestone, 2248,
iast_GLOBAL (2.286 ms) : 2216, 2355
. : milestone, 2286,
profiling (2.105 ms) : 2048, 2162
. : milestone, 2105,
tracing (2.053 ms) : 1999, 2107
. : milestone, 2053,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.506 ms) : 2451, 2562
. : milestone, 2506,
iast (2.255 ms) : 2185, 2324
. : milestone, 2255,
iast_GLOBAL (2.288 ms) : 2218, 2358
. : milestone, 2288,
profiling (2.072 ms) : 2017, 2127
. : milestone, 2072,
tracing (2.057 ms) : 2003, 2111
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~89d4cec4b4, baseline=1.61.0-SNAPSHOT~3ff081cd4b
dateFormat X
axisFormat %s
section baseline
no_agent (15.57 s) : 15570000, 15570000
. : milestone, 15570000,
appsec (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
iast (17.916 s) : 17916000, 17916000
. : milestone, 17916000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
profiling (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
tracing (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
section candidate
no_agent (15.239 s) : 15239000, 15239000
. : milestone, 15239000,
appsec (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
iast (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
iast_GLOBAL (17.909 s) : 17909000, 17909000
. : milestone, 17909000,
profiling (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
tracing (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Remove
profiling.experimental.ddprof.wall.jvmtiflag, as it is no longer supported.Motivation
There are a few issues with the JVMTI-based wall-clock profiler that have limited its adoption:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-14004
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.