Store full instrumentation scope details in OtelTracer wrapper#10871
Conversation
…d to support OTLP for traces)
008c944 to
e063fac
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065962
Total [baseline] (8.867 s) : 0, 8867450
Agent [candidate] (1.052 s) : 0, 1052184
Total [candidate] (8.819 s) : 0, 8818926
section iast
Agent [baseline] (1.243 s) : 0, 1242644
Total [baseline] (9.543 s) : 0, 9543123
Agent [candidate] (1.232 s) : 0, 1231781
Total [candidate] (9.595 s) : 0, 9595270
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (631.089 ms) : 0, 631089
BytebuddyAgent [candidate] (624.998 ms) : 0, 624998
AgentMeter [baseline] (29.274 ms) : 0, 29274
AgentMeter [candidate] (29.075 ms) : 0, 29075
GlobalTracer [baseline] (257.603 ms) : 0, 257603
GlobalTracer [candidate] (255.908 ms) : 0, 255908
AppSec [baseline] (31.848 ms) : 0, 31848
AppSec [candidate] (31.472 ms) : 0, 31472
Debugger [baseline] (59.757 ms) : 0, 59757
Debugger [candidate] (59.184 ms) : 0, 59184
Remote Config [baseline] (602.789 µs) : 0, 603
Remote Config [candidate] (592.226 µs) : 0, 592
Telemetry [baseline] (8.074 ms) : 0, 8074
Telemetry [candidate] (8.064 ms) : 0, 8064
Flare Poller [baseline] (10.306 ms) : 0, 10306
Flare Poller [candidate] (5.743 ms) : 0, 5743
section iast
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (808.401 ms) : 0, 808401
BytebuddyAgent [candidate] (798.31 ms) : 0, 798310
AgentMeter [baseline] (11.807 ms) : 0, 11807
AgentMeter [candidate] (11.42 ms) : 0, 11420
GlobalTracer [baseline] (249.719 ms) : 0, 249719
GlobalTracer [candidate] (248.824 ms) : 0, 248824
AppSec [baseline] (26.965 ms) : 0, 26965
AppSec [candidate] (26.831 ms) : 0, 26831
Debugger [baseline] (68.066 ms) : 0, 68066
Debugger [candidate] (69.677 ms) : 0, 69677
Remote Config [baseline] (520.529 µs) : 0, 521
Remote Config [candidate] (529.016 µs) : 0, 529
Telemetry [baseline] (10.168 ms) : 0, 10168
Telemetry [candidate] (9.731 ms) : 0, 9731
Flare Poller [baseline] (3.624 ms) : 0, 3624
Flare Poller [candidate] (3.523 ms) : 0, 3523
IAST [baseline] (25.729 ms) : 0, 25729
IAST [candidate] (25.583 ms) : 0, 25583
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058131
Total [baseline] (11.003 s) : 0, 11002794
Agent [candidate] (1.059 s) : 0, 1059207
Total [candidate] (11.013 s) : 0, 11013493
section appsec
Agent [baseline] (1.247 s) : 0, 1246743
Total [baseline] (11.238 s) : 0, 11238034
Agent [candidate] (1.241 s) : 0, 1240563
Total [candidate] (11.196 s) : 0, 11196436
section iast
Agent [baseline] (1.225 s) : 0, 1225407
Total [baseline] (11.365 s) : 0, 11364672
Agent [candidate] (1.231 s) : 0, 1231244
Total [candidate] (11.312 s) : 0, 11312171
section profiling
Agent [baseline] (1.178 s) : 0, 1178444
Total [baseline] (11.043 s) : 0, 11043317
Agent [candidate] (1.187 s) : 0, 1186642
Total [candidate] (11.06 s) : 0, 11059729
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (627.415 ms) : 0, 627415
BytebuddyAgent [candidate] (628.28 ms) : 0, 628280
AgentMeter [baseline] (29.098 ms) : 0, 29098
AgentMeter [candidate] (29.046 ms) : 0, 29046
GlobalTracer [baseline] (256.71 ms) : 0, 256710
GlobalTracer [candidate] (256.911 ms) : 0, 256911
AppSec [baseline] (31.755 ms) : 0, 31755
AppSec [candidate] (31.638 ms) : 0, 31638
Debugger [baseline] (60.099 ms) : 0, 60099
Debugger [candidate] (60.127 ms) : 0, 60127
Remote Config [baseline] (587.354 µs) : 0, 587
Remote Config [candidate] (592.65 µs) : 0, 593
Telemetry [baseline] (7.972 ms) : 0, 7972
Telemetry [candidate] (8.115 ms) : 0, 8115
Flare Poller [baseline] (7.242 ms) : 0, 7242
Flare Poller [candidate] (7.272 ms) : 0, 7272
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (657.786 ms) : 0, 657786
BytebuddyAgent [candidate] (654.368 ms) : 0, 654368
AgentMeter [baseline] (12.064 ms) : 0, 12064
AgentMeter [candidate] (11.929 ms) : 0, 11929
GlobalTracer [baseline] (258.235 ms) : 0, 258235
GlobalTracer [candidate] (256.676 ms) : 0, 256676
AppSec [baseline] (177.953 ms) : 0, 177953
AppSec [candidate] (177.587 ms) : 0, 177587
Debugger [baseline] (66.388 ms) : 0, 66388
Debugger [candidate] (66.162 ms) : 0, 66162
Remote Config [baseline] (618.815 µs) : 0, 619
Remote Config [candidate] (606.978 µs) : 0, 607
Telemetry [baseline] (8.324 ms) : 0, 8324
Telemetry [candidate] (8.2 ms) : 0, 8200
Flare Poller [baseline] (3.618 ms) : 0, 3618
Flare Poller [candidate] (3.574 ms) : 0, 3574
IAST [baseline] (24.235 ms) : 0, 24235
IAST [candidate] (24.086 ms) : 0, 24086
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (793.901 ms) : 0, 793901
BytebuddyAgent [candidate] (797.514 ms) : 0, 797514
AgentMeter [baseline] (11.345 ms) : 0, 11345
AgentMeter [candidate] (11.433 ms) : 0, 11433
GlobalTracer [baseline] (246.871 ms) : 0, 246871
GlobalTracer [candidate] (248.497 ms) : 0, 248497
AppSec [baseline] (26.551 ms) : 0, 26551
AppSec [candidate] (26.788 ms) : 0, 26788
Debugger [baseline] (71.076 ms) : 0, 71076
Debugger [candidate] (70.927 ms) : 0, 70927
Remote Config [baseline] (538.163 µs) : 0, 538
Remote Config [candidate] (525.716 µs) : 0, 526
Telemetry [baseline] (9.202 ms) : 0, 9202
Telemetry [candidate] (9.186 ms) : 0, 9186
Flare Poller [baseline] (3.33 ms) : 0, 3330
Flare Poller [candidate] (3.352 ms) : 0, 3352
IAST [baseline] (25.282 ms) : 0, 25282
IAST [candidate] (25.519 ms) : 0, 25519
section profiling
crashtracking [baseline] (1.164 ms) : 0, 1164
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (679.808 ms) : 0, 679808
BytebuddyAgent [candidate] (685.477 ms) : 0, 685477
AgentMeter [baseline] (8.651 ms) : 0, 8651
AgentMeter [candidate] (8.639 ms) : 0, 8639
GlobalTracer [baseline] (214.84 ms) : 0, 214840
GlobalTracer [candidate] (216.136 ms) : 0, 216136
AppSec [baseline] (32.183 ms) : 0, 32183
AppSec [candidate] (32.358 ms) : 0, 32358
Debugger [baseline] (63.59 ms) : 0, 63590
Debugger [candidate] (63.804 ms) : 0, 63804
Remote Config [baseline] (583.077 µs) : 0, 583
Remote Config [candidate] (579.368 µs) : 0, 579
Telemetry [baseline] (9.249 ms) : 0, 9249
Telemetry [candidate] (9.218 ms) : 0, 9218
Flare Poller [baseline] (4.23 ms) : 0, 4230
Flare Poller [candidate] (4.281 ms) : 0, 4281
ProfilingAgent [baseline] (93.54 ms) : 0, 93540
ProfilingAgent [candidate] (93.878 ms) : 0, 93878
Profiling [baseline] (94.096 ms) : 0, 94096
Profiling [candidate] (94.445 ms) : 0, 94445
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (1.171 ms) : 1160, 1183
. : milestone, 1171,
iast (3.202 ms) : 3158, 3246
. : milestone, 3202,
iast_FULL (5.789 ms) : 5732, 5846
. : milestone, 5789,
iast_GLOBAL (3.492 ms) : 3437, 3546
. : milestone, 3492,
profiling (1.962 ms) : 1946, 1979
. : milestone, 1962,
tracing (1.795 ms) : 1781, 1810
. : milestone, 1795,
section candidate
no_agent (1.176 ms) : 1165, 1187
. : milestone, 1176,
iast (3.23 ms) : 3185, 3274
. : milestone, 3230,
iast_FULL (5.953 ms) : 5893, 6014
. : milestone, 5953,
iast_GLOBAL (3.378 ms) : 3329, 3428
. : milestone, 3378,
profiling (2.077 ms) : 2054, 2099
. : milestone, 2077,
tracing (1.789 ms) : 1774, 1804
. : milestone, 1789,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (19.506 ms) : 19308, 19705
. : milestone, 19506,
appsec (18.694 ms) : 18504, 18885
. : milestone, 18694,
code_origins (17.769 ms) : 17593, 17945
. : milestone, 17769,
iast (17.715 ms) : 17538, 17892
. : milestone, 17715,
profiling (19.786 ms) : 19580, 19992
. : milestone, 19786,
tracing (17.615 ms) : 17439, 17790
. : milestone, 17615,
section candidate
no_agent (17.976 ms) : 17793, 18160
. : milestone, 17976,
appsec (18.429 ms) : 18241, 18618
. : milestone, 18429,
code_origins (17.677 ms) : 17503, 17850
. : milestone, 17677,
iast (17.685 ms) : 17508, 17862
. : milestone, 17685,
profiling (18.454 ms) : 18268, 18639
. : milestone, 18454,
tracing (17.559 ms) : 17385, 17733
. : milestone, 17559,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.742 ms) : 3524, 3960
. : milestone, 3742,
iast (2.257 ms) : 2187, 2326
. : milestone, 2257,
iast_GLOBAL (2.301 ms) : 2231, 2371
. : milestone, 2301,
profiling (2.085 ms) : 2030, 2140
. : milestone, 2085,
tracing (2.084 ms) : 2030, 2138
. : milestone, 2084,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.8 ms) : 3578, 4022
. : milestone, 3800,
iast (2.267 ms) : 2197, 2337
. : milestone, 2267,
iast_GLOBAL (2.298 ms) : 2228, 2367
. : milestone, 2298,
profiling (2.519 ms) : 2353, 2685
. : milestone, 2519,
tracing (2.068 ms) : 2015, 2122
. : milestone, 2068,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~746cfcbcbb, baseline=1.61.0-SNAPSHOT~79fbbef465
dateFormat X
axisFormat %s
section baseline
no_agent (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
appsec (14.653 s) : 14653000, 14653000
. : milestone, 14653000,
iast (18.213 s) : 18213000, 18213000
. : milestone, 18213000,
iast_GLOBAL (17.631 s) : 17631000, 17631000
. : milestone, 17631000,
profiling (14.693 s) : 14693000, 14693000
. : milestone, 14693000,
tracing (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
section candidate
no_agent (15.575 s) : 15575000, 15575000
. : milestone, 15575000,
appsec (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
iast (18.17 s) : 18170000, 18170000
. : milestone, 18170000,
iast_GLOBAL (17.778 s) : 17778000, 17778000
. : milestone, 17778000,
profiling (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
tracing (14.659 s) : 14659000, 14659000
. : milestone, 14659000,
|
| if (Strings.isBlank(instrumentationScopeName)) { | ||
| LOGGER.debug("Tracer requested without instrumentation scope name."); | ||
| instrumentationScopeName = DEFAULT_TRACER_NAME; | ||
| } |
There was a problem hiding this comment.
We don't care about empty values for version and schemaUrl, though?
There was a problem hiding this comment.
Correct - this matches the OTel behaviour: https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkTracerProvider.java#L104
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Motivation
This is needed to support OTLP for traces, where the instrumentation scope forms part of the payload
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.