Open
Conversation
Benchmark to show cost of Atomic vs AtomicFieldUpdater
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058134
Total [baseline] (8.851 s) : 0, 8850769
Agent [candidate] (1.07 s) : 0, 1070240
Total [candidate] (8.892 s) : 0, 8891526
section iast
Agent [baseline] (1.224 s) : 0, 1224129
Total [baseline] (9.581 s) : 0, 9581023
Agent [candidate] (1.228 s) : 0, 1227589
Total [candidate] (9.585 s) : 0, 9585066
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (628.028 ms) : 0, 628028
BytebuddyAgent [candidate] (636.812 ms) : 0, 636812
AgentMeter [baseline] (29.286 ms) : 0, 29286
AgentMeter [candidate] (29.489 ms) : 0, 29489
GlobalTracer [baseline] (257.262 ms) : 0, 257262
GlobalTracer [candidate] (260.129 ms) : 0, 260129
AppSec [baseline] (31.609 ms) : 0, 31609
AppSec [candidate] (32.07 ms) : 0, 32070
Debugger [baseline] (58.818 ms) : 0, 58818
Debugger [candidate] (59.704 ms) : 0, 59704
Remote Config [baseline] (586.633 µs) : 0, 587
Remote Config [candidate] (600.677 µs) : 0, 601
Telemetry [baseline] (8.024 ms) : 0, 8024
Telemetry [candidate] (8.129 ms) : 0, 8129
Flare Poller [baseline] (7.191 ms) : 0, 7191
Flare Poller [candidate] (5.747 ms) : 0, 5747
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (794.314 ms) : 0, 794314
BytebuddyAgent [candidate] (795.388 ms) : 0, 795388
AgentMeter [baseline] (11.33 ms) : 0, 11330
AgentMeter [candidate] (11.418 ms) : 0, 11418
GlobalTracer [baseline] (247.197 ms) : 0, 247197
GlobalTracer [candidate] (248.854 ms) : 0, 248854
AppSec [baseline] (26.427 ms) : 0, 26427
AppSec [candidate] (26.656 ms) : 0, 26656
Debugger [baseline] (62.585 ms) : 0, 62585
Debugger [candidate] (62.834 ms) : 0, 62834
Remote Config [baseline] (511.73 µs) : 0, 512
Remote Config [candidate] (503.202 µs) : 0, 503
Telemetry [baseline] (14.245 ms) : 0, 14245
Telemetry [candidate] (14.209 ms) : 0, 14209
Flare Poller [baseline] (4.902 ms) : 0, 4902
Flare Poller [candidate] (4.918 ms) : 0, 4918
IAST [baseline] (25.296 ms) : 0, 25296
IAST [candidate] (25.485 ms) : 0, 25485
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071041
Total [baseline] (11.136 s) : 0, 11135538
Agent [candidate] (1.06 s) : 0, 1060416
Total [candidate] (11.165 s) : 0, 11164876
section appsec
Agent [baseline] (1.247 s) : 0, 1247015
Total [baseline] (11.238 s) : 0, 11238166
Agent [candidate] (1.252 s) : 0, 1252338
Total [candidate] (11.166 s) : 0, 11166042
section iast
Agent [baseline] (1.228 s) : 0, 1227670
Total [baseline] (11.346 s) : 0, 11346449
Agent [candidate] (1.227 s) : 0, 1227461
Total [candidate] (11.338 s) : 0, 11337549
section profiling
Agent [baseline] (1.182 s) : 0, 1182107
Total [baseline] (11.136 s) : 0, 11135744
Agent [candidate] (1.186 s) : 0, 1186448
Total [candidate] (11.107 s) : 0, 11107470
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (636.456 ms) : 0, 636456
BytebuddyAgent [candidate] (628.422 ms) : 0, 628422
AgentMeter [baseline] (29.51 ms) : 0, 29510
AgentMeter [candidate] (29.131 ms) : 0, 29131
GlobalTracer [baseline] (259.739 ms) : 0, 259739
GlobalTracer [candidate] (257.888 ms) : 0, 257888
AppSec [baseline] (32.146 ms) : 0, 32146
AppSec [candidate] (31.747 ms) : 0, 31747
Debugger [baseline] (60.313 ms) : 0, 60313
Debugger [candidate] (59.553 ms) : 0, 59553
Remote Config [baseline] (607.779 µs) : 0, 608
Remote Config [candidate] (591.333 µs) : 0, 591
Telemetry [baseline] (8.226 ms) : 0, 8226
Telemetry [candidate] (8.014 ms) : 0, 8014
Flare Poller [baseline] (6.545 ms) : 0, 6545
Flare Poller [candidate] (7.867 ms) : 0, 7867
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (658.263 ms) : 0, 658263
BytebuddyAgent [candidate] (663.307 ms) : 0, 663307
AgentMeter [baseline] (12.101 ms) : 0, 12101
AgentMeter [candidate] (12.116 ms) : 0, 12116
GlobalTracer [baseline] (258.645 ms) : 0, 258645
GlobalTracer [candidate] (259.236 ms) : 0, 259236
AppSec [baseline] (177.79 ms) : 0, 177790
AppSec [candidate] (177.806 ms) : 0, 177806
Debugger [baseline] (66.021 ms) : 0, 66021
Debugger [candidate] (65.571 ms) : 0, 65571
Remote Config [baseline] (617.879 µs) : 0, 618
Remote Config [candidate] (627.073 µs) : 0, 627
Telemetry [baseline] (8.211 ms) : 0, 8211
Telemetry [candidate] (8.218 ms) : 0, 8218
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.608 ms) : 0, 3608
IAST [baseline] (24.226 ms) : 0, 24226
IAST [candidate] (24.146 ms) : 0, 24146
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (796.21 ms) : 0, 796210
BytebuddyAgent [candidate] (795.904 ms) : 0, 795904
AgentMeter [baseline] (11.378 ms) : 0, 11378
AgentMeter [candidate] (11.378 ms) : 0, 11378
GlobalTracer [baseline] (247.686 ms) : 0, 247686
GlobalTracer [candidate] (247.712 ms) : 0, 247712
AppSec [baseline] (26.566 ms) : 0, 26566
AppSec [candidate] (27.36 ms) : 0, 27360
Debugger [baseline] (70.072 ms) : 0, 70072
Debugger [candidate] (69.334 ms) : 0, 69334
Remote Config [baseline] (528.137 µs) : 0, 528
Remote Config [candidate] (525.673 µs) : 0, 526
Telemetry [baseline] (9.196 ms) : 0, 9196
Telemetry [candidate] (9.188 ms) : 0, 9188
Flare Poller [baseline] (3.359 ms) : 0, 3359
Flare Poller [candidate] (3.341 ms) : 0, 3341
IAST [baseline] (25.332 ms) : 0, 25332
IAST [candidate] (25.31 ms) : 0, 25310
section profiling
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.164 ms) : 0, 1164
BytebuddyAgent [baseline] (682.397 ms) : 0, 682397
BytebuddyAgent [candidate] (684.593 ms) : 0, 684593
AgentMeter [baseline] (8.635 ms) : 0, 8635
AgentMeter [candidate] (8.686 ms) : 0, 8686
GlobalTracer [baseline] (215.526 ms) : 0, 215526
GlobalTracer [candidate] (216.936 ms) : 0, 216936
AppSec [baseline] (32.267 ms) : 0, 32267
AppSec [candidate] (32.468 ms) : 0, 32468
Debugger [baseline] (64.628 ms) : 0, 64628
Debugger [candidate] (64.28 ms) : 0, 64280
Remote Config [baseline] (580.971 µs) : 0, 581
Remote Config [candidate] (583.834 µs) : 0, 584
Telemetry [baseline] (7.641 ms) : 0, 7641
Telemetry [candidate] (9.202 ms) : 0, 9202
Flare Poller [baseline] (4.254 ms) : 0, 4254
Flare Poller [candidate] (3.492 ms) : 0, 3492
ProfilingAgent [baseline] (94.152 ms) : 0, 94152
ProfilingAgent [candidate] (94.081 ms) : 0, 94081
Profiling [baseline] (94.721 ms) : 0, 94721
Profiling [candidate] (94.649 ms) : 0, 94649
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1179, 1203
. : milestone, 1191,
iast (3.145 ms) : 3103, 3187
. : milestone, 3145,
iast_FULL (6.084 ms) : 6022, 6146
. : milestone, 6084,
iast_GLOBAL (3.53 ms) : 3467, 3593
. : milestone, 3530,
profiling (2.25 ms) : 2229, 2272
. : milestone, 2250,
tracing (1.821 ms) : 1804, 1839
. : milestone, 1821,
section candidate
no_agent (1.171 ms) : 1160, 1183
. : milestone, 1171,
iast (3.252 ms) : 3209, 3295
. : milestone, 3252,
iast_FULL (5.905 ms) : 5845, 5965
. : milestone, 5905,
iast_GLOBAL (3.629 ms) : 3568, 3689
. : milestone, 3629,
profiling (2.267 ms) : 2244, 2289
. : milestone, 2267,
tracing (1.833 ms) : 1817, 1849
. : milestone, 1833,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section baseline
no_agent (18.376 ms) : 18184, 18569
. : milestone, 18376,
appsec (18.51 ms) : 18322, 18698
. : milestone, 18510,
code_origins (17.784 ms) : 17608, 17960
. : milestone, 17784,
iast (17.907 ms) : 17729, 18085
. : milestone, 17907,
profiling (18.693 ms) : 18508, 18878
. : milestone, 18693,
tracing (18.023 ms) : 17847, 18200
. : milestone, 18023,
section candidate
no_agent (18.033 ms) : 17848, 18217
. : milestone, 18033,
appsec (18.511 ms) : 18323, 18700
. : milestone, 18511,
code_origins (17.972 ms) : 17791, 18152
. : milestone, 17972,
iast (17.802 ms) : 17622, 17981
. : milestone, 17802,
profiling (18.684 ms) : 18496, 18871
. : milestone, 18684,
tracing (17.752 ms) : 17576, 17928
. : milestone, 17752,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.768 ms) : 3544, 3992
. : milestone, 3768,
iast (2.252 ms) : 2183, 2321
. : milestone, 2252,
iast_GLOBAL (2.29 ms) : 2220, 2359
. : milestone, 2290,
profiling (2.076 ms) : 2021, 2131
. : milestone, 2076,
tracing (2.063 ms) : 2009, 2116
. : milestone, 2063,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.792 ms) : 3572, 4012
. : milestone, 3792,
iast (2.26 ms) : 2191, 2330
. : milestone, 2260,
iast_GLOBAL (2.293 ms) : 2224, 2362
. : milestone, 2293,
profiling (2.07 ms) : 2015, 2124
. : milestone, 2070,
tracing (2.053 ms) : 2000, 2106
. : milestone, 2053,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a18c330344, baseline=1.61.0-SNAPSHOT~3c59e03c2c
dateFormat X
axisFormat %s
section baseline
no_agent (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
appsec (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
iast (18.257 s) : 18257000, 18257000
. : milestone, 18257000,
iast_GLOBAL (17.915 s) : 17915000, 17915000
. : milestone, 17915000,
profiling (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
tracing (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
section candidate
no_agent (15.605 s) : 15605000, 15605000
. : milestone, 15605000,
appsec (14.843 s) : 14843000, 14843000
. : milestone, 14843000,
iast (17.756 s) : 17756000, 17756000
. : milestone, 17756000,
iast_GLOBAL (17.785 s) : 17785000, 17785000
. : milestone, 17785000,
profiling (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
tracing (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark to show cost of Atomic vs AtomicFieldUpdater
What Does This Do
Benchmark to show cost of Atomic vs AtomicFieldUpdater
Overall conclusion is to favor AtomicFieldUpdater when possible.
While Atomic is sometimes slightly better in ops/sec, AtomicFieldUpdater reduces memory footprint which is typically more important for the system as a whole
Motivation
Provide and illustrate recommendations to follow when contributing to the Java agent
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.