Skip to content

Caching the primaryInstrumentationName #10477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougqh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Caching the primaryInstrumentationName #10477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
022eb63
Caching the primaryInstrumentationName
dougqh Jan 29, 2026
46337ee
Merge branch 'master' into dougqh/cache-primary-instrumentation-name
dougqh Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions .../src/main/java/datadog/trace/bootstrap/instrumentation/decorator/HttpServerDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,30 @@ public abstract class HttpServerDecorator<REQUEST, CONNECTION, RESPONSE, REQUEST
private final boolean traceClientIpResolverEnabled =
Config.get().isTraceClientIpResolverEnabled();

// Used to cache the primary instrumentation name
// Deliberately not synchronized or volatile, reading a state null and
// repeating the name determination logic is fine
private String cachedPrimaryInstrumentationName = null;

/**
* Wrapper around instrumentationNames() that caches the result to avoid repeatedly allocating a
* String[]
*/
protected final String primaryInstrumentationName() {
String primaryName = cachedPrimaryInstrumentationName;
if (primaryName != null) return primaryName;

String[] instrumentationNames = instrumentationNames();
primaryName =
instrumentationNames != null && instrumentationNames.length > 0
? instrumentationNames[0]
: DEFAULT_INSTRUMENTATION_NAME;

cachedPrimaryInstrumentationName = primaryName;

return primaryName;
}

protected abstract AgentPropagation.ContextVisitor<REQUEST_CARRIER> getter();

protected abstract AgentPropagation.ContextVisitor<RESPONSE> responseGetter();
Expand Down Expand Up @@ -153,11 +177,7 @@ public Context extract(REQUEST_CARRIER carrier) {
* @return A new context bundling the span, child of the given parent context.
*/
public Context startSpan(REQUEST_CARRIER carrier, Context parentContext) {
String[] instrumentationNames = instrumentationNames();
String instrumentationName =
instrumentationNames != null && instrumentationNames.length > 0
? instrumentationNames[0]
: DEFAULT_INSTRUMENTATION_NAME;
String instrumentationName = primaryInstrumentationName();
AgentSpanContext extracted = getExtractedSpanContext(parentContext);
// Call IG callbacks
extracted = callIGCallbackStart(extracted);
Expand Down
Loading