-
Notifications
You must be signed in to change notification settings - Fork 324
Bump spotless to 8.2.1 #10456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spotless to 8.2.1 #10456
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071536
Total [baseline] (11.142 s) : 0, 11142375
Agent [candidate] (1.068 s) : 0, 1068104
Total [candidate] (10.997 s) : 0, 10997271
section appsec
Agent [baseline] (1.235 s) : 0, 1234918
Total [baseline] (11.129 s) : 0, 11128845
Agent [candidate] (1.241 s) : 0, 1240615
Total [candidate] (11.01 s) : 0, 11010106
section iast
Agent [baseline] (1.23 s) : 0, 1229975
Total [baseline] (11.23 s) : 0, 11230367
Agent [candidate] (1.23 s) : 0, 1229603
Total [candidate] (11.234 s) : 0, 11233803
section profiling
Agent [baseline] (1.185 s) : 0, 1185383
Total [baseline] (10.913 s) : 0, 10913200
Agent [candidate] (1.186 s) : 0, 1185558
Total [candidate] (10.904 s) : 0, 10903742
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (628.703 ms) : 0, 628703
BytebuddyAgent [candidate] (628.362 ms) : 0, 628362
AgentMeter [baseline] (29.079 ms) : 0, 29079
AgentMeter [candidate] (29.071 ms) : 0, 29071
GlobalTracer [baseline] (259.965 ms) : 0, 259965
GlobalTracer [candidate] (258.962 ms) : 0, 258962
AppSec [baseline] (33.491 ms) : 0, 33491
AppSec [candidate] (33.376 ms) : 0, 33376
Debugger [baseline] (64.118 ms) : 0, 64118
Debugger [candidate] (62.484 ms) : 0, 62484
Remote Config [baseline] (633.747 µs) : 0, 634
Remote Config [candidate] (634.994 µs) : 0, 635
Telemetry [baseline] (10.124 ms) : 0, 10124
Telemetry [candidate] (11.601 ms) : 0, 11601
Flare Poller [baseline] (8.512 ms) : 0, 8512
Flare Poller [candidate] (6.816 ms) : 0, 6816
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (653.244 ms) : 0, 653244
BytebuddyAgent [candidate] (654.015 ms) : 0, 654015
AgentMeter [baseline] (11.856 ms) : 0, 11856
AgentMeter [candidate] (11.976 ms) : 0, 11976
GlobalTracer [baseline] (257.853 ms) : 0, 257853
GlobalTracer [candidate] (260.466 ms) : 0, 260466
IAST [baseline] (25.35 ms) : 0, 25350
IAST [candidate] (26.146 ms) : 0, 26146
AppSec [baseline] (167.956 ms) : 0, 167956
AppSec [candidate] (169.433 ms) : 0, 169433
Debugger [baseline] (68.335 ms) : 0, 68335
Debugger [candidate] (68.208 ms) : 0, 68208
Remote Config [baseline] (683.198 µs) : 0, 683
Remote Config [candidate] (702.977 µs) : 0, 703
Telemetry [baseline] (9.296 ms) : 0, 9296
Telemetry [candidate] (9.295 ms) : 0, 9295
Flare Poller [baseline] (3.7 ms) : 0, 3700
Flare Poller [candidate] (3.753 ms) : 0, 3753
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (793.85 ms) : 0, 793850
BytebuddyAgent [candidate] (792.001 ms) : 0, 792001
AgentMeter [baseline] (11.159 ms) : 0, 11159
AgentMeter [candidate] (11.143 ms) : 0, 11143
GlobalTracer [baseline] (248.452 ms) : 0, 248452
GlobalTracer [candidate] (248.702 ms) : 0, 248702
IAST [baseline] (26.877 ms) : 0, 26877
IAST [candidate] (26.975 ms) : 0, 26975
AppSec [baseline] (32.947 ms) : 0, 32947
AppSec [candidate] (33.152 ms) : 0, 33152
Debugger [baseline] (67.412 ms) : 0, 67412
Debugger [candidate] (68.34 ms) : 0, 68340
Remote Config [baseline] (561.485 µs) : 0, 561
Remote Config [candidate] (555.976 µs) : 0, 556
Telemetry [baseline] (8.49 ms) : 0, 8490
Telemetry [candidate] (8.58 ms) : 0, 8580
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.444 ms) : 0, 3444
section profiling
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (676.062 ms) : 0, 676062
BytebuddyAgent [candidate] (676.959 ms) : 0, 676959
AgentMeter [baseline] (8.644 ms) : 0, 8644
AgentMeter [candidate] (8.592 ms) : 0, 8592
GlobalTracer [baseline] (216.287 ms) : 0, 216287
GlobalTracer [candidate] (216.558 ms) : 0, 216558
AppSec [baseline] (32.246 ms) : 0, 32246
AppSec [candidate] (32.299 ms) : 0, 32299
Debugger [baseline] (68.199 ms) : 0, 68199
Debugger [candidate] (67.65 ms) : 0, 67650
Remote Config [baseline] (584.764 µs) : 0, 585
Remote Config [candidate] (589.973 µs) : 0, 590
Telemetry [baseline] (8.732 ms) : 0, 8732
Telemetry [candidate] (8.764 ms) : 0, 8764
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.745 ms) : 0, 3745
ProfilingAgent [baseline] (99.748 ms) : 0, 99748
ProfilingAgent [candidate] (99.332 ms) : 0, 99332
Profiling [baseline] (100.32 ms) : 0, 100320
Profiling [candidate] (99.912 ms) : 0, 99912
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061114
Total [baseline] (8.714 s) : 0, 8713862
Agent [candidate] (1.058 s) : 0, 1058322
Total [candidate] (8.712 s) : 0, 8711653
section iast
Agent [baseline] (1.243 s) : 0, 1243355
Total [baseline] (9.454 s) : 0, 9453566
Agent [candidate] (1.228 s) : 0, 1228259
Total [candidate] (9.381 s) : 0, 9381307
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (624.126 ms) : 0, 624126
BytebuddyAgent [candidate] (623.337 ms) : 0, 623337
AgentMeter [baseline] (28.89 ms) : 0, 28890
AgentMeter [candidate] (28.792 ms) : 0, 28792
GlobalTracer [baseline] (257.97 ms) : 0, 257970
GlobalTracer [candidate] (257.256 ms) : 0, 257256
AppSec [baseline] (33.077 ms) : 0, 33077
AppSec [candidate] (32.887 ms) : 0, 32887
Debugger [baseline] (62.914 ms) : 0, 62914
Debugger [candidate] (60.514 ms) : 0, 60514
Remote Config [baseline] (615.694 µs) : 0, 616
Remote Config [candidate] (631.448 µs) : 0, 631
Telemetry [baseline] (9.054 ms) : 0, 9054
Telemetry [candidate] (9.801 ms) : 0, 9801
Flare Poller [baseline] (7.687 ms) : 0, 7687
Flare Poller [candidate] (8.472 ms) : 0, 8472
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (803.32 ms) : 0, 803320
BytebuddyAgent [candidate] (792.34 ms) : 0, 792340
AgentMeter [baseline] (11.627 ms) : 0, 11627
AgentMeter [candidate] (11.201 ms) : 0, 11201
GlobalTracer [baseline] (250.981 ms) : 0, 250981
GlobalTracer [candidate] (248.723 ms) : 0, 248723
IAST [baseline] (27.242 ms) : 0, 27242
IAST [candidate] (27.03 ms) : 0, 27030
AppSec [baseline] (33.496 ms) : 0, 33496
AppSec [candidate] (34.709 ms) : 0, 34709
Debugger [baseline] (67.247 ms) : 0, 67247
Debugger [candidate] (65.112 ms) : 0, 65112
Remote Config [baseline] (548.302 µs) : 0, 548
Remote Config [candidate] (545.856 µs) : 0, 546
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.515 ms) : 0, 8515
Flare Poller [baseline] (3.444 ms) : 0, 3444
Flare Poller [candidate] (3.413 ms) : 0, 3413
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1174, 1198
. : milestone, 1186,
iast (3.255 ms) : 3211, 3300
. : milestone, 3255,
iast_FULL (5.637 ms) : 5581, 5693
. : milestone, 5637,
iast_GLOBAL (3.554 ms) : 3495, 3613
. : milestone, 3554,
profiling (1.904 ms) : 1888, 1920
. : milestone, 1904,
tracing (1.791 ms) : 1776, 1807
. : milestone, 1791,
section candidate
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.162 ms) : 3120, 3204
. : milestone, 3162,
iast_FULL (5.524 ms) : 5470, 5578
. : milestone, 5524,
iast_GLOBAL (3.46 ms) : 3413, 3508
. : milestone, 3460,
profiling (2.33 ms) : 2307, 2353
. : milestone, 2330,
tracing (1.815 ms) : 1801, 1829
. : milestone, 1815,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (18.391 ms) : 18202, 18579
. : milestone, 18391,
appsec (18.742 ms) : 18556, 18929
. : milestone, 18742,
code_origins (17.667 ms) : 17493, 17840
. : milestone, 17667,
iast (17.756 ms) : 17581, 17932
. : milestone, 17756,
profiling (18.659 ms) : 18473, 18845
. : milestone, 18659,
tracing (17.716 ms) : 17539, 17892
. : milestone, 17716,
section candidate
no_agent (17.187 ms) : 17015, 17359
. : milestone, 17187,
appsec (18.832 ms) : 18642, 19022
. : milestone, 18832,
code_origins (17.617 ms) : 17442, 17793
. : milestone, 17617,
iast (19.438 ms) : 19242, 19634
. : milestone, 19438,
profiling (19.718 ms) : 19521, 19914
. : milestone, 19718,
tracing (17.63 ms) : 17460, 17800
. : milestone, 17630,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.495 ms) : 2440, 2549
. : milestone, 2495,
iast (2.247 ms) : 2178, 2316
. : milestone, 2247,
iast_GLOBAL (2.291 ms) : 2222, 2359
. : milestone, 2291,
profiling (2.118 ms) : 2062, 2175
. : milestone, 2118,
tracing (2.063 ms) : 2009, 2116
. : milestone, 2063,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.71 ms) : 3495, 3926
. : milestone, 3710,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.296 ms) : 2226, 2365
. : milestone, 2296,
profiling (2.097 ms) : 2041, 2153
. : milestone, 2097,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8e9b21b63e, baseline=1.59.0-SNAPSHOT~c53c2c595e
dateFormat X
axisFormat %s
section baseline
no_agent (14.706 s) : 14706000, 14706000
. : milestone, 14706000,
appsec (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
iast (18.201 s) : 18201000, 18201000
. : milestone, 18201000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
. : milestone, 17949000,
profiling (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
tracing (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
section candidate
no_agent (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
appsec (14.603 s) : 14603000, 14603000
. : milestone, 14603000,
iast (18.572 s) : 18572000, 18572000
. : milestone, 18572000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (15.258 s) : 15258000, 15258000
. : milestone, 15258000,
tracing (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Awesome! Thanks for pushing hard the fix upstream 💪
What Does This Do
Bump spotless to 8.2.1 as it includes my fixes diffplug/spotless#2788 diffplug/spotless#2834
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]